[bug #40241] CreateProcess failure with unixy paths

Update of bug #40241 (project make): Status:None => Fixed Open/Closed:Open => Closed Fixed Release:None => SCM Triage Status:

[bug #40241] CreateProcess failure with unixy paths

Follow-up Comment #18, bug #40241 (project make): >From several tests, it does seem to work, despite it not following BATCH_MODE_ONLY_SHELL, which is probably due to sh.exe not screwing up with quotes with unixy paths. ___ Reply to this ite

[bug #40241] CreateProcess failure with unixy paths

Follow-up Comment #17, bug #40241 (project make): MSYS Make 3.82.90 from the URL below does work well with -jN: https://sourceforge.net/projects/mingwbuilds/files/external-binary-packages/ I use that build all the time. Yes, using single quotes are also a possibility. Eventually, I need to k

[bug #40241] CreateProcess failure with unixy paths

Follow-up Comment #16, bug #40241 (project make): Using single quotes seems to be another workaround. ___ Reply to this item at: ___ Message sent via/by

[bug #40241] CreateProcess failure with unixy paths

Follow-up Comment #15, bug #40241 (project make): 3.8x deadlocks with -jN. As for paths, it's a complex issue. We can't reliably use msys paths everywhere (and for many reasons, we don't want to use more msys paths) ___ Reply to this item

[bug #40241] CreateProcess failure with unixy paths

Follow-up Comment #14, bug #40241 (project make): Indeed, that's what I see as well. Can you use the MSYS file name notation instead, as in "/c/full/path/to/python.exe"? My testing indicates that the problem disappears when this format of file names is used. Btw, these are exactly the problems

[bug #40241] CreateProcess failure with unixy paths

Follow-up Comment #13, bug #40241 (project make): Err, I was not looking at the right thing. It *is* bash not handling quotes properly: CreateProcess(C:mozilla-buildmsysbinsh.exe,C:/mozilla-build/msys/bin/sh.exe -c "c:/full/path/to/python.exe foo.py "a" b d",...)

[bug #40241] CreateProcess failure with unixy paths

Follow-up Comment #12, bug #40241 (project make): Ah no, I'm hitting it again without BATCH_MODE_ONLY_SHELL. Here is a small testcase: $ cat > foo.py < Makefile ___ Message sent via/by Savannah http://savannah

[bug #40241] CreateProcess failure with unixy paths

Follow-up Comment #11, bug #40241 (project make): Why not msys make? First, because i haven't found an msys make 4.0 build, and using msys make has its own quirks that are best avoided entirely. Why "/usr/bin/touch"? Well, it's not actually /usr/bin/touch, it's mostly /usr/bin/install or others,

[bug #40241] CreateProcess failure with unixy paths

Follow-up Comment #10, bug #40241 (project make): I actually tested the patch with MSYS Bash. Can you show me one or two examples of it mishandling quotes? I use MSYS Bash quite a lot (although not from the native Make), and never saw any problems with quotes. And, btw, if you use MSYS Bash, wh

[bug #40241] CreateProcess failure with unixy paths

Follow-up Comment #9, bug #40241 (project make): I'm using a msys bash shell, and i'm having problems with it unless I set BATCH_MODE_ONLY_SHELL. AFAICT, the patch I attached makes things use BATCH_MODE_ONLY_SHELL as I'd expect, so it works for me. I don't know why you don't want to hook at that

[bug #40241] CreateProcess failure with unixy paths

Follow-up Comment #8, bug #40241 (project make): What does "doesn't handle quotes right" mean? It's a Unixy shell, right? What kind of shell are you using? BATCH_MODE_ONLY_SHELL cannot be catered to at this stage, it's something considered at a higher level. But that higher level doesn't know

[bug #40241] CreateProcess failure with unixy paths

Follow-up Comment #7, bug #40241 (project make): Without testing this patch I know I'll probably have trouble with it, as $SHELL doesn't handle quotes right and I'm setting BATCH_MODE_ONLY_SHELL, which your patch ignores for those. ___ Repl

[bug #40241] CreateProcess failure with unixy paths

Follow-up Comment #6, bug #40241 (project make): My patch did had 2 conceptual problems, sorry. Please try this patch instead. (file #29434) ___ Additional Item Attachment: File name: w32_unixy_shell.difSize:2 KB __

[bug #40241] CreateProcess failure with unixy paths

Follow-up Comment #5, bug #40241 (project make): It worked for me, but of course I don't have your exact setup. I will have another look. (Don't worry about leaking memory, I just wanted to see if this kind of change fixes your problem. The actual change will have all this straightened up.) Th

[bug #40241] CreateProcess failure with unixy paths

Follow-up Comment #4, bug #40241 (project make): Besides the fact that your patch would leak the strdup'ed string, it doesn't work: $ ./Release/make_msvc.net2003.exe -f test.mk --trace test.mk:2: target 'foo' does not exist echo foo foo /usr/bin/touch foo /usr/bin/sh: (/w foo: No such file or dir

[bug #40241] CreateProcess failure with unixy paths

Follow-up Comment #3, bug #40241 (project make): Thanks for the test case. I'm reluctant to "go slow" in this case, because that would change the semantics of the command, as it doesn't have any shell-specific features. Instead, could you please try the attached patch? (file #29405) __

[bug #40241] CreateProcess failure with unixy paths

Follow-up Comment #2, bug #40241 (project make): Something like: foo: /usr/bin/touch $@ fails because /usr/bin/touch doesn't exist in the filesystem (so, to answer your question, the former). ___ Reply to this item at:

[bug #40241] CreateProcess failure with unixy paths

Follow-up Comment #1, bug #40241 (project make): Can you show a Makefile recipe that fails in this way? Does it fail because /usr/bin/install is actually mapped to some directory like C:\MSYS\bin, and /usr/bin does not really exist in the filesystem? Or does it fail because you think CreateProce

[bug #40241] CreateProcess failure with unixy paths

URL: Summary: CreateProcess failure with unixy paths Project: make Submitted by: glandium Submitted on: Fri 11 Oct 2013 11:54:37 AM GMT Severity: 3 - Normal Item Group: E