Re: [PATCH 1/5] optimize checking for globs

2016-11-11 Thread Paolo Bonzini
On 02/11/2016 17:24, Paolo Bonzini wrote: > +int needs_glob(const char *s) > +{ > + return strpbrk (s, "?*[") == NULL; My bad, this should be "!=" NULL. I will send a v2 when I get more feedback. Paolo > +} > +#endif > diff --git a/read.c b/read.c > index b870aa8..0883100 100644 > --- a/read

[PATCH 1/5] optimize checking for globs

2016-11-02 Thread Paolo Bonzini
This removes the hotspot in parse_file_seq's call to strpbrk, by using SSE2 vector instructions. The resulting speedup on QEMU's noop build is around 6% (15.4 seconds to 14.5). The code is roughly based on GCC's similar optimizations in the lexer. * read-opt.c: New. * read.c (parse_file_seq): Us