RE: [PATCH] Refactor and merge child_execute_job() code, new attempt

2014-03-10 Thread Pavel Fedin
Hello! > I like this patch; it looks like a good improvement! It works fine for > me on UNIX systems. > > Only one comment: > > > - /* undo CLOSE_ON_EXEC() after the child process has been started */ > > + /* undo FD_CLOEXEC after the child process has been started */ > > I think th

Re: [PATCH] Refactor and merge child_execute_job() code, new attempt

2014-03-09 Thread Paul Smith
On Wed, 2014-03-05 at 22:04 +0400, Pavel Fedin wrote: > Hello, Paul! Sorry for so long delay, i'm really quite busy, however i > have found some time to get back to this. Please review the new > version. I like this patch; it looks like a good improvement! It works fine for me on UNIX syst

[PATCH] Refactor and merge child_execute_job() code, new attempt

2014-03-05 Thread Pavel Fedin
Hello, Paul! Sorry for so long delay, i'm really quite busy, however i have found some time to get back to this. Please review the new version. This is actually a repost. I have posted this message a week ago and got no response. I suggest it fell into old thread, so you have missed it.