Re: [PATCH] Pacify GCC -Wsign-compare

2022-10-02 Thread Paul Eggert
On 9/22/22 21:29, Sam James wrote: Thanks and looks good. Thanks for reviewing. How can I get this installed into GNU Make on savannah? Or are we in some sort of quiet period before the next release, and I should wait? [1] https://lists.gnu.org/r/bug-make/2022-09/msg00126.html

Re: [PATCH] Pacify GCC -Wsign-compare

2022-09-22 Thread Sam James
> On 22 Sep 2022, at 01:24, Paul Eggert wrote: > > On 9/21/22 16:11, Sam James wrote: >> For these, could you consider including the full version? > > Sure, revised patch attached.<0001-Pacify-GCC-Wsign-compare.patch> Thanks and looks good. signature.asc Description: Message signed with Ope

Re: [PATCH] Pacify GCC -Wsign-compare

2022-09-21 Thread Paul Eggert
On 9/21/22 16:11, Sam James wrote: For these, could you consider including the full version? Sure, revised patch attached.From 83808d17d9fd28166ca174d522441edea3257804 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Tue, 20 Sep 2022 14:00:34 -0700 Subject: [PATCH] Pacify GCC -Wsign-compare

Re: [PATCH] Pacify GCC -Wsign-compare

2022-09-21 Thread Sam James
> On 20 Sep 2022, at 22:19, Paul Eggert wrote: > > * src/arscan.c (ar_scan): Pacify GCC 12.2.1 -Wsign-compare by copying > an unsigned value into a signed variable before comparing it. > Make sure it is in range before copying. > --- For these, could you consider including the full version? "1

[PATCH] Pacify GCC -Wsign-compare

2022-09-20 Thread Paul Eggert
* src/arscan.c (ar_scan): Pacify GCC 12.2.1 -Wsign-compare by copying an unsigned value into a signed variable before comparing it. Make sure it is in range before copying. --- src/arscan.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/arscan.c b/src/arscan.c index