Re: [PATCH] Fix src/function.c build failure on gcc-12.

2022-02-22 Thread Sergei Trofimovich
On Mon, 21 Feb 2022, 15:29 Paul Smith, wrote: > > On Mon, 2022-02-21 at 08:59 +, Edward Welbourne wrote: > > and that's assuming a 32-bit int; the signed range is from - > > 2,147,483,647 to 2,147,483,648. However, may I suggest the following > > (which I know included in the GPL'd cfengine s

Re: [PATCH] Fix src/function.c build failure on gcc-12.

2022-02-21 Thread Paul Smith
On Mon, 2022-02-21 at 08:59 +, Edward Welbourne wrote: > and that's assuming a 32-bit int; the signed range is from - > 2,147,483,647 to 2,147,483,648.  However, may I suggest the following > (which I know included in the GPL'd cfengine sources at some point): This computation is already inclu

Re: [PATCH] Fix src/function.c build failure on gcc-12.

2022-02-21 Thread Paul Smith
On Mon, 2022-02-21 at 08:59 +, Edward Welbourne wrote: > and that's assuming a 32-bit int; the signed range is from - > 2,147,483,647 to 2,147,483,648.  However, may I suggest the following > (which I know included in the GPL'd cfengine sources at some point): This computation is already inclu

Re: [PATCH] Fix src/function.c build failure on gcc-12.

2022-02-21 Thread Edward Welbourne
Sergei Trofimovich (19 February 2022 00:48) reports: > Upcoming gcc-12 detects possible buffer overflow for 1 byte: [snip] > Unlikely numbers like '-1234567890' including null terminator take 12 > bytes of storage. and that's assuming a 32-bit int; the signed range is from -2,147,483,647 to 2,147,

[PATCH] Fix src/function.c build failure on gcc-12.

2022-02-18 Thread Sergei Trofimovich
From: Sergei Trofimovich Upcoming gcc-12 detects possible buffer overflow for 1 byte: src/function.c: In function 'func_call': src/function.c:2781:24: error: '__builtin___sprintf_chk' may write a terminating nul past the end of the destination [-Werror=format-overflow=8] 2781 |