RE: [PATCH] Fix output-sync option on EMX - updated

2014-01-17 Thread Pavel Fedin
Hello! > Done. Thank you very much! > My take on this is that I need to see the refactoring to say something > intelligent about it. Ok, of course. :) Currently i have some high-priority problems here, when i have more time i'll get back to it and of course post the patch. Kind regards, Pa

Re: [PATCH] Fix output-sync option on EMX - updated

2014-01-16 Thread Eli Zaretskii
> From: Pavel Fedin > Cc: bug-make@gnu.org > Date: Thu, 16 Jan 2014 10:03:38 +0400 > > > Thanks, this variant is fine with me. > > Good. I'm waiting for it to be committed Done. > In order to make it switched at runtime, i would like to refactor > child_execute_job(). I have suggested this e

RE: [PATCH] Fix output-sync option on EMX - updated

2014-01-15 Thread Pavel Fedin
Hello! > Thanks, this variant is fine with me. Good. I'm waiting for it to be committed, since i would like to go on with merging spawn-patch. In order to make it switched at runtime, i would like to refactor child_execute_job(). I have suggested this earlier, nobody replied. Kind regards, Pa

Re: [PATCH] Fix output-sync option on EMX - updated

2014-01-15 Thread Eli Zaretskii
> From: Pavel Fedin > Cc: bug-make@gnu.org > Date: Wed, 15 Jan 2014 10:23:58 +0400 > > I have rechecked. Actually NO_OUTPUT_SYNC is defined only by handmade > config.h files for DOS, VMS and Amiga. EMX uses configure script, so > NO_OUTPUT_SYNC will not be defined. > However, indeed, there is ra

[PATCH] Fix output-sync option on EMX - updated

2014-01-14 Thread Pavel Fedin
Hello! > Thanks, but does EMX support output-sync? If not, this fragment: > > + /* Divert child output if output_sync in use. */ > + if (child->output.syncout) > +{ > + if (child->output.out >= 0) > +outfd = child->output.out; > + if

Re: [PATCH] Fix output-sync option on EMX

2014-01-14 Thread Pavel Fedin
Hello, Eli. Tuesday, January 14, 2014, 22:50:28 you wrote: > The part you replaced with "..." sounds like an important qualifier to > me. > I also have hard time believing that these 4 lines is all it takes to > support output-sync on EMX. If you remember my original spawn-patch, all it do

Re: [PATCH] Fix output-sync option on EMX

2014-01-14 Thread Eli Zaretskii
> From: David Boyce > Date: Tue, 14 Jan 2014 13:13:13 -0500 > Cc: Pavel Fedin , bug-make > > On Tue, Jan 14, 2014 at 12:41 PM, Eli Zaretskii wrote: > > Thanks, but does EMX support output-sync? > > Didn't he just say "The purpose of this piece is to add missing > support for output-sync option

Re: [PATCH] Fix output-sync option on EMX

2014-01-14 Thread David Boyce
On Tue, Jan 14, 2014 at 12:41 PM, Eli Zaretskii wrote: > Thanks, but does EMX support output-sync? Didn't he just say "The purpose of this piece is to add missing support for output-sync option to [...] EMX"? David ___ Bug-make mailing list Bug-make@g

Re: [PATCH] Fix output-sync option on EMX

2014-01-14 Thread Eli Zaretskii
> From: Pavel Fedin > Date: Tue, 14 Jan 2014 11:11:35 +0400 > > This is part of my spawn-patch for Make. The purpose of this piece is to > add missing support for output-sync option to spawn()-based flavors > (currently only EMX). Thanks, but does EMX support output-sync? If not, this fragment

[PATCH] Fix output-sync option on EMX

2014-01-13 Thread Pavel Fedin
Hello! This is part of my spawn-patch for Make. The purpose of this piece is to add missing support for output-sync option to spawn()-based flavors (currently only EMX). Tested together with the rest of spawn-patch under Cygwin, works fine. Kind regards, Pavel Fedin Expert Engineer Samsung Elec