Re: [PATCH] Fix nonzero detection in integer parsing

2022-01-17 Thread Paul Smith
On Thu, 2022-01-13 at 23:31 +0100, Jouke Witteveen wrote: > I would like to draw attention to this patch again, since without > it the intcmp function is misbehaving. Thanks for reminding me: somehow the original got deleted from my inbox without being applied. I've now applied it to my Git repo

Re: [PATCH] Fix nonzero detection in integer parsing

2022-01-13 Thread Jouke Witteveen
On Mon, Dec 20, 2021 at 8:24 PM Jouke Witteveen wrote: > > * src/function.c (parse_textint): Fix nonzero detection. > * tests/scripts/functions/intcmp: Extend test coverage. > --- > > The `*p++ == '0'` test should have been `*p++ != '0'` and did not need > to be repeated for every digit anyway. B

[PATCH] Fix nonzero detection in integer parsing

2021-12-20 Thread Jouke Witteveen
* src/function.c (parse_textint): Fix nonzero detection. * tests/scripts/functions/intcmp: Extend test coverage. --- The `*p++ == '0'` test should have been `*p++ != '0'` and did not need to be repeated for every digit anyway. By pure luck, all numbers used in tests included a digit '0', so this