Re: [PING] [PATCH] Escape space in path to $SHELL

2023-07-13 Thread Torbjorn SVENSSON
Thanks for the reply Paul. On 2023-07-12 17:19, Paul Smith wrote: On Wed, 2023-07-12 at 17:11 +0200, Torbjorn SVENSSON wrote: * src/job.c (construct_command_argv_internal): Escape space in $SHELL Unfortunately this is so simple. Currently the spaces in the SHELL variable are not escaped, and

Re: [PING] [PATCH] Escape space in path to $SHELL

2023-07-12 Thread Paul Smith
On Wed, 2023-07-12 at 17:11 +0200, Torbjorn SVENSSON wrote: > > * src/job.c (construct_command_argv_internal): Escape space in > > $SHELL Unfortunately this is so simple. Currently the spaces in the SHELL variable are not escaped, and things like this work: SHELL := /bin/sh -x and do what y

[PING] [PATCH] Escape space in path to $SHELL

2023-07-12 Thread Torbjorn SVENSSON
Gentle ping... Kind regards, Torbjörn On 2023-07-05 11:09, Torbjörn SVENSSON wrote: One way to trigger the error is to set SHELL to a path that contain one space character. To test the behavior, the following can be used: TESTDIR="`mktemp -d '/tmp/make test.XX'`" && \ m

[PATCH] Escape space in path to $SHELL

2023-07-05 Thread Torbjörn SVENSSON
One way to trigger the error is to set SHELL to a path that contain one space character. To test the behavior, the following can be used: TESTDIR="`mktemp -d '/tmp/make test.XX'`" && \ mkdir -p "$TESTDIR" && \ cd "$TESTDIR" && \ ln -s /bin/sh sh && \