Re: GNU make troubleshooting

2023-07-16 Thread Torbjorn SVENSSON
On 2023-07-16 15:58, Alejandro Colomar wrote: Wow! That's a great help for debugging the Linux man-pages's makefiles, which don't need to be remade. It was very painful to me to ignore so much make -d output. I applied the following patch, and it works like a charm.

Re: [PING] [PATCH] Escape space in path to $SHELL

2023-07-13 Thread Torbjorn SVENSSON
Thanks for the reply Paul. On 2023-07-12 17:19, Paul Smith wrote: On Wed, 2023-07-12 at 17:11 +0200, Torbjorn SVENSSON wrote: * src/job.c (construct_command_argv_internal): Escape space in $SHELL Unfortunately this is so simple. Currently the spaces in the SHELL variable are not escaped

[PING] [PATCH] Escape space in path to $SHELL

2023-07-12 Thread Torbjorn SVENSSON
Gentle ping... Kind regards, Torbjörn On 2023-07-05 11:09, Torbjörn SVENSSON wrote: One way to trigger the error is to set SHELL to a path that contain one space character. To test the behavior, the following can be used: TESTDIR="`mktemp -d '/tmp/make test.XX'`" && \ m

[PING^2] [PATCH 0/6] Fix compilation errors in maintainer mode

2023-07-01 Thread Torbjorn SVENSSON
Gentle 2nd ping. Could anyone with write access review these patches and apply them for me if there is no comments on them? Kind regards, Torbjörn On 2023-06-19 09:03, Torbjorn SVENSSON wrote: Ping! Kind regards, Torbjörn On 2023-06-09 16:09, Torbjörn SVENSSON wrote: Hi, This patch

Re: [PATCH 0/6] Fix compilation errors in maintainer mode

2023-06-19 Thread Torbjorn SVENSSON
Ping! Kind regards, Torbjörn On 2023-06-09 16:09, Torbjörn SVENSSON wrote: Hi, This patch series addresses all the errors that GCC 7.3 emits when cross building for Windows in maintainer mode. Kind regards, Torbjörn

Re: [PATCH 1/6] Fix GCC compile warning for "declaration-after-statement"

2023-06-09 Thread Torbjorn SVENSSON
On 2023-06-09 16:53, Martin Dorey wrote: Primed by our earlier discussion, I wondered "How does that fix the bad-function-cast warning?", before belatedly noticing the Subject. This particular patch does not address the bad cast, it's addressed in patch 6 of the series. -

Re: Unable to cross build for Windows

2023-06-09 Thread Torbjorn SVENSSON
On 2023-06-09 09:11, Eli Zaretskii wrote: From: Martin Dorey CC: "bug-make@gnu.org" Date: Fri, 9 Jun 2023 06:32:28 + msip_labels: #include intptr_t _get_osfhandle(int); typedef void* HANDLE; HANDLE fn() {   return (HANDLE)_get_osfhandle(0); } martind@sirius:~/tmp/svensson-2023-06-08

Re: Unable to cross build for Windows

2023-06-09 Thread Torbjorn SVENSSON
On 2023-06-09 14:44, Paul Smith wrote: On Fri, 2023-06-09 at 14:16 +0200, Torbjorn SVENSSON wrote: The only thing left, that I don't know how to handle, is the use of O() where the 3rd parameter is not a string literal. src/job.c: In function 'create_batch_file': src/job

Re: Unable to cross build for Windows

2023-06-08 Thread Torbjorn SVENSSON
On 2023-06-08 17:05, Eli Zaretskii wrote: Date: Thu, 8 Jun 2023 16:19:04 +0200 CC: From: Torbjorn SVENSSON On 2023-06-08 16:14, Eli Zaretskii wrote: Date: Thu, 8 Jun 2023 14:44:35 +0200 From: Torbjorn SVENSSON /build/gnu-make_4.4.1-45-g07fcee35/src/function.c: In function

Re: Unable to cross build for Windows

2023-06-08 Thread Torbjorn SVENSSON
On 2023-06-08 16:14, Eli Zaretskii wrote: Date: Thu, 8 Jun 2023 14:44:35 +0200 From: Torbjorn SVENSSON /build/gnu-make_4.4.1-45-g07fcee35/src/function.c: In function 'windows32_openpipe': /build/gnu-make_4.4.1-45-g07fcee35/src/function.c:1676:12: error: cast from function ca