een started */
>
> I think this change should be reverted, since we decided to keep the
> CLOSE_ON_EXEC() macro.
Of course, i've just forgot about the comment. :)
Ok, i'm waiting for the change to be committed in order to proceed with
Cygwin specifics.
Kind regards,
Pavel Fedi
Hello, Paul! Sorry for so long delay, i'm really quite busy, however i
have found some time to get back to this. Please review the new
version.
This is actually a repost. I have posted this message a week ago and
got no response. I suggest it fell into old thread, so you have missed
it.
Hello, Paul! Sorry for so long delay, i'm really quite busy, however i
have found some time to get back to this. Please review the new
version.
Monday, February 3, 2014, 0:30:26 you wrote:
> I prefer the macro form as well; please keep it that way.
Done.
> Also, I'm not sure I like the
Hello, Paul!
I have read your suggestions and i think i can implement them. But,
sorry, not earlier than weekend. Starting to be extremely busy...
--
С уважением,
Pavel mailto:pavel_fe...@mail.ru
___
Bug-make mailing lis
hank you for your appreciation.
By the way, i have two systems of Amiga family (MorphOS and AROS), are you
interested in testing and some face-lifting to Amiga-specific code ?
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
___
Bug-make mailing list
Bug-make@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-make
Ooops, sorry. It's really too late here, so i'm a bit impatient.
Forgot to regenerate .diff after last-minute change. Better use this
version. In it return type of child_execute_job() is changed from int to
pid_t, as it should be.
--
С уважением,
Pavel mailto:p
Hello! This is my long-promised refactor. After this it's much easier
to apply runtime selection between spawn() and fork() on Cygwin,
because all differences are now consolidated in two functions:
child_execute_process() and exec_command().
Insome critical POSIX-specific
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
___
Bug-make mailing list
Bug-make@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-make
regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
___
Bug-make mailing list
Bug-make@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-make
Please take the updated patch. I have verified it to build by supplying
CPPFLAGS=-DNO_OUTPUT_SYNC to configure.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
make-fix-output-sync-emx.diff
Description: Binary data
_
Hello, Eli.
Tuesday, January 14, 2014, 22:50:28 you wrote:
> The part you replaced with "..." sounds like an important qualifier to
> me.
> I also have hard time believing that these 4 lines is all it takes to
> support output-sync on EMX.
If you remember my original spawn-patch, all it do
mmands are emulated by Make
itself in such a case, but only a very small number.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
___
Bug-make mailing list
Bug-make@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-make
Hello!
This is part of my spawn-patch for Make. The purpose of this piece is to
add missing support for output-sync option to spawn()-based flavors
(currently only EMX).
Tested together with the rest of spawn-patch under Cygwin, works fine.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung
Hello!
I am trying to rebuild GIT version of Make, however .po files are missing
in the repository. Is this intentional ? I have copied them over from my
4.0-2 archive. But where are they originally stored ?
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
Title: Re: win32 compilation of make 4.0 source code
Hello, Mark.
Monday, January 13, 2014, 17:57:20 you wrote:
Is the resulting file supposed to executed under Cygwin ?
No.
If you build Make natively for Windows, this results in native Windows version.
Cygwin is actually quite a dif
e of gcc >= v4). Or
could it check something like $(HOST) set by makefile ?
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
___
Bug-make mailing list
Bug-make@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-make
Hello, Eli.
Saturday, November 23, 2013, 12:00:49 you wrote:
>> and that means that I need to use --host=i586-mingw32msvc when building
>> make.
> Why does the prefix end with "msvc"? The MSVC compiler is not
> involved in this build or in the target system, so the prefix sounds
> wrong.
May
never replaces itself with some other process which needs
to inherit all internal file descriptors. So, the code can be further
simplified.
Any thoughts / pros / contras ?
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
_
oesn't
introduce any new #ifdef's. Neither it touches VMS-specific code.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
___
Bug-make mailing list
Bug-make@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-make
to ignore
child->output settings. I see that VMS version of 'child_execute_job' gets the
complete 'child' structure, i have checked it but it seems to ignore these new
members.
So i've got one more question - may be this fragment should become completely
generic ? Just with some not
Hello!
I am restarting work on spawn-patch for Cygwin. Actually, i have the very
first version working, but want to try to do some face-lift and get rid of
some #ifdef's.
My first question is: is VMS port maintained, or dead long ago ?
Kind regards,
Pavel Fedin
Expert Engineer
Sa
don't have time, and perhaps i won't be
able to fix this before the next release. I will keep an eye on it in the
future.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
___
Bug-make mailing list
Bug-ma
e to take a look at my spawn patch on weekend. I remember
about env-variable agreement. :)
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
___
Bug-make mailing list
Bug-make@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-make
ekend.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
___
Bug-make mailing list
Bug-make@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-make
Hello, Denis.
Thursday, September 26, 2013, 13:39:02 you wrote:
> The most needed thing to fix is
> ${abspath /foo}
> that currently returns "/cy/foo"
Yes, this is exactly that problem.
abspath first detects whether it is given an absolute path. If not,
it prepends current working directo
se (relative)" sequence. Perhaps does not worth
it. Actually when i made my implementation i took care about making the code
clear to read and understand since it can be tricky.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
___
Cygwin build,
> which is a much worse alternative.
Just a reminder. I have followed your suggestion and fixed this a month
ago. Please try this:
http://lists.gnu.org/archive/html/bug-make/2013-08/msg00031.html
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Researc
Hello, Denis.
Tuesday, September 24, 2013, 14:34:35 you wrote:
> the Makefile above (and all the real examples that i have tested so
> far) seem to work. Hence, the treatement for stderr must be
> erroneous somewhere. I've performed several trials, adding or removing
> some code in this area, but
Hello, Eli.
Tuesday, September 24, 2013, 20:19:52 you wrote:
> If someone submits a patch that enables spawn for Cygwin under a
> special option, I promise to review it favorably.
Is it appropriate time to do this ?
I am passively following the list and at least notice what happens. I
remember
Hello, Denis.
Tuesday, September 24, 2013, 20:58:26 you wrote:
>> I'm not sure if Pavel is on this list so adding him explicitly.
> This was done.
Hello! I'm still here, Busy but here. I have not read it all
carefully but i've noticed my name, so i'm reading it now...
--
С уважением,
sses make test
suite. Could you exactly tell me what breaks and where, so that i could
reproduce the problem ? This would be very helpful.
Actually i have some glitches with -j, but i also had glitches without this
patch.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research cent
ns, Microsoft is not interested in
solving this because they say absolutely the same phrase about POSIX and all
that. And, in fact, their phrase weights much more, because they already own
the computing world.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Resear
ponses to this ?
P. S. Eli, what about my other work (abspath fix) ? I don't see it in GIT
log, and also i see no feedback, so... May be you just don't want to accept
anything, and i'm just annoying you ?
Kind regards,
Pavel Fedin
Expert Engineer
Samsung
Hello, Paul.
Friday, August 16, 2013, 22:18:31 you wrote:
>> Presumably make works at least 99% correctly on Windows using spawn*().
>> I don't doubt at all that the patch actually works great with most uses
>> of make in Cygwin. However, I would rather be 100% correct and slower
>> than 99% cor
Hello, Christopher.
Friday, August 16, 2013, 19:19:58 you wrote:
> Also, when I'm making changes to the exec() code I don't spend a lot of
> time worrying about spawn() so it is possible that it will be broken
> from time to time and, in fact, I think you actually noticed some
> breakage in the c
Hello, Denis.
Sunday, August 11, 2013, 10:54:25 you wrote:
> As a user, i would be fully happy if the behavior could be driven by the
> MAKE_USE_SPAWN env. var. (and a similar env. var. in case the default is
> spawn).
> Associated command line options would be unnecessary, but perhaps needed fo
ngw*" which skips the
test and sets ';' manually (or does not set anything, relying on fallback).
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
make-3.82.90-1-update-win32-config.diff
Description: Binary data
keep HAVE_DOS_PATHS enabled on Cygwin, with this
change configure hint can be removed.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
make-3.82.90-1-fix-dos-paths-compatibility.diff
Description: Binary data
___
Bug
o '/' as temp directory, which
fails miserably on post-XP because accessing C:\ requires elevated
privilege.
Sorry for not providing a .diff, but this is one-line fix, and approving it
is IMHO too much overhead.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research ce
he operating system does not work with address
spaces (it's similar to ucLinux or ELKS).
So, being unable to fork() does not automatically mean being non-POSIX.
But, well, this is just an ideological argue and can be omitted.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
___
Bug-make mailing list
Bug-make@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-make
for building MSYS version.
Ok, good, currently i already have an implementation which works fine on
Cygwin and passes all test suite. Now i want to try to build pure Windows
version and make sure that it at least doesn't become worse. I need some
time to test it and to ap
clever heuristics,
but i don't see how it would be possible to determine whether e.g. /foo/bar
is an absolute path of DOS-style relative one.
Will this solution be OK ?
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
___
Hello!
> In that case, we need to fix 'abspath', not disable this feature.
Ok. If you don't mind, i can try new approach on this. Will it be OK ?
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
__
directory
to be part of PATH (DOS/Windows-style behavior).
OK, if you really-really don't care about what someone other than you
think, can you accept last chunk of the patch for now (variable rename) ?
This would decrease size of speedup patch which i will have to maintain.
K
Hello, Eli.
Monday, August 5, 2013, 18:44:17 you wrote:
> I don't yet understand why you have a problem in the first place. It
> sounds like the single issue is with the 'abspath' function, is that
> correct?
Yes, correct.
2 Christopher Faylor:
> ac_cv_dos_paths=no configure
>
> works just
mething which is not in
your system PATH. Cygwin's spawnvpe() screws up badly in such situation.
The new patch is attached. I have tested building Cygwin source, works fine.
Please test. If OK, i can retry pushing it upstream.
--
Kind regards, Pavel Fedin
make-3.82.90-1-use-spawn-on-cygwin
ygwin and Yes on MinGW ?
IMHO it's a little bit inconvenient that you have to use config.cache trick
in order to build a fully working Make for Cygwin, and this is not
documented anywhere. First time, when i didn't know about this, i've got a
problem.
Kind regards,
Pavel Fedin
i did not test this further because i follow official Cygwin way of
doing things, and Cygwin deprecates usage of DOS style paths, obviously
because they create lots of problems in UNIX utilities which are not
modified to handle them. Cygwin even warns you when some API functions get
DOS paths.
Ok, actuall
and Microsoft (of course)
apparently doesn't care.
I have tested my patched version with make's bundled test suite. As well as
by some heavy load like building ARM-targeted GNU toolchain with -j9 option
or building Linux kernel (yes, under Cygwin). Works fine.
Kind regards,
Pavel Fedin
to test them all in a
reasonable time frame. Unless you (Make developers) make a decision to drop
these platforms completely.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
___
Bug-make mailing list
Bug-make
, then maybe perhaps something like
--enable-dos-paths should be introduced ? If the user really wants DOS
paths under Cygwin, and completely understands what he is doing, then
let him specify this on the command line.
--
Kind regards, Pavel Fedin
___
.
--
Kind regards, Pavel Fedin
___
Bug-make mailing list
Bug-make@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-make
MinGW team about __MSYS__ definition. MSys is
close to Cygwin, so perhaps this should also be removed.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
make-3.82.90-1-no-dos-paths-on-cygwin.diff
Description: Binary
Hello!
Please take this patch, Cygwin team told that they would like to integrate
with upstream. I have already posted it some time ago but got no reply.
The patch significantly improves performance of Make under Cygwin.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research
54 matches
Mail list logo
