Re: patch locale settings

2019-09-15 Thread Paul Smith
On Sun, 2019-09-15 at 13:01 -0400, Dmitry Goncharov wrote: > perl will tell you that it does not know what POSIX::LC_MESSAGES is. > > This patch initializes has_posix right here in test_driver.pl and pulls in > locale_h. > This patch sets LC_ALL because we saw that LANG has an affect. > This patc

Re: [bug #56895] Cannot build make due to compiler warnings/failures

2019-09-15 Thread David A. Wheeler
Ah, ok, I had assumed the fallthrough was intentional. Looks like the warning found a real bug. As far as the other changes go, dealing with them some other way would be great. I just needed to be able to compile the code. --- David A.Wheeler___ Bug-ma

[bug #56895] Cannot build make due to compiler warnings/failures

2019-09-15 Thread Paul D. Smith
Follow-up Comment #2, bug #56895 (project make): I think the fall through in read.c is incorrect. I think this code is broken when HAVE_DOS_PATHS is set. I can't see any justification for falling through into the variable case if we find a ":" in a drive spec. If we detect a ":" in a drive spec

[bug #56895] Cannot build make due to compiler warnings/failures

2019-09-15 Thread Paul D. Smith
Follow-up Comment #1, bug #56895 (project make): The failure for find_in_given_path() is because one version of that function was pushed to gnulib, then I pushed my changes to use it to GNU make, then another version of that function with a different calling signature was pushed to gnulib so if yo

Trivial fixes so "make" can compile on Cygwin

2019-09-15 Thread David A. Wheeler
It turns out that the latest git release of make won't compile on Cygwin (commit 271e572ba2f16f8d5b1d45c768bdec060073c279, Author Eli Zaretskii, Date: Tue Sep 10 19:09:39 2019 +0300). The problem is some trivial warnings that, because of -WError, halt compilation. The warnings are trivially fixe

[bug #56895] Cannot build make due to compiler warnings/failures

2019-09-15 Thread David A. Wheeler
Additional Item Attachment, bug #56895 (project make): File name: ,trivial-compile-fixes Size:2 KB ___ Reply to this item at:

Re: patch locale settings

2019-09-15 Thread Dmitry Goncharov via Bug reports and discussion for GNU make
On Sun, Sep 15, 2019 at 10:14:07AM -0400, Paul Smith wrote: > I see. I wonder why it works for me. i was thinking your system couldn't do anything other than the default, but your german test demonstrates it can. > > > Let me come up with a fix for 'perl run_make_tests.pl'. if you set use stric

Re: patch locale settings

2019-09-15 Thread Paul Smith
On Sun, 2019-09-15 at 09:44 -0400, Dmitry Goncharov wrote: > > So, the question is why does your Perl still provide language-specific > > messages? > has_POSIX is uninitialized at the time test_driver.pl reads it, because > (atleast in my testing) the code which initializes has_POSIX hasn't run yet

Re: patch locale settings

2019-09-15 Thread Dmitry Goncharov via Bug reports and discussion for GNU make
On Sun, Sep 15, 2019 at 08:31:39AM -0400, Paul Smith wrote: > That's because before we try to detect these messages we explicitly set > the locale in Perl; see test_driver.pl: > > my $loc = undef; > if ($has_POSIX) { > $loc = POSIX::setlocale(POSIX::LC_MESSAGES); > POSIX::setlocale

Re: patch locale settings

2019-09-15 Thread Paul Smith
On Sat, 2019-09-14 at 22:31 -0400, Dmitry Goncharov wrote: > On Sat, Sep 14, 2019 at 6:27 PM Paul Smith wrote: > > Your setting of LANG or LC_MESSAGES > > cannot make any difference to the test suite because the test suite > > does not pass those values to the make that it invokes. > > Paul, that