[bug #56895] Cannot build make due to compiler warnings/failures

URL: Summary: Cannot build make due to compiler warnings/failures Project: make Submitted by: dwheeler Submitted on: Sun 15 Sep 2019 03:32:15 AM UTC Severity: 3 - Normal

Re: patch out of source builds

On Sat, Sep 14, 2019 at 6:39 PM Paul Smith wrote: > Rather, the above comment refers to testing like this: ... > That is, running the tests from within the remote build directory > "tests", not from within the source directory "tests". Thank you. This indeed clarifies it. The purpose of the patch

Re: patch locale settings

On Sat, Sep 14, 2019 at 6:27 PM Paul Smith wrote: > Your setting of LANG or LC_MESSAGES > cannot make any difference to the test suite because the test suite > does not pass those values to the make that it invokes. Paul, that's the output from the perl program (called base) that is affected by t

Re: patch out of source builds

On Fri, 2019-09-13 at 21:40 -0400, Dmitry Goncharov via Bug reports and discussion for GNU make wrote: > -The third serious problem is that it's not relocatable: the only > -way it works when you build out of the source tree is to create > -symlinks, which doesn't work on every system and is bogus

Re: patch locale settings

On Sat, 2019-09-14 at 18:27 -0400, Paul Smith wrote: Can you apply the attached patch Oops ignore/delete the diff of m4/.gitignore :( ___ Bug-make mailing list Bug-make@gnu.org https://lists.gnu.org/mailman/listinfo/bug-make

Re: patch locale settings

On Sat, 2019-09-14 at 16:19 -0400, Dmitry Goncharov wrote: > On Sat, Sep 14, 2019 at 10:22 AM Paul Smith wrote: > > and, I've checked with a makefile invoked by the test suite and > > this setting is in effect, even if the shell invoking > > run_make_tests.pl has a different setting for LC_ALL. >

[bug #56892] toxic combination of -include and match-anything rules

Update of bug #56892 (project make): Item Group: Bug => Enhancement ___ Reply to this item at: ___ Messa

[bug #56892] toxic combination of -include and match-anything rules

Follow-up Comment #3, bug #56892 (project make): I can think of one way to address these types of issues that might not be too impactful: Make knows both how deep inside a recursion it is (via MAKELEVEL) and also how many times its re-exec'd itself (via MAKE_RESTARTS). It could check to see if e

[bug #56892] toxic combination of -include and match-anything rules

Follow-up Comment #2, bug #56892 (project make): Ok. WRT your second point, you are of course right and I didn't think it out properly. WRT the delayed warning being new as of 4.2.1, I didn't know that and agree that it's a serious compatibility issue, so I'm happy to drop this. _

[bug #56892] toxic combination of -include and match-anything rules

Follow-up Comment #1, bug #56892 (project make): It is definitely not the case that we can ignore -include if the makefile doesn't exist. In fact until recently, virtually every makefile that needed to be rebuilt would be included with "-include", because otherwise you'd get a warning that the fi

[bug #56892] toxic combination of -include and match-anything rules

URL: Summary: toxic combination of -include and match-anything rules Project: make Submitted by: boyski Submitted on: Sat 14 Sep 2019 08:28:32 PM UTC Severity: 3 - Normal

Re: patch locale settings

On Sat, Sep 14, 2019 at 10:22 AM Paul Smith wrote: > and, I've checked with a makefile invoked by the test suite and this > setting is in effect, even if the shell invoking run_make_tests.pl has > a different setting for LC_ALL. This should be sufficient. > Furthermore, we clear out the environm

Re: patch to fix grouped_targets test 1

On Tue, 2019-09-10 at 20:36 -0400, Dmitry Goncharov via Bug reports and discussion for GNU make wrote: > echo -n is not portable. > Certain implementations of echo everything, including -n. > This makes test 1 of grouped_targets fail. This was already fixed by a patch from Paul Eggert on Aug 27. T

Re: patch locale settings

On Fri, 2019-09-13 at 21:43 -0400, Dmitry Goncharov via Bug reports and discussion for GNU make wrote: > Multiple tests fail when locale related env variables (such as LANG or > LC_MESSAGES) are set to some regional setting. This should not be necessary because we already do this, in test_driver.p

Re: patch out of source builds

On Sat, Sep 14, 2019 at 10:19:56AM +0300, Eli Zaretskii wrote: > > This patch makes the test suite look for config.status in the -make_path > > directory to allow testing out of source builds. > > Thanks, but I don't think relying on config_status is good enough, > because some builds don't have i

Re: patch out of source builds

> Date: Fri, 13 Sep 2019 21:40:49 -0400 > From: Dmitry Goncharov via Bug reports and discussion for GNU make > > > This patch makes the test suite look for config.status in the -make_path > directory to allow testing out of source builds. Thanks, but I don't think relying on config_status is g