Re: GNU make 4.2.90 release candidate available

2019-08-26 Thread Dennis Clarke
On 8/26/19 10:59 PM, Paul Smith wrote: On Mon, 2019-08-26 at 19:33 -0400, Dennis Clarke wrote: I'll dig into this but on RHEL 7.4 x86_64 we see : src/job.c: In function 'reap_children': src/job.c:754:17: error: incompatible type for argument 1 of 'wait' EINTRLOOP (pid, wait (

Re: GNU make 4.2.90 release candidate available

2019-08-26 Thread Paul Smith
On Mon, 2019-08-26 at 19:33 -0400, Dennis Clarke wrote: > I'll dig into this but on RHEL 7.4 x86_64 we see : > > src/job.c: In function 'reap_children': > src/job.c:754:17: error: incompatible type for argument 1 of 'wait' > EINTRLOOP (pid, wait (&status)); That is REALLY distur

Re: GNU make 4.2.90 release candidate available

2019-08-26 Thread Dennis Clarke
On 8/26/19 9:00 AM, Paul Smith wrote: GNU make is a tool which controls the generation of executables and other non-source files of a program from the program's source files. You can learn more at: https://w

Re: GNU make 4.2.90 rc passes testsuite no where except Linux x86_64 thus far

2019-08-26 Thread Dennis Clarke
On 8/26/19 5:51 PM, Paul Smith wrote: On Mon, 2019-08-26 at 17:42 -0400, Dennis Clarke wrote: Well I am getting consistent results here on a number of systems across various OS and platform architectures. A few of them fail in the test functions/wildcard and I see : This one (the __ldir test)

Re: GNU make 4.2.90 rc passes testsuite no where except Linux x86_64 thus far

2019-08-26 Thread Paul Smith
On Mon, 2019-08-26 at 17:42 -0400, Dennis Clarke wrote: > Well I am getting consistent results here on a number of systems > across various OS and platform architectures. A few of them fail in > the test functions/wildcard and I see : This one (the __ldir test) is exactly the one I was referring

Re: GNU make 4.2.90 rc passes testsuite no where except Linux x86_64 thus far

2019-08-26 Thread Dennis Clarke
On 8/26/19 4:32 PM, Paul Smith wrote: On Mon, 2019-08-26 at 16:19 -0400, Dennis Clarke wrote: Testing on a few system and seems to fail the testsuite in various ways on multiple systems. Does not compile on FreeBSD 12.0-RELEASE- p10 amd64 with LLVM/Clang thus : Thanks Dennis. Please note that

Re: GNU make 4.2.90 rc passes testsuite no where except Linux x86_64 thus far

2019-08-26 Thread Paul Smith
On Mon, 2019-08-26 at 16:19 -0400, Dennis Clarke wrote: > Testing on a few system and seems to fail the testsuite in various > ways on multiple systems. Does not compile on FreeBSD 12.0-RELEASE- > p10 amd64 with LLVM/Clang thus : Thanks Dennis. Please note that glob/fnmatch/getopt are not technic

GNU make 4.2.90 rc passes testsuite no where except Linux x86_64 thus far

2019-08-26 Thread Dennis Clarke
On 8/26/19 9:00 AM, Paul Smith wrote: GNU make is a tool which controls the generation of executables and other non-source files of a program from the program's source files. You can learn more at: https://w

Re: Requiring Automake 1.16.1 due to Gnulib getloadavg?

2019-08-26 Thread Paul Eggert
Paul Smith wrote: It appears that the target that's failing for me, that you didn't try in your test, is "make distclean". Thanks, that explains it. Yes, "make distclean" fails for me too. I don't see a trivial fix so I guess I'll let this sleeping dog lie too. Sorry about the noise. As fa

Re: GNU make 4.2.90 release candidate available

2019-08-26 Thread Paul Smith
On Mon, 2019-08-26 at 15:31 -0400, Paul Smith wrote: > On Mon, 2019-08-26 at 11:57 -0700, David Boyce wrote: > > > I guess this is confusing ... > > > > There may be confusion in the text between "the number of jobs > > running" and "the number of jobs running *on a core*". > > Well, there can on

Re: GNU make 4.2.90 release candidate available

2019-08-26 Thread Paul Smith
On Mon, 2019-08-26 at 11:57 -0700, David Boyce wrote: > > I guess this is confusing ... > > There may be confusion in the text between "the number of jobs > running" and "the number of jobs running *on a core*". Well, there can only ever be one job running on core (at a time), by definition; I do

Re: GNU make 4.2.90 release candidate available

2019-08-26 Thread David Boyce
> I guess this is confusing ... There may be confusion in the text between "the number of jobs running" and "the number of jobs running *on a core*". > If you use -lN -j, make can kick off enough jobs to kill your system before the load average can change enough to throttle it. Understood. > I'

[bug #56701] Do not allow -j without a number

2019-08-26 Thread Dennis Clarke
Follow-up Comment #5, bug #56701 (project make): Well gnulib is not what I call portable. So if the sysconf/getconf calls are not around to give us _NPROCESSORS_ONLN or even _NPROCESSORS_CONF then no way should some hack attempt be made to extract that data. No promise the data is available at all

Re: GNU make 4.2.90 release candidate available

2019-08-26 Thread Paul Smith
On Mon, 2019-08-26 at 10:26 -0700, David Boyce wrote: > > the -l/--load-average option will use the contents of that file to > determine how many jobs are running at any given instant, and compare > that value to the load value requested. > > Compare and do what? This doesn't make sense to me. I

Re: [bug #56701] Do not allow -j without a number

2019-08-26 Thread Dennis Clarke
On 8/26/19 1:46 PM, Dennis Clarke wrote: On 8/26/19 1:32 PM, David Boyce wrote: My vote is to leave -j alone. Everyone knows it shouldn't be used that way in production... Please allow me to follow up here and agree. Common sense should prevail and in the true sense of UNIX and Linux philosoph

Re: [bug #56701] Do not allow -j without a number

2019-08-26 Thread Dennis Clarke
On 8/26/19 1:32 PM, David Boyce wrote: My vote is to leave -j alone. Everyone knows it shouldn't be used that way in production... Please allow me to follow up here and agree. Common sense should prevail and in the true sense of UNIX and Linux philosophy a tool does one thing and does that one

Re: [bug #56701] Do not allow -j without a number

2019-08-26 Thread Paul Smith
On Mon, 2019-08-26 at 10:32 -0700, David Boyce wrote: > My vote is to leave -j alone. Everyone knows it shouldn't be used > that way in production, especially on shared host, but I've been > known to use -j alone when testing out the parallel-safety of a > makefile or in various other ad-hoc test s

Re: [bug #56701] Do not allow -j without a number

2019-08-26 Thread David Boyce
My vote is to leave -j alone. Everyone knows it shouldn't be used that way in production, especially on shared host, but I've been known to use -j alone when testing out the parallel-safety of a makefile or in various other ad-hoc test scenarios. I could even imagine it being used deliberately as a

Re: Requiring Automake 1.16.1 due to Gnulib getloadavg?

2019-08-26 Thread Paul Smith
On Mon, 2019-08-26 at 08:26 -0700, Paul Eggert wrote: > Paul Smith wrote: > > > * Replace local portability code with Gnulib content. Unfortunately due to > > a > >problem with Gnulib support for getloadavg, this forces a requirement on > >Automake 1.16 or above in order to build from Gi

Re: GNU make 4.2.90 release candidate available

2019-08-26 Thread David Boyce
Feedback on release notes - there are a couple of things unclear at least to me: > the -l/--load-average option will use the contents of that file to determine how many jobs are running at any given instant, and compare that value to the load value requested. Compare and do what? This doesn't mak

Re: GNU make 4.2.90 release candidate available

2019-08-26 Thread Paul Smith
On Mon, 2019-08-26 at 19:26 +0300, Eli Zaretskii wrote: > > From: Paul Smith > > Date: Mon, 26 Aug 2019 09:00:13 -0400 > > > > A new release candidate for GNU make 4.3 is available now for > > download: > > > > 36083ab822b50a9ecbf5467cdadff55c make-4.2.90.tar.bz2 > > e2c9abdeaf3725f86

Re: GNU make 4.2.90 release candidate available

2019-08-26 Thread Eli Zaretskii
> From: Paul Smith > Date: Mon, 26 Aug 2019 09:00:13 -0400 > > A new release candidate for GNU make 4.3 is available now for download: > > 36083ab822b50a9ecbf5467cdadff55c make-4.2.90.tar.bz2 > e2c9abdeaf3725f8654a5e9d7a121fa9 make-4.2.90.tar.gz > > You can obtain a copy from: https:

Requiring Automake 1.16.1 due to Gnulib getloadavg?

2019-08-26 Thread Paul Eggert
Paul Smith wrote: * Replace local portability code with Gnulib content. Unfortunately due to a problem with Gnulib support for getloadavg, this forces a requirement on Automake 1.16 or above in order to build from Git. See README.git. bootstrap.conf and configure.ac say "1.16.1" so pre

[bug #56701] Do not allow -j without a number

2019-08-26 Thread Dmitry V. Levin
Follow-up Comment #4, bug #56701 (project make): FWIW, nproc(1) is part of GNU coreutils, it is based on nproc module from gnulib, so the way it works is probably as much portable as one can get. If GNU make was using gnulib directly, it would cost just a single invocation of num_processors.

[bug #56701] Do not allow -j without a number

2019-08-26 Thread Paul D. Smith
Follow-up Comment #3, bug #56701 (project make): First, "$(nproc)" is not easy to obtain in a portable manner; this has been asked many times before. Second, I'm not sure if using -l $(nproc) is the right way to handle this. It's still a change in behavior, just one that's more obscure. Let's s

Re: [bug #56701] Do not allow -j without a number

2019-08-26 Thread Howard Chu via Bug-make
Personally I would have closed this as Not a Bug since it has been clearly documented for 30+ years. Users are responsible for reading the docs and learning how their tools work. Dmitry V. Levin wrote: > Follow-up Comment #2, bug #56701 (project make): > > Let's try to fix this issue and avoid in

[bug #56749] Any chance to make new release?

2019-08-26 Thread Paul D. Smith
Update of bug #56749 (project make): Open/Closed:Open => Closed ___ Follow-up Comment #3: A new release candidate has been published. _

GNU make 4.2.90 release candidate available

2019-08-26 Thread Paul Smith
GNU make is a tool which controls the generation of executables and other non-source files of a program from the program's source files. You can learn more at: https://www.gnu.org/software/make/ --

[bug #56701] Do not allow -j without a number

2019-08-26 Thread Dmitry V. Levin
Follow-up Comment #2, bug #56701 (project make): Let's try to fix this issue and avoid introducing any regressions. For example, if -j is given without an argument and no -l option is provided, behave as if -j -l $(nproc) was specified. ___

[bug #56701] Do not allow -j without a number

2019-08-26 Thread Paul D. Smith
Update of bug #56701 (project make): Item Group: Bug => Enhancement ___ Follow-up Comment #1: Actually -j without a number is useful: it's used in conjunction with the -l option to allow parall

[bug #56449] job.c (construct_command_argv_internal): Must use shell if '%' character is present in recipe line

2019-08-26 Thread Paul D. Smith
Update of bug #56449 (project make): Status:None => Fixed Open/Closed:Open => Closed ___ Follow-up Comment #1: Thanks for the bug rep