Re: Regression caused by Commit: 5bd7ad2b225b ("Preserve the real value of -jN in MAKEFLAGS using jobserver.")

2017-10-31 Thread NeilBrown
On Tue, Oct 31 2017, Paul Smith wrote: > On Thu, 2017-09-28 at 20:41 +1000, NeilBrown wrote: >> I dug into this a bit. >> The regression is caused because the 'j' flag now causes >> arg_job_slots to be set, rather than setting job_slots directly. > > I pushed a fix for this. Thanks. Your fix app

Re: Regression caused by Commit: 5bd7ad2b225b ("Preserve the real value of -jN in MAKEFLAGS using jobserver.")

2017-10-31 Thread Eric Melski
On 10/30/2017 02:22 PM, Paul Smith wrote: On Tue, 2017-10-31 at 07:39 +1100, NeilBrown wrote: On Mon, Oct 30 2017, Tim Murphy wrote: For my money -j is always a top-level setting. To have it per makefile and then let makefiles depend on that behaviour would open the door to lots of scary bug

RE: Regression caused by Commit: 5bd7ad2b225b ("Preserve the real value of -jN in MAKEFLAGS using jobserver.")

2017-10-31 Thread Gardell, Steven
Our experience is that it is really only sensible as a top-level control. That said, it is convenient to have as an argument to make - which of course opens one up to seeing it specified on explicit sub-make invocations. I would also note that we have found that the performance behavior (this is