RE: [PATCH] Refactor and merge child_execute_job() code, new attempt

2014-03-10 Thread Pavel Fedin
Hello! > I like this patch; it looks like a good improvement! It works fine for > me on UNIX systems. > > Only one comment: > > > - /* undo CLOSE_ON_EXEC() after the child process has been started */ > > + /* undo FD_CLOEXEC after the child process has been started */ > > I think th

Test harness on VMS, running 512 tests, 68 tests failing.

2014-03-10 Thread John E. Malmberg
It has taken a few passes at finding all the issues. Originally I found that test scripts were being aborted on the first test failure, so I did not have the full count of tests. Then I had to fix the command options to be quoted to preserve the case, and filter the output for the intentional

Re: vms argv[0] and exit status fixes.

2014-03-10 Thread John E. Malmberg
On 3/10/2014 2:35 PM, h.becker wrote: On 03/08/2014 02:47 PM, John E. Malmberg wrote: Since there will only be one build procedure and one resulting binary, there would not be two templates. One of the main reasons for merging this fork back in is to get to one make binary. It's not yet deter

Re: vms argv[0] and exit status fixes.

2014-03-10 Thread h.becker
On 03/08/2014 02:47 PM, John E. Malmberg wrote: > Since there will only be one build procedure and one resulting binary, > there would not be two templates. > > One of the main reasons for merging this fork back in is to get to one > make binary. > > The one binary where needed will check if it i

make 4.0 + cdrtools

2014-03-10 Thread Sergei
Hello. When I use make 3.82 to compile cdrtools 3.01a23 compilation process completes sucessfully. But when make 4.0 is being used I get the following: ... make[2]: Leaving directory '/home/work/cdrtools/src/cdrtools-3.01/libsiconv' make[1]: Leaving directory '/home/work/cdrtools/src/cdrtools-3.01