RE: [PATCH] Refactor and merge child_execute_job() code

2014-01-30 Thread Pavel Fedin
Hello! > This will break the native Windows build, so please don't. (See job.h > for how this macro is defined on Windows.) And even if the places > where you made those expansions are not compiled on Windows, having a > macro in some places and its expansion in others is confusing. Ok, i act

Re: [PATCH] Refactor and merge child_execute_job() code

2014-01-30 Thread Eli Zaretskii
> From: Paul Smith > Cc: Pavel Fedin , bug-make@gnu.org > Date: Thu, 30 Jan 2014 12:33:41 -0500 > > On Thu, 2014-01-30 at 19:29 +0200, Eli Zaretskii wrote: > > I will review the patch some more in a day or two. (And I hope Paul > > will as well.) > > Yes, definitely, but it won't be until the w

Re: [PATCH] Refactor and merge child_execute_job() code

2014-01-30 Thread Paul Smith
On Thu, 2014-01-30 at 19:29 +0200, Eli Zaretskii wrote: > I will review the patch some more in a day or two. (And I hope Paul > will as well.) Yes, definitely, but it won't be until the weekend I expect. Life is intruding on hacking this month. ___ B

Re: [PATCH] Refactor and merge child_execute_job() code

2014-01-30 Thread Eli Zaretskii
> Date: Thu, 30 Jan 2014 01:16:34 +0400 > From: Pavel Fedin > > Hello! This is my long-promised refactor. After this it's much easier > to apply runtime selection between spawn() and fork() on Cygwin, > because all differences are now consolidated in two functions: > child_execute