[PATCH] Fix output-sync option on EMX - updated

2014-01-14 Thread Pavel Fedin
Hello! > Thanks, but does EMX support output-sync? If not, this fragment: > > + /* Divert child output if output_sync in use. */ > + if (child->output.syncout) > +{ > + if (child->output.out >= 0) > +outfd = child->output.out; > + if

Re: [PATCH] Fix output-sync option on EMX

2014-01-14 Thread Pavel Fedin
Hello, Eli. Tuesday, January 14, 2014, 22:50:28 you wrote: > The part you replaced with "..." sounds like an important qualifier to > me. > I also have hard time believing that these 4 lines is all it takes to > support output-sync on EMX. If you remember my original spawn-patch, all it do

Re: make doesn't complain if target cannot be built

2014-01-14 Thread Christian Eggers
Am Dienstag, 14. Januar 2014, 08:12:38 schrieb Paul Smith: > Can you add the prerequisite to the pattern rules? > > %.o : %.c generated.h > $(COMPILE.c) ... > %.o : %.cpp generated.h > $(COMPILE.cpp) ... > > This has the definite potential downside that if "generated.h" ch

Re: [PATCH] Fix output-sync option on EMX

2014-01-14 Thread Eli Zaretskii
> From: David Boyce > Date: Tue, 14 Jan 2014 13:13:13 -0500 > Cc: Pavel Fedin , bug-make > > On Tue, Jan 14, 2014 at 12:41 PM, Eli Zaretskii wrote: > > Thanks, but does EMX support output-sync? > > Didn't he just say "The purpose of this piece is to add missing > support for output-sync option

Re: [PATCH] Fix output-sync option on EMX

2014-01-14 Thread David Boyce
On Tue, Jan 14, 2014 at 12:41 PM, Eli Zaretskii wrote: > Thanks, but does EMX support output-sync? Didn't he just say "The purpose of this piece is to add missing support for output-sync option to [...] EMX"? David ___ Bug-make mailing list Bug-make@g

Re: [PATCH] Fix output-sync option on EMX

2014-01-14 Thread Eli Zaretskii
> From: Pavel Fedin > Date: Tue, 14 Jan 2014 11:11:35 +0400 > > This is part of my spawn-patch for Make. The purpose of this piece is to > add missing support for output-sync option to spawn()-based flavors > (currently only EMX). Thanks, but does EMX support output-sync? If not, this fragment

Re: [bug #40639] GNU Make with profiling information

2014-01-14 Thread Eddy Petrișor
2014/1/14 Tim Murphy > > To some, using a spreadsheet might not seem like the most worthwhile > way to visualise timing information. That's why I thought it can be useful to provide the information in various formats. I found useful the graphs provided via a graph from data in spreadsheet, you

Re: RE: win32 compilation of make 4.0 source code‏

2014-01-14 Thread Eli Zaretskii
> From: Pavel Fedin > Date: Tue, 14 Jan 2014 11:53:15 +0400 > Cc: bug-make@gnu.org > Obviously, you are trying to execute Makefile written for UNIX systems, are > you ? This makefile relies on UNIX shell commands like uname, pwd, basename, > etc. Right ? > In order to run this Makefile, you ne

Re: Re: win32 compilation of make 4.0 source code‏

2014-01-14 Thread Eli Zaretskii
> From: "Mark Brown" > Cc: , > > Date: Mon, 13 Jan 2014 22:56:10 -0800 > > I showed some of the output when this new windows/dos make is run > from the command prompt, in the original message. Sorry, I thought that was from the Cygwin shell, since you asked whether this Make is supposed t

Re: [bug #40639] GNU Make with profiling information

2014-01-14 Thread Tim Murphy
I forgot to say that start times don't need to be absolute times - only relative to the start of the top level gmake if possible. That creates a problem for submakes I suppose. I would guess that one could put the absolute build start time in an environment variable like MAKE_START_TIME and then

Re: [bug #40639] GNU Make with profiling information

2014-01-14 Thread Tim Murphy
To some, using a spreadsheet might not seem like the most worthwhile way to visualise timing information. If it was me, I'd be far more concerned about whether I could write a script that could easily cope with all this information. Builds with hundreds of thousands of targets were common for me

Re: [bug #40639] GNU Make with profiling information

2014-01-14 Thread Eddy Petrișor
2014/1/12 Paul Smith : > On Wed, 2013-12-18 at 13:28 +0200, Eddy Petrișor wrote: >> Could you please confirm if the general direction of the the is OK in >> the latest patch I sent? > > Conceptually it seems OK. I'm still not jazzed about having any more > than one output format, and I'd prefer th

Re: make doesn't complain if target cannot be built

2014-01-14 Thread Paul Smith
On Tue, 2014-01-14 at 06:56 +0100, Christian Eggers wrote: > Am Montag, 13. Januar 2014, 17:20:43 schrieb Paul Smith: > > On Mon, 2014-01-13 at 22:23 +0100, Christian Eggers wrote: > > > In Makefile 2 my intention was to state that foo.o depends on some > > > generated header which must be generate

Re: [bug #40639] GNU Make with profiling information

2014-01-14 Thread Paul Smith
On Tue, 2014-01-14 at 11:58 +0200, Eddy Petrișor wrote: > > I understand the interest in the amount of time a given job takes to > > run, but I guess I don't understand the need for a "start time > offset" > > at all. Isn't it sufficient to record the start time of a job, then > > when it's comple

Re: make doesn't complain if target cannot be built

2014-01-14 Thread Christian Eggers
-Philip Guenther schrieb: - >Betreff: Re: make doesn't complain if target cannot be built > In many cases, I've found it completely unnecessary to > list the source files. Just list the objects that should be built and > provide pattern rules for the source types, then let make figure ou

Re: Missing po files in GIT

2014-01-14 Thread Paul Smith
On Tue, 2014-01-14 at 11:00 +0400, Pavel Fedin wrote: > Hello! > > I am trying to rebuild GIT version of Make, however .po files are missing > in the repository. Is this intentional ? I have copied them over from my > 4.0-2 archive. But where are they originally stored ? The PO files are dynami

Re: [bug #40639] GNU Make with profiling information

2014-01-14 Thread Eddy Petrișor
Pe 11.01.2014 20:58, "Paul Smith" a scris: > > Sorry, I've been mostly away from my systems recently. > > > On Wed, 2013-12-18 at 13:28 +0200, Eddy Petrișor wrote: > > > Thanks for clarifying this. Could you please confirm if the general > > direction of the the is OK in the latest patch I sent? >