Re: [bug #39943] Add an alternative parsing mode that regards space and tab as identical tokens

2013-09-05 Thread Reinier Post
On Thu Sep 5 08:18:51 2013, psm...@gnu.org (Paul Smith) wrote: > On Thu, 2013-09-05 at 11:43 +0100, Tim Murphy wrote: > > The detection also appears to only work if the statement has a syntax > > error in it. > > Correct. If make can understand what the line is (it's a valid makefile > syntax),

Fwd: [bug #39943] Add an alternative parsing mode that regards space and tab as identical tokens

2013-09-05 Thread Tim Murphy
forgot to cc the list - oops. -- Forwarded message -- From: Tim Murphy Date: 5 September 2013 14:30 Subject: Re: [bug #39943] Add an alternative parsing mode that regards space and tab as identical tokens To: "Paul D. Smith" warning and finally enforcement of something. > > W

Re: [bug #39943] Add an alternative parsing mode that regards space and tab as identical tokens

2013-09-05 Thread Paul Smith
On Thu, 2013-09-05 at 11:43 +0100, Tim Murphy wrote: > The detection also appears to only work if the statement has a syntax > error in it. Correct. If make can understand what the line is (it's a valid makefile syntax), then why would it assume that the programmer may have meant something differ

Re: [bug #39943] Add an alternative parsing mode that regards space and tab as identical tokens

2013-09-05 Thread Tim Murphy
The detection also appears to only work if the statement has a syntax error in it. e.g. fred: X=25;echo$$X With 8 spaces the above is not warned about even though to the human eye when you use vim's search function to highlight spaces it becomes visually highly suspicious. 1) it's immed

Re: [bug #39943] Add an alternative parsing mode that regards space and tab as identical tokens

2013-09-05 Thread Tim Murphy
ah, interesting - good point. My standard (at least the enforced standard where I work) is 4-spaces and it doesn't catch that. On 5 September 2013 10:44, Eli Zaretskii wrote: >> Date: Thu, 5 Sep 2013 10:38:16 +0100 >> From: Tim Murphy >> Cc: Byron Hawkins , >> Boris Kolpackov , bug-make

Re: [bug #39943] Add an alternative parsing mode that regards space and tab as identical tokens

2013-09-05 Thread Eli Zaretskii
> Date: Thu, 5 Sep 2013 10:38:16 +0100 > From: Tim Murphy > Cc: Byron Hawkins , > Boris Kolpackov , bug-make > > It would be nice even if make was able to guess what might be > happening and issue a warning It already does: /usr/tmp/Gma07464:2: *** missing separator (did you mean TAB i

Re: [bug #39943] Add an alternative parsing mode that regards space and tab as identical tokens

2013-09-05 Thread Tim Murphy
spaces-for-tabs bugs are pretty common and very annoying though. If it's not your editor then it's some stupid website or wiki page that one puts example makefiles into. Or one types the example but theres no way to insert a tab since it takes you to the next field. Then people cut and past the