RE: [PATCH 2/2] Do not use DOS paths on Cygwin

2013-08-06 Thread Pavel Fedin
Hello! > This is what I'd expect. Good then. > > 2. PATH_SEPARATOR on Cygwin is ':' and on pure DOS/Windows is ';'. > > This is true, but how is this relevant to the issue at hand? > 'abspath' does not deal with PATH-style directory lists, it accepts a > single file name as its argument. Wha

[bug #39709] a few typos fixes

2013-08-06 Thread Martin Dorey
Follow-up Comment #1, bug #39709 (project make): The patch looks good to me and I'm a picky native speaker. My one not-really quibble was why not also fix the "pattrn" targets in tests/scripts/features/patspecific_vars. I'm not seeing the reason why "pattern" has to be avoided, but it's unfamili

[bug #39709] a few typos fixes

2013-08-06 Thread anonymous
URL: Summary: a few typos fixes Project: make Submitted by: None Submitted on: Tue 06 Aug 2013 08:55:48 PM UTC Severity: 3 - Normal Item Group: Enhancement

Re: [PATCH] Use spawn() in GNU Make on Cygwin, updated

2013-08-06 Thread Eli Zaretskii
> From: Pavel Fedin > Cc: bug-make@gnu.org > Date: Tue, 06 Aug 2013 10:46:51 +0400 > > Runtime ??? I am sorry, but what's the sense ? I tried to explain that in my first response: 'fork' has a certain semantics and implements requirements that 'spawn' does not. Since Cygwin is a Posix environm

Re: [PATCH 2/2] Do not use DOS paths on Cygwin

2013-08-06 Thread Eli Zaretskii
> From: Pavel Fedin > Cc: m...@cgf.cx, bug-make@gnu.org > Date: Tue, 06 Aug 2013 17:46:14 +0400 > > 1. abspath on Cygwin returns UNIX-style paths and on pure DOS/Windows - > DOS-style. This is what I'd expect. > If DOS-style absolute path is already supplied, it will leave it as > is. Again, t

Re: [PATCH 2/2] Do not use DOS paths on Cygwin

2013-08-06 Thread Eli Zaretskii
> From: Pavel Fedin > Cc: m...@cgf.cx, bug-make@gnu.org > Date: Tue, 06 Aug 2013 15:05:51 +0400 > > > In that case, we need to fix 'abspath', not disable this feature. > > Ok. If you don't mind, i can try new approach on this. Will it be OK ? Yes, please. _

RE: [PATCH 2/2] Do not use DOS paths on Cygwin

2013-08-06 Thread Pavel Fedin
Hello! > In that case, we need to fix 'abspath', not disable this feature. I have came up with another implementation, currently testing it. My new implementation should allow DOS and UNIX paths to coexist. However there's still two differences: 1. abspath on Cygwin returns UNIX-style paths a

RE: [PATCH 2/2] Do not use DOS paths on Cygwin

2013-08-06 Thread Pavel Fedin
Hello! > In that case, we need to fix 'abspath', not disable this feature. Ok. If you don't mind, i can try new approach on this. Will it be OK ? Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia ___ Bug-make mai