RE: [PATCH 2/2] Do not use DOS paths on Cygwin

2013-07-30 Thread Pavel Fedin
Hello! The problem is revealed by make's own test suite. The following is test results with DOS paths disabled: --- cut --- $ ./run_make_tests -- Running tests for GNU make on CYGWIN_NT-6.1 fedinw7x64 1.7.22(0.268/5/3)

RE: [PATCH1/2] Use spawn() on Cygwin

2013-07-30 Thread Pavel Fedin
Hello! > Can you at least tell when (year and month) this discussion took place? I was able to find only this in ML archive: http://cygwin.com/ml/cygwin/2013-01/msg00113.html The rest of discussion was held in private email. For some weird reason patch mails were rejected as spam by Cygwin ML,

RE: [PATCH1/2] Use spawn() on Cygwin

2013-07-30 Thread Pavel Fedin
Hello! Ø Using EMX is a shortcut to achieve the usage of spawn() over fork(). It might not be the cleanest choice but it works. Maybe Pavel finds the time to make the patch distinct to cygwin itself. What do you mean exactly by this ? Unfortunately i really don’t have much time to work on

Re: [PATCH1/2] Use spawn() on Cygwin

2013-07-30 Thread Eli Zaretskii
> Date: Wed, 31 Jul 2013 01:24:45 +0400 > From: Pavel Fedin > Cc: bug-make@gnu.org > > There was a short discussion in Cygwin ML with test results, sorry, i > cannot find the URL, Google fails to find it. Can you at least tell when (year and month) this discussion took place? In any case, I th

Re: [PATCH 2/2] Do not use DOS paths on Cygwin

2013-07-30 Thread Eli Zaretskii
> Date: Wed, 31 Jul 2013 01:31:56 +0400 > From: Pavel Fedin > Cc: bug-make@gnu.org > > The actual problem with this is that Make supports either DOS or POSIX > style paths, but not simultaneously. That's not true, at least that's not how things are designed to work. Please show a small self-con

Re: [PATCH 2/2] Do not use DOS paths on Cygwin

2013-07-30 Thread Pavel Fedin
Dear Eli Zaretskii! On Tue, 30 Jul 2013 18:43:10 +0300 you wrote: > Sorry, I don't understand the problem you are trying to solve. Could > you please explain it in more detail? The actual problem with this is that Make supports either DOS or POSIX style paths, but not simultaneously. I came

Re: [PATCH1/2] Use spawn() on Cygwin

2013-07-30 Thread Pavel Fedin
Dear Eli Zaretskii! On Tue, 30 Jul 2013 18:39:10 +0300 you wrote: > Is there any discussion we could read about that with the details of > the problem and how/why does the proposed patch solves it? The goal of this is exactly what is stated - improve performance. fork() is extremely slow opera

Re: [PATCH1/2] Use spawn() on Cygwin

2013-07-30 Thread Eli Zaretskii
> Date: Tue, 30 Jul 2013 11:52:58 -0500 > From: Norbert Thiebaud > Cc: Pavel Fedin , bug-make@gnu.org > > fork() is a very expensive operation in cygwin. Yes, I know. But without it, some things that are expected of a Posix behavior will not work. A notable example is that the child process in

Re: [PATCH1/2] Use spawn() on Cygwin

2013-07-30 Thread Norbert Thiebaud
On Tue, Jul 30, 2013 at 10:39 AM, Eli Zaretskii wrote: >> From: Pavel Fedin >> Date: Tue, 30 Jul 2013 14:42:23 +0400 >> >> Please take this patch, Cygwin team told that they would like to integrate >> with upstream. I have already posted it some time ago but got no reply. >> The patch significa

Re: [PATCH1/2] Use spawn() on Cygwin

2013-07-30 Thread Roland Schwingel
Hi... bug-make-bounces+roland.schwingel=onevision@gnu.org wrote on 30.07.2013 18:37:35: > On Tue, 2013-07-30 at 18:39 +0300, Eli Zaretskii wrote: > > In general, I feel it's wrong to do this: Cygwin is a Posix platform, > > so it should be using the Posix code, to be as compatible with other

Re: [PATCH 2/2] Do not use DOS paths on Cygwin

2013-07-30 Thread Eli Zaretskii
> Cc: bug-make@gnu.org, Pavel Fedin > From: Roland Schwingel > Date: Tue, 30 Jul 2013 18:29:07 +0200 > > I clearly think the DOS paths mode should remain in even for cygwin. I > know that there are objections in cygwins top level management against > this. When this feature was introduced for

Re: [PATCH1/2] Use spawn() on Cygwin

2013-07-30 Thread Roland Schwingel
Hi Eli... Eli Zaretskii wrote on 30.07.2013 18:29:53: > From: Eli Zaretskii > To: Roland Schwingel > Cc: bug-make@gnu.org, p.fe...@samsung.com > Date: 30.07.2013 18:32 > Subject: Re: [PATCH1/2] Use spawn() on Cygwin > > > Cc: bug-make@gnu.org, Pavel Fedin > > From: Roland Schwingel > > Date

Re: [PATCH1/2] Use spawn() on Cygwin

2013-07-30 Thread Paul Smith
On Tue, 2013-07-30 at 18:39 +0300, Eli Zaretskii wrote: > In general, I feel it's wrong to do this: Cygwin is a Posix platform, > so it should be using the Posix code, to be as compatible with other > Posix platforms as possible. EMX is not a Posix platform, so using > its code will likely make th

Re: [PATCH1/2] Use spawn() on Cygwin

2013-07-30 Thread Eli Zaretskii
> Cc: bug-make@gnu.org, Pavel Fedin > From: Roland Schwingel > Date: Tue, 30 Jul 2013 18:12:55 +0200 > > I am using Pavels patch for some months now in my private version of > gnumake on cygwin heavily and I could not find any regression with it up > to now and gnumake is in my use cases clear

Re: [PATCH 2/2] Do not use DOS paths on Cygwin

2013-07-30 Thread Roland Schwingel
Hi... bug-make-bounces+roland.schwingel=onevision@gnu.org wrote on 30.07.2013 17:43:10: > > Currently make's configure suggests that it should use DOS-style paths on > > Cygwin. This is not true, and this assumption makes path-related mechanisms > > to work incorrectly. Currently Cygwin p

Re: [PATCH1/2] Use spawn() on Cygwin

2013-07-30 Thread Roland Schwingel
Hi... bug-make-bounces+roland.schwingel=onevision@gnu.org wrote on 30.07.2013 17:39:10: > > From: Pavel Fedin > > Date: Tue, 30 Jul 2013 14:42:23 +0400 > > > > Please take this patch, Cygwin team told that they would like to integrate > > with upstream. I have already posted it some time

Re: [PATCH1/2] Use spawn() on Cygwin

2013-07-30 Thread Eli Zaretskii
> From: Pavel Fedin > Date: Tue, 30 Jul 2013 14:42:23 +0400 > > Please take this patch, Cygwin team told that they would like to integrate > with upstream. I have already posted it some time ago but got no reply. > The patch significantly improves performance of Make under Cygwin. Thanks. Is

Re: [PATCH 2/2] Do not use DOS paths on Cygwin

2013-07-30 Thread Eli Zaretskii
> From: Pavel Fedin > Date: Tue, 30 Jul 2013 14:44:58 +0400 > > Currently make's configure suggests that it should use DOS-style paths on > Cygwin. This is not true, and this assumption makes path-related mechanisms > to work incorrectly. Currently Cygwin package supplies manual hint in > config

[PATCH 2/2] Do not use DOS paths on Cygwin

2013-07-30 Thread Pavel Fedin
Currently make's configure suggests that it should use DOS-style paths on Cygwin. This is not true, and this assumption makes path-related mechanisms to work incorrectly. Currently Cygwin package supplies manual hint in config.cache in order to work around this. I think we should also ask MinGW t

[PATCH1/2] Use spawn() on Cygwin

2013-07-30 Thread Pavel Fedin
Hello! Please take this patch, Cygwin team told that they would like to integrate with upstream. I have already posted it some time ago but got no reply. The patch significantly improves performance of Make under Cygwin. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research ce