Re: [rfc] Colorized output for GNU make?

> Date: Thu, 05 Jan 2012 22:42:15 +0100 > From: Sebastian Pipping > CC: psm...@gnu.org, bug-make@gnu.org > > On 01/05/2012 09:46 PM, Eli Zaretskii wrote: > > The easiest way of abstracting this is to have a function that turns > > on a given color, and another function that turns off a color and

Re: [rfc] Colorized output for GNU make?

> From: Paul Smith > CC: Eli Zaretskii , bug-make@gnu.org > Date: Thu, 5 Jan 2012 17:32:50 -0500 > > On Thu, 2012-01-05 at 22:42 +0100, Sebastian Pipping wrote: > > On 01/05/2012 09:46 PM, Eli Zaretskii wrote: > > > The easiest way of abstracting this is to have a function that turns > > > on a g

Re: [rfc] Colorized output for GNU make?

Updates as requested: # git log --oneline | tac | tail -n 2 8e3918a Move output.(c|h) code to output_ascii.(c|h), make output.(c|h) a null layer 00d24e4 Reduce to single translated call to fprintf, extract functions (start|stop)_color http://hartwork.org/public/make-CVS-color-v5.pat

Re: [rfc] Colorized output for GNU make?

On Thu, 2012-01-05 at 22:35 +0100, Sebastian Pipping wrote: > Function vsnprintf could be used to fill variable "output". > Quoting the local printf(3) man page: Erhm. Forgot about that: neither vsprintf() nor vsnprintf() were included in the C89 standard. They were added in the C99 standard. A

Re: [rfc] Colorized output for GNU make?

On Thu, 2012-01-05 at 22:42 +0100, Sebastian Pipping wrote: > On 01/05/2012 09:46 PM, Eli Zaretskii wrote: > > The easiest way of abstracting this is to have a function that turns > > on a given color, and another function that turns off a color and > > returns to the default color. ("Color" can a

Re: [rfc] Colorized output for GNU make?

On 01/05/2012 09:46 PM, Eli Zaretskii wrote: > The easiest way of abstracting this is to have a function that turns > on a given color, and another function that turns off a color and > returns to the default color. ("Color" can actually be some other > attribute, like bold or blinking.) There sh

Re: [rfc] Colorized output for GNU make?

On 01/05/2012 09:20 PM, Paul Smith wrote: > What I mean is, instead of voutputf() invoking multiple calls to > fprintf(), we'd need to compute all the strings we needed then invoke a > single fprintf() for each output style where the format string was > translated, something like this: > >

[bug #35248] When running in debug-mode (-d), make reports a strange `multiple target patterns' error

Follow-up Comment #2, bug #35248 (project make): Yes, it certainly looks like make's own output is being parsed as a makefile... Line rules.mk:327 reads: $(SHARED_LIBRARY): $(OBJS) $(RES) $(MAPFILE) $(SUB_SHLOBJS) The project is Mozilla's NSS, BTW. Source downloaded from: http://ftp.mozilla.or

[bug #35248] When running in debug-mode (-d), make reports a strange `multiple target patterns' error

Follow-up Comment #1, bug #35248 (project make): It looks to me like somewhere in your makefiles you are invoking make and capturing its output and using that as part of the makefile so make is trying to parse it. When you run make with -d it not only prints its normal output that you expect, but

Re: [rfc] Colorized output for GNU make?

> From: Paul Smith > Date: Thu, 5 Jan 2012 15:20:07 -0500 > Cc: bug-make@gnu.org > > The other thing I wonder about is the hardcoding of ASCII colorized > strings and the start/stop character strings (\033[...). Are there > other methods of colorizing? Yes. > Should we try to support them? I

[bug #35248] When running in debug-mode (-d), make reports a strange `multiple target patterns' error

URL: Summary: When running in debug-mode (-d), make reports a strange `multiple target patterns' error Project: make Submitted by: kot Submitted on: Thu 05 Jan 2012 08:31:18 PM GMT Sev

Re: [rfc] Colorized output for GNU make?

On Thu, 2012-01-05 at 19:29 +0100, Sebastian Pipping wrote: > > I confess I'm not an expert in i18n, so it's quite possible I'm making > > something out of nothing very important here. But I think it's worth > > investigating. It's possible, for example, that it's sufficient to > > "translate" th

Re: [rfc] Colorized output for GNU make?

Hello again, I have integrated your review into a new version of the color patch. Version 4 is up at http://hartwork.org/public/make-CVS-color-v4.patch . There are the changes since the last version: # git log --oneline | tac | tail -n 5 b9aaec5 Revert addition of 2011 to copyright years

Re: [rfc] Colorized output for GNU make?

Hello, great to hear from you. On 01/04/2012 02:06 AM, Paul Smith wrote: > On Sun, 2012-01-01 at 01:31 +0100, Sebastian Pipping wrote: >>> I have to say that I feel that David's >>> point of 20 Oct is well-taken, that a more flexible command line >>> interface would be better. >> >> Alright. I p