[bug #106] make reports misleading line number in error message

2006-02-15 Thread Paul D. Smith
Update of bug #106 (project make): Status:None => Fixed Assigned to:None => psmith Open/Closed:Open => Closed Fixed Release:

[bug #106] make reports misleading line number in error message

2006-02-15 Thread Paul D. Smith
Follow-up Comment #6, bug #106 (project make): Don't worry about it. I think I have a handle on it. ___ Reply to this item at: ___

[bug #106] make reports misleading line number in error message

2006-02-15 Thread Jeff Evarts
Follow-up Comment #5, bug #106 (project make): Drat, you're right. Lemme have another look. ___ Reply to this item at: ___ Messag

[bug #106] make reports misleading line number in error message

2006-02-15 Thread Paul D. Smith
Follow-up Comment #4, bug #106 (project make): You are correct, Jeff: make does actually have enough information to generate a more correct error message. However, the patch you've applied is, I think, too generic. There are some situations while expanding where you DO want the line number in t

[bug #15757] circular variable_set_list causes hang on SunOS

2006-02-15 Thread Martin Dorey
Follow-up Comment #10, bug #15757 (project make): It's a long shot and Paul's method looks like a more constructive way of progressing but I just thought I'd mention bug #15534. There, make got confused by an apparent inode number collision, caused by only considering the bottom 32 bits of the 6

[bug #15584] 3.81 does way too much work in some pathalogical situations.

2006-02-15 Thread Boris Kolpackov
Update of bug #15584 (project make): Assigned to:bosk => None ___ Reply to this item at: ___

[bug #15757] circular variable_set_list causes hang on SunOS

2006-02-15 Thread Paul D. Smith
Follow-up Comment #9, bug #15757 (project make): Hrm. I rechecked the logic (which is somewhat unusual, by necessity) for the variable set list push/pop and it seems correct to me. That means that there may be somewhere else in the code that's resetting these variables. It's very odd that it i

[bug #15584] 3.81 does way too much work in some pathalogical situations.

2006-02-15 Thread Paul D. Smith
Update of bug #15584 (project make): Severity: 5 - Blocker => 2 - Minor Item Group: Bug => Enhancement Component Version:None => CVS Summary: 3.8

[bug #15584] 3.81.b4 much slower than 3.80 in some situations

2006-02-15 Thread Boris Kolpackov
Follow-up Comment #12, bug #15584 (project make): It appears that 3.80 has a bug in handling of .SECONDARY. It does not actually mark individual targets as intermedite. As a result, check_dep doesn't treat any target in this makefile as intermediate. In CVS the following code was added in file.c

[bug #15757] circular variable_set_list causes hang on SunOS

2006-02-15 Thread Ab Wilson
Follow-up Comment #6, bug #15757 (project make): Further to... The structure of these makefiles is such that make has a global view of everything, but if I type make with no arguments it will build all the targets and their prerequisites for the current directory (including those prerequisites f

[bug #15757] circular variable_set_list causes hang on SunOS

2006-02-15 Thread Paul D. Smith
Follow-up Comment #7, bug #15757 (project make): Thanks for the info. I need to look at it a bit. There are no fixed size anything in GNU make; everything is dynamic. Your guess is logical, but in fact there is an explanation that fits the facts better that doesn't rely on any resource issue:

[bug #15757] circular variable_set_list causes hang on SunOS

2006-02-15 Thread Ab Wilson
Follow-up Comment #8, bug #15757 (project make): I think you can rule out a heap management problem. I added a memset to xmalloc (so all newly allocated memory is explicitly zeroed) and I get the same behaviour. Regarding OS differences. Yes there are differences. The structure of the make syste

[bug #15757] circular variable_set_list causes hang on SunOS

2006-02-15 Thread Ab Wilson
Follow-up Comment #5, bug #15757 (project make): tower% pstack 16636 16636: /home/normanw/sparc-SunOS-5.8/bin/make --warn-undefined-variables ever 0004bea4 target_environment (8b5b90, 2, 1, 0, 2f736800, 85698) + 1b4 00032704 start_job_command (2bb8ed8, 0, , fff8, 0, 2bb8e09) + 664

[bug #15757] circular variable_set_list causes hang on SunOS

2006-02-15 Thread Paul D. Smith
Follow-up Comment #4, bug #15757 (project make): Yes, it's OK for global_setlist->next to be non-null in some situations. This is very helpful, but can you repeat the test and provide the same info you did in both examples (that is, backtrace, *file, trace the ->next pointers through to the loop

[bug #15757] circular variable_set_list causes hang on SunOS

2006-02-15 Thread Ab Wilson
Follow-up Comment #3, bug #15757 (project make): And another thing... (dbx) print global_setlist `make`variable.c`global_setlist = { `make`variable.c`global_setlist.next = 0x49fd08 `make`variable.c`global_setlist.set = 0x51b508 } (dbx) print &global_setlist &`make`variable.c`global_setli

[bug #15757] circular variable_set_list causes hang on SunOS

2006-02-15 Thread Ab Wilson
Follow-up Comment #2, bug #15757 (project make): Ok, this is a pstack of a stuck make process: tower% pstack -F 13172 13172: /home/normanw/sparc-SunOS-5.8/bin/make -k variants=dyn_dbg --warn-unde 0004be50 target_environment (91dd30, 2, 1, 0, 2f736800, 85670) + 178 00032704 start_job_command (

[bug #15757] circular variable_set_list causes hang on SunOS

2006-02-15 Thread Paul D. Smith
Follow-up Comment #1, bug #15757 (project make): This problem does not ring a bell with me, unfortunately. We're going to need your help to debug it. Can you provide a backtrace? Please make sure you build make with debugging enabled so that we get decent symbols etc. Is the argument to the f

Circular variable_set_lists

2006-02-15 Thread Norman Wilson
I'm using make-3.81beta4 on Solaris SunOS 5.9 compiled with Sun cc 5.5. I have a large non-recursive make system which builds around 250 directories of source code. I'm seeing make hang after building roughly half the source. Running up the debugger I see that it's actually going round in circles

[bug #15757] circular variable_set_list causes hang on SunOS

2006-02-15 Thread Ab Wilson
URL: Summary: circular variable_set_list causes hang on SunOS Project: make Submitted by: abwilson Submitted on: Wed 02/15/06 at 12:24 Severity: 3 - Normal