Thanks. I have applied everything but the libnetfs changes.
___
Bug-hurd mailing list
[EMAIL PROTECTED]
http://mail.gnu.org/mailman/listinfo/bug-hurd
Thanks for all the comments. I do appreciate them. I think I've almost
figured out how to do a changelog entry ;)
=
James Morrison
University of Waterloo
Computer Science - Digital Hardware
2A co-op
http://hurd.dyndns.org
Anyone refering this as 'Open Source' shall be eaten by
> @@ -1,5 +1,5 @@
> /* Run a program on the console, trying hard to get the console open.
> - Copyright (C) 1999, 2001 Free Software Foundation, Inc.
> + Copyright (C) 1999, 2001,02 Free Software Foundation, Inc.
In the future, you should use more consistent spacing.
> + if (err)
>
[EMAIL PROTECTED] (Thomas Bushnell, BSG) writes:
> James A Morrison <[EMAIL PROTECTED]> writes:
>
> > init:
> > * init.c (reboot_mach): Use err, not errno.
> > (run): Likewise.
> > (lauch_core_servers): Likewise.
> > (run_for_real): Check against MACH_PORT_NULL instead of not(!)
James Morrison <[EMAIL PROTECTED]> writes:
> Previously netfs_make_protid set errno, no matter what. So to keep this
> behaviour the patch would look like this.
There is no need to always set errno (though you should check all the
callers to make sure--which needed to be done first anyway).
A
--- "Thomas Bushnell, BSG" <[EMAIL PROTECTED]> wrote:
> James A Morrison <[EMAIL PROTECTED]> writes:
>
> > libnetfs:
> > * make-protid.c (netfs_make_protid): Use err, not errno.
>
> This one is incorrect; it changes the established interface of
> netfs_make_protid, which is that errno is se
James A Morrison <[EMAIL PROTECTED]> writes:
> init:
> * init.c (reboot_mach): Use err, not errno.
> (run): Likewise.
> (lauch_core_servers): Likewise.
> (run_for_real): Check against MACH_PORT_NULL instead of not(!) for
> failure.
> (start_child): Likewise.
James A Morrison <[EMAIL PROTECTED]> writes:
> libnetfs:
> * make-protid.c (netfs_make_protid): Use err, not errno.
This one is incorrect; it changes the established interface of
netfs_make_protid, which is that errno is set on error returns.
See, for example, libnetfs/fsys-getroot.c whic
You changed the interval in timertest from 1 to 4 without comment or change
log entry. I did not check that your log entries were exhaustive, please
double-check against your own patches when writing the log entries (that's
what I always do). Other than that, these changes look ok.
If Marcus
Hi,
Here is my patch that is overzealous in the use of error ;)
I didn't touch any code that was copyrighted UC Berkeley or CMU, nor did
I touch any code that didn't compile already.
This patch includes the previous patch because they are related.
I changed symlink so that it checks the n
10 matches
Mail list logo
