Re: new version of glibc xattr patch

2006-05-22 Thread Roland McGrath
> > I doubt this is true. If it is, it's a server-side bug. Note that > > S_IPTRANS and the gnu.translator xattr are found on nodes opened with > > O_NOTRANS. They will more or less never be seen by the file name-based > > calls, only by f*xattr on an fd opened using O_NOTRANS. > > I see. Th

Re: new version of glibc xattr patch

2006-02-24 Thread Michael Banck
On Mon, Feb 20, 2006 at 02:15:48PM -0800, Roland McGrath wrote: > > if (value != NULL && bufsz > *size) > > return ERANGE; > > *size = bufsz; > > That fix leaks in the ERANGE case. I did a different fix. > Please verify it. It works just as fine. > > Our tests seemed to hav

Re: new version of glibc xattr patch

2006-02-21 Thread Roland McGrath
Thanks for looking at this. I've committed the code on the glibc trunk now. If there are further problems please file a glibc bugzilla report in the "hurd" componenet. > When getxattr gets called with VALUE as NULL and *SIZE as 0 (to > determine the length of the xattr value), SIZE will be small

Re: new version of glibc xattr patch

2006-02-18 Thread Michael Banck
Hi, On Sun, Mar 06, 2005 at 03:58:38PM -0800, Roland McGrath wrote: > Not tested in the slightest. Ben Asselstine and I tested and debugged this now. With a couple of small changes, attr's getfattr/setfattr commands and star work fine for gnu.translator and gnu.author. > +error_t > +_hurd_xattr

Re: new version of glibc xattr patch

2005-03-10 Thread Barry deFreese
Ignore my last e-mail Roland. It appears that attr is using GNU/Linux syscalls instead of the glibc functions. I have re-built attr without syscalls.c and some of the functions are working so I need to do some more testing/investigation. Thanks, Barry (aka bddebian) ___

Re: new version of glibc xattr patch

2005-03-10 Thread Barry deFreese
- Original Message - From: "Roland McGrath" <[EMAIL PROTECTED]> To: Sent: Sunday, March 06, 2005 6:58 PM Subject: new version of glibc xattr patch This adds the missint {f,}{list,remove}xattr functions. Not tested in the slightest. OK, here are the results from the l

Re: new version of glibc xattr patch

2005-03-09 Thread Alfred M. Szmidt
Index: hurd/xattr.c === RCS file: hurd/xattr.c diff -N hurd/xattr.c --- /dev/null1 Jan 1970 00:00:00 - +++ hurd/xattr.c 6 Mar 2005 23:56:43 - ... +error_t +_hurd_xattr_list (io_t port, void *

Re: new version of glibc xattr patch

2005-03-09 Thread Barry deFreese
- Original Message - From: "Roland McGrath" <[EMAIL PROTECTED]> To: "Barry deFreese" <[EMAIL PROTECTED]> Cc: Sent: Wednesday, March 09, 2005 5:01 PM Subject: Re: new version of glibc xattr patch > > Please forgive my dumb ass. What should just be

Re: new version of glibc xattr patch

2005-03-09 Thread Roland McGrath
> Please forgive my dumb ass. What should just be zeros? s/size/0 in > fremovexattr.c ?? Yes. ___ Bug-hurd mailing list Bug-hurd@gnu.org http://lists.gnu.org/mailman/listinfo/bug-hurd

Re: new version of glibc xattr patch

2005-03-09 Thread Barry deFreese
- Original Message - From: "Roland McGrath" <[EMAIL PROTECTED]> To: "Barry deFreese" <[EMAIL PROTECTED]> Cc: Sent: Wednesday, March 09, 2005 4:20 PM Subject: Re: new version of glibc xattr patch > Those should just be 0s. Please forgive my dumb ass.

Re: new version of glibc xattr patch

2005-03-09 Thread Roland McGrath
Those should just be 0s. ___ Bug-hurd mailing list Bug-hurd@gnu.org http://lists.gnu.org/mailman/listinfo/bug-hurd

Re: new version of glibc xattr patch

2005-03-09 Thread Barry deFreese
- Original Message - From: "Roland McGrath" <[EMAIL PROTECTED]> To: Sent: Sunday, March 06, 2005 6:58 PM Subject: new version of glibc xattr patch This adds the missint {f,}{list,remove}xattr functions. Not tested in the slightest. OK, so I am trying to rebuild gli

new version of glibc xattr patch

2005-03-06 Thread Roland McGrath
This adds the missint {f,}{list,remove}xattr functions. Not tested in the slightest. 2005-03-06 Roland McGrath <[EMAIL PROTECTED]> * hurd/hurd/xattr.h: New file. * hurd/xattr.c: New file. * hurd/Makefile (routines): Add it. * sysdeps/mach/hurd/fgetxattr.c: New f