Re: memory leak in pflocal

2001-02-11 Thread Roland McGrath
> > You should be guaranteed that the queues are empty (length 0) by the > > time you get there (because anyone on the queue would hold a ref to the > > sock). But it wouldn't hurt to have an assert in connq_destroy. > > Wouldn't it be more logical to have that assertion in sock_free? It could

Re: memory leak in pflocal

2001-02-11 Thread Marcus Brinkmann
On Sat, Feb 10, 2001 at 08:31:21PM -0500, Roland McGrath wrote: > That looks correct to me, but you should do connect_queue as well. Oh, right. > You > should be guaranteed that the queues are empty (length 0) by the time you > get there (because anyone on the queue would hold a ref to the sock)

Re: memory leak in pflocal

2001-02-10 Thread Roland McGrath
That looks correct to me, but you should do connect_queue as well. You should be guaranteed that the queues are empty (length 0) by the time you get there (because anyone on the queue would hold a ref to the sock). But it wouldn't hurt to have an assert in connq_destroy. (cq->queue might still

memory leak in pflocal

2001-02-10 Thread Marcus Brinkmann
Hi, looks like a memory leak in pfinet, but I have not tried to find a test case or test the fix (I am currently very busy, sorry), so I am not checking it in right away. Listen queues (and the queue array they contain) are possibly created but nowhere destroyed. Thanks, Marcus diff -ru pfloca