Hi,
Thomas Schwinge skribis:
> As »make dist« in some places just considers the current configuration,
> it really is flawed. That's also the reason that you don't notice the
> missing files (but just do a diff of the tarball built by it and the
> source directory) -- th
r me when I remove that special lndist rule and let
> > the generic rules do their work. Why not for you?
>
> It works for me (and Hydra) because I’m building with srcdir = builddir.
>
> Does “make dist” otherwise work when srcdir != builddir?
Yes (modulo the other issues I
acted. Thus, either the tar that is doing the extraction is
>> confused, or the process that created hurd-20120404.tar.gz.
>
> I assume you have created that using »make dist«?
Yes!
> This one fails to include said files, and a lot of others.
Oh, you found a bug. :-)
> Plea
Hi!
As »make dist« in some places just considers the current configuration,
it really is flawed. That's also the reason that you don't notice the
missing files (but just do a diff of the tarball built by it and the
source directory) -- they're not used in your configuration (for e
ad of /some/where/include.
Sounds like an srcdir/builddir error.
> It works correctly for me when I remove that special lndist rule and let
> the generic rules do their work. Why not for you?
It works for me (and Hydra) because I’m building with srcdir = builddir.
Does “make dist” oth
t's going on? asm_syntax=i386 should be set, and
> > [hurd]/libthreads/i386/cthreads.h surely does exist.
>
> Well, it should. As the above log is showing, that file is not being
> extracted. Thus, either the tar that is doing the extraction is
> confused, or the process that cr
Hi!
On Sat, 17 Jul 2010 16:38:44 +0200, l...@gnu.org (Ludovic
=?iso-8859-1?Q?Court=E8s?=) wrote:
> From 50968edf6a4ee8af6ff63e2ee4a5b4d97013ff3d Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Ludovic=20Court=C3=A8s?=
> Date: Sat, 17 Jul 2010 15:59:25 +0200
> Subject: [PATCH 4/9] Fix &q
Diego Martin Nieto Cid, le Fri 31 Dec 2010 02:10:39 -0300, a écrit :
> * doc/Makefile (DIST_FILES): Remove target files.
> (lndist): Depend on lndist-info-targets
> (lndist-info-targets): New target. Distribute target files.
Applied, thanks.
Samuel
Diego Martin Nieto Cid, le Fri 31 Dec 2010 02:10:42 -0300, a écrit :
> * mach-defpager/Makefile (SRCS): Remove external sources
> default_pager.c, kalloc.c and wiring.c.
> (OBJS): Add objects for external sources. Corresponding
> source files will be found in vpath.
Replaced by Ludovic's patch.
S
Diego Martin Nieto Cid, le Fri 31 Dec 2010 02:10:40 -0300, a écrit :
> * fatfs/Makefile (DIST_FILES): Remove EXTENSIONS.
I actually made the change in the meanwhile :o)
Samuel
Hello!
I can confirm that ‘make dist’ works like a charm:
http://hydra.nixos.org/job/gnu/hurd-master/tarball
The latest tarball can be obtained from:
http://hydra.nixos.org/job/gnu/hurd-master/tarball/latest
Thanks,
Ludo’.
Hello,
Ludovic Courtès, le Sat 17 Jul 2010 20:21:55 +0200, a écrit :
> Comments?
Applied after update, thanks!
Samuel
(Sept. 2004), and moves the
> > files that are actually used by ‘mach-defpager’ in ‘mach-defpager/’.
> >
> > As a side effect, it fixes “make dist” in ‘mach-defpager’.
>
> Just friendly reminder that this patch is pending review.
Yep, it's still in my ever-increasing TODO list.
Samuel
pager’ in ‘mach-defpager/’.
>
> As a side effect, it fixes “make dist” in ‘mach-defpager’.
Just friendly reminder that this patch is pending review.
Ludo’.
Hi,
2011/1/6 Ludovic Courtès :
>
> Did you see this proposal?
>
Sorry, I missed it. I somehow thought all your patches were applied and I didn't
read that thread again before sending this. :(
Hello!
Diego Martin Nieto Cid writes:
> From: Diego Nieto Cid
>
> * mach-defpager/Makefile (SRCS): Remove external sources
> default_pager.c, kalloc.c and wiring.c.
> (OBJS): Add objects for external sources. Corresponding
> source files will be found in vpath.
Did you see this proposal?
ht
From: Diego Nieto Cid
* fatfs/Makefile (DIST_FILES): Remove EXTENSIONS.
Delete empty variable.
---
fatfs/Makefile |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/fatfs/Makefile b/fatfs/Makefile
index 7a24840..06ed877 100644
--- a/fatfs/Makefile
+++ b/fatfs/Makefile
@@ -2
From: Diego Nieto Cid
* mach-defpager/Makefile (SRCS): Remove external sources
default_pager.c, kalloc.c and wiring.c.
(OBJS): Add objects for external sources. Corresponding
source files will be found in vpath.
---
mach-defpager/Makefile |5 -
1 files changed, 4 insertions(+), 1 deletio
From: Diego Nieto Cid
* doc/Makefile (DIST_FILES): Remove target files.
(lndist): Depend on lndist-info-targets
(lndist-info-targets): New target. Distribute target files.
---
doc/Makefile | 10 --
1 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/doc/Makefile b/doc/Makefi
27;s lines must be written to.
2. pfinet needs to catch up with Roland McGrath's overhaul. :) Something
I really couldn't figure out how to do.
3. Unrelated to 'make dist'. The Makefile in doc subdir has the following
targets: hurd.info $(wildcard hurd.in
* Makefile.am (EXTRA_DIST): Remove ChangeLog.0, ChangeLog.00 and
Makefile.correct_output_files_for_.S_files.patch.
* Makefrag.am (libkernel_a_SOURCES): Add ipc/mach_port.h,
kern/ipc_mig.h, kern/machine.h, util/putchar.h, util/atoi.h,
vm/vm_resident.h, vm/vm_types.h and device/subrs.h.
Remove kern/t
Hi!
Samuel Thibault writes:
> Ludovic Courtès, le Sat 17 Jul 2010 16:44:08 +0200, a écrit :
>> This patch isn’t perfect in that stale ‘.o’ files or similar in the
>> ‘linux-src’ and ‘glue-include’ directories would end up in the tarball.
>> However, doing it the Right Way is somewhat tedious,
>
Ludovic Courtès, le Sat 17 Jul 2010 16:44:08 +0200, a écrit :
> This patch isn’t perfect in that stale ‘.o’ files or similar in the
> ‘linux-src’ and ‘glue-include’ directories would end up in the tarball.
> However, doing it the Right Way is somewhat tedious,
You mean, adding proper filenames in
Hello,
To fix make dist, instead of fixing serverboot, Ludovic proposes to just
at last drop it.
Thoughts?
Samuel
Ludovic Courtès, le Sat 17 Jul 2010 20:21:55 +0200, a écrit :
> This is the potentially controversial patch. :-)
>
> It removes serverboot, which is no longer built sin
From 50968edf6a4ee8af6ff63e2ee4a5b4d97013ff3d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ludovic=20Court=C3=A8s?=
Date: Sat, 17 Jul 2010 15:59:25 +0200
Subject: [PATCH 4/9] Fix "make dist" in `include'.
* include/Makefile (lndist): New target. Copy `Makefile' and
`$(
From a3a336d5fa94d1f856ffdc0e8c45b7db455578b2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ludovic=20Court=C3=A8s?=
Date: Sat, 17 Jul 2010 16:00:16 +0200
Subject: [PATCH 5/9] Fix "make dist" in `libcons'.
* libcons/Makefile (LCLHDRS): Add `$(installhdrs)'.
---
libcons/Makefile
From b02ceb3e85a9e98374d919a2d1995a7388926175 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ludovic=20Court=C3=A8s?=
Date: Sat, 17 Jul 2010 15:54:56 +0200
Subject: [PATCH 2/9] Fix "make dist" in `daemons'.
* daemons/Makefile (SRCS): Add `runsystem.sh'.
---
daemons/Makefile
From 8274c9e197f7d9edb44c0e22ab2cf7f1d83cbeff Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ludovic=20Court=C3=A8s?=
Date: Sat, 17 Jul 2010 16:01:52 +0200
Subject: [PATCH 6/9] Fix "make dist" in `libthreads'.
* libthreads/Makefile (lndist, lndist-map-file): New targets. Link
`lib
f0bcfbf475831c16a8416c3499c7bb21d660a6fa Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ludovic=20Court=C3=A8s?=
Date: Sat, 17 Jul 2010 16:12:33 +0200
Subject: [PATCH 8/9] Fix "make dist" in `pfinet'.
* pfinet/Makefile (lndist-linux-inet-files, lndist-linux-files,
lndist-asm-files, $(top_srcdir)/hurd-snap/$(
From 496924b22c4e896d50b5b45b533c92882399944a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ludovic=20Court=C3=A8s?=
Date: Sat, 17 Jul 2010 16:07:47 +0200
Subject: [PATCH 7/9] Fix "make dist" in `sutils'.
* sutils/Makefile (SRCS): Add `clookup.c', `fstab.c', and `update
From 55754cad6f51e753577d9d620fe40c4f958bf0de Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ludovic=20Court=C3=A8s?=
Date: Sat, 17 Jul 2010 15:57:42 +0200
Subject: [PATCH 3/9] Fix "make dist" in `exec'.
* exec/Makefile (SRCS): Refer to `$(gzip-sources)' and
`$(bzip2-sources)
Hello!
This is the first of a series of 9 patches that fix “make dist” in the
Hurd, and which have been used in continuous builds on Hydra [0]. Most
of them are trivial, and the last one may be slightly controversial.
The nice thing is that once “make dist” works, there’s little that
prevents
Hi Thomas,
Thomas Schwinge writes:
> Hello!
>
> On Fri, May 21, 2010 at 09:37:42AM +0200, Ludovic Courtès wrote:
>> ‘make dist’ in hurd/glibc.git (the right branch, whatever it’s called)
>> fails:
>>
>> --8<---cut here---start---
Hello!
On Fri, May 21, 2010 at 09:37:42AM +0200, Ludovic Courtès wrote:
> ‘make dist’ in hurd/glibc.git (the right branch, whatever it’s called)
> fails:
>
> --8<---cut here---start->8---
> fatal: No names found, cannot describe anything.
Hello,
‘make dist’ in hurd/glibc.git (the right branch, whatever it’s called)
fails:
--8<---cut here---start->8---
fatal: No names found, cannot describe anything.
make[1]: *** [dist] Error 1
--8<---cut here---end
er having installed the following:
#v+
2006-12-03 Thomas Schwinge <[EMAIL PROTECTED]>
[bug #18015 --- ``GNU Mach: `make dist' and friends'']
* Makefile.am (DISTCLEANFILES): New variable.
#v-
=>
_
akefile.orig config.status.orig'' to `Makefile.am', does
it work then?
This was positively confirmed by Barry -- Thanks for testing! -- so I'm
closing this bug after having installed the following:
#v+
2006-12-03 Thomas Schwinge <[EMAIL PROTECTED]>
[bug #18015 -
Thomas Schwinge wrote:
Follow-up Comment #5, bug #18015 (project hurd):
ERROR: files left in build directory after distclean:
./config.status.orig
./Makefile.orig
If you add ``DISTCLEANFILES = Makefile.orig config.status.orig'' to
`Makefile.am', does it work then?
Thomas,
Sure d
Follow-up Comment #5, bug #18015 (project hurd):
> ERROR: files left in build directory after distclean:
> ./config.status.orig
> ./Makefile.orig
If you add ``DISTCLEANFILES = Makefile.orig config.status.orig'' to
`Makefile.am', does it work then?
__
Follow-up Comment #4, bug #18015 (project hurd):
OK 'make distcheck' did not finish successfully:
rm -f Makefile
ERROR: files left in build directory after distclean:
./config.status.orig
./Makefile.orig
make[1]: *** [distcleancheck] Error 1
make[1]: Leaving directory
`/devel2/bdefreese/gnumach-
Follow-up Comment #3, bug #18015 (project hurd):
As usual I screwed up. It appears I was having a timestamp problem. "make
dist" works fine and a build on the resulting tarball is fine. I also tried
running 'make distcheck' which seemed to be working fine but my machine hu
Follow-up Comment #2, bug #18015 (project hurd):
Thomas,
Building out of the tree doesn't seem to work for me.
build/../configure works OK but make dist seems to just keep running aclocal,
autoconf, and automake recursively.
Thanks,
in the following to fix this issue. Please test.
Thanks to Barry for preparing a patch where I could base this work on.
#v+
2006-11-30 Barry deFreese <[EMAIL PROTECTED]>
Thomas Schwinge <[EMAIL PROTECTED]>
[bug #18015 --- ``GNU Mach: `make dist' and friends&#
That seems to be correct. I hope that doing so doesn't break anything.
(Thinking about the rules in `Makerules.am' that deal with those files.)
But you should have noticed if it had...
I decided to add the `.srv' and `.cli' files to `EXTRA_DIST' instead.
OK gang, I've gotten pre
Hello!
On Wed, Nov 29, 2006 at 12:30:13AM -0500, Barry deFreese wrote:
> Barry deFreese wrote:
> >Thomas Schwinge wrote:
> >>On Tue, Nov 28, 2006 at 12:13:20AM -0500, Barry deFreese wrote:
> >>>Barry deFreese wrote:
> >>>
> [...] I have added a few dist_libkernel_a_SOURCE to include all the
m`
+
#
# Compilation flags
#
@@ -81,6 +94,7 @@ CPP = @CPP@ -x c
noinst_LIBRARIES += \
libkernel.a
libkernel_a_SOURCES =
+dist_libkernel_a_SOURCES =
nodist_libkernel_a_SOURCES =
MOSTLYCLEANFILES += \
$(nodist_libkernel_a_SOURCES)
Index: Makefrag.am
===
Thomas Schwinge wrote:
Hello!
On Tue, Nov 28, 2006 at 12:13:20AM -0500, Barry deFreese wrote:
Barry deFreese wrote:
[...] I have added a few dist_libkernel_a_SOURCE to include all the
header files, .sym, .srv, and .cli files.
That seems to be correct. I hope that doing so doe
Hello!
On Tue, Nov 28, 2006 at 12:13:20AM -0500, Barry deFreese wrote:
> Barry deFreese wrote:
> >[...] I have added a few dist_libkernel_a_SOURCE to include all the
> >header files, .sym, .srv, and .cli files.
That seems to be correct. I hope that doing so doesn't break anything.
(Thinking abo
timal, but I didn't invent a better way so
far. It's also marked as `TODO' in there.
19:56 OK, I get make dist to run, then configure seems to
run clean finally on the extracted tarball. But now when running
make, I get:
19:56 ld# make
19:56 make all-recursive
19:56 ma
#x27;t invent a better way so
far. It's also marked as `TODO' in there.
19:56 OK, I get make dist to run, then configure seems to run clean
finally on the extracted tarball. But now when running make, I get:
19:56 ld# make
19:56 make all-recursive
19:56 make[1]: Entering directory
`
far. It's also marked as `TODO' in there.
19:56 OK, I get make dist to run, then configure seems to run clean
finally on the extracted tarball. But now when running make, I get:
19:56 ld# make
19:56 make all-recursive
19:56 make[1]: Entering directory
`/devel2/bdefreese/gnumach
URL:
<http://savannah.gnu.org/bugs/?18015>
Summary: GNU Mach: `make dist' and friends
Project: The GNU Hurd
Submitted by: tschwinge
Submitted on: Monday 10/16/06 at 00:13
Category: GNU Mach
52 matches
Mail list logo
