Re: gnumach: bug in dev_pager.c

2022-08-09 Thread Samuel Thibault
Joan Lledó, le mar. 09 août 2022 10:32:16 +0200, a ecrit: > Since it was a tiny patch I pushed the changes myself. Thanks! Samuel

Re: gnumach: bug in dev_pager.c

2022-08-09 Thread Joan Lledó
Since it was a tiny patch I pushed the changes myself. El 8/8/22 a les 2:16, Samuel Thibault ha escrit: It seems to me that the correct condition at lines 238 and 316 should be: if (!queue_end(bucket, &entry->links)) That should be it indeed!

Re: gnumach: bug in dev_pager.c

2022-08-07 Thread Samuel Thibault
Hello, Joan Lledó, le sam. 06 août 2022 12:44:38 +0200, a ecrit: > I'm surprised this is not crashing somehow. I tried to make > dev_pager_hash_delete() get called with a non-existent entry but I > don't know how to cause that situation. I don't think that's currently possible, since it's only ca

gnumach: bug in dev_pager.c

2022-08-06 Thread Joan Lledó
Hi, I think there's a bug in dev_pager.c, at methods dev_pager_hash_delete() and dev_device_hash_delete(), lines 238 and 316: https://git.savannah.gnu.org/cgit/hurd/gnumach.git/tree/device/dev_pager.c#n238 https://git.savannah.gnu.org/cgit/hurd/gnumach.git/tree/device/dev_pager.c#n316 It's ca