On Tue, Apr 02, 2002 at 10:22:21AM -0500, Neal H Walfield wrote:
> 2002-04-02 Neal H Walfield <[EMAIL PROTECTED]>
>
> * io-restrict-auth.c (diskfs_S_io_restrict_auth): When checking
> the result of a function, be sure to first save the result.
This part was rewritten by Roland in 0
> > Humm, again I followed the example in libdiskfs/io-restrict-auth.c
> > .
>
> This is the original:
>
> newpi = netfs_make_protid (user->po, new_user);
> if (newpi)
> {
> *newport = ports_get_right (newpi);
> mutex_unlock (&user->po->np->lock);
> *newporttype = MAC
> The original is correct. However, in libdiskfs/io-restrict-auth.c USER, which
> is equivalent to NEW_USER, is duplicated. Should the libnetfs implementation
> also duplicate NEW_USER so it can be free'd?
Thanks for catching this. The libdiskfs implementation looks wrong.
Here is a patch:
2
> > > Just a reminder, there are outstanding documentation patches for
> > hurd.texi.
> >
> > Could you write these?
> >
>
> Write what? I can write more documentation if you like ;)
I thought you meant outstanding as in need to update it for these
changes. Sorry.
> > > Index: ftpfs/fs.c
On Mon, Apr 01, 2002 at 09:12:12PM -0500, Neal H Walfield wrote:
> >
> > Just a reminder, there are outstanding documentation patches for hurd.texi.
>
> Could you write these?
He already did :) [there are patches for hurd.texi by him on the list]
Thanks,
Marcus
--
`Rhubarb is no Egyptian
--- Neal H Walfield <[EMAIL PROTECTED]> wrote:
> > Here is my patch to increase the error checking within libnetfs.
> > I've also included error.h in a couple of files that I noticed had compiler
> > warnings. There aren't any functions that return pointers to struct's
> > left in libnetfs.
>
> Here is my patch to increase the error checking within libnetfs.
> I've also included error.h in a couple of files that I noticed had compiler
> warnings. There aren't any functions that return pointers to struct's
> left in libnetfs.
There is one in libdiskfs (diskfs_make_node). Do you wan
Hi,
Here is my patch to increase the error checking within libnetfs.
I've also included error.h in a couple of files that I noticed had compiler
warnings. There aren't any functions that return pointers to struct's
left in libnetfs.
Apparently the copyright wasn't updated in console-run.c d
