Re: RFC: [PATCH] Re: Test case for fakeroot-hurd failure with a socket

2015-05-13 Thread Samuel Thibault
Hello, I have eventually applied this version: Svante Signell, le Wed 13 May 2015 09:35:28 +0200, a écrit : > +error_t > +netfs_set_translator (struct iouser *cred, struct node *np, > + char *argz, size_t argzlen) > +{ > + return file_set_translator (netfs_node_netnode (np)->fi

Re: RFC: [PATCH] Re: Test case for fakeroot-hurd failure with a socket

2015-05-13 Thread Samuel Thibault
Svante Signell, le Wed 13 May 2015 10:31:42 +0200, a écrit : > On Wed, 2015-05-13 at 10:04 +0200, Samuel Thibault wrote: > > Samuel Thibault, le Wed 13 May 2015 09:57:27 +0200, a écrit : > > > > + return file_set_translator (netfs_node_netnode (np)->file, > > > > + FS_T

Re: RFC: [PATCH] Re: Test case for fakeroot-hurd failure with a socket

2015-05-13 Thread Svante Signell
On Wed, 2015-05-13 at 10:04 +0200, Samuel Thibault wrote: > Samuel Thibault, le Wed 13 May 2015 09:57:27 +0200, a écrit : > > > + return file_set_translator (netfs_node_netnode (np)->file, > > > + FS_TRANS_EXCL|FS_TRANS_SET, > > > + FS_TRANS_EXCL|FS_TRAN

Re: RFC: [PATCH] Re: Test case for fakeroot-hurd failure with a socket

2015-05-13 Thread Samuel Thibault
Samuel Thibault, le Wed 13 May 2015 09:57:27 +0200, a écrit : > > + return file_set_translator (netfs_node_netnode (np)->file, > > + FS_TRANS_EXCL|FS_TRANS_SET, > > + FS_TRANS_EXCL|FS_TRANS_SET, 0, > > + argz, argzlen, > > +

Re: RFC: [PATCH] Re: Test case for fakeroot-hurd failure with a socket

2015-05-13 Thread Samuel Thibault
Svante Signell, le Wed 13 May 2015 09:35:28 +0200, a écrit : > Q: Why does it work without fakeroot-hurd? You mean on a bare filesystem? They use libdiskfs, which implements diskfs_S_file_set_translator, which calls diskfs_set_translator, which is implemented by filesystems. And the filesystems

Re: RFC: [PATCH] Re: Test case for fakeroot-hurd failure with a socket

2015-05-13 Thread Svante Signell
On Wed, 2015-05-13 at 00:52 +0200, Samuel Thibault wrote: > Hello, > > Svante Signell, le Tue 12 May 2015 22:09:33 +0200, a écrit : > > netfs_attempt_chmod() returns an error of EOPNOTSUPP and hits the > Err, no, see what I wrote earlier: “implement the > netfs_set_translator stub by just calling

Re: RFC: [PATCH] Re: Test case for fakeroot-hurd failure with a socket

2015-05-12 Thread Samuel Thibault
Hello, Svante Signell, le Tue 12 May 2015 22:09:33 +0200, a écrit : > netfs_attempt_chmod() returns an error of EOPNOTSUPP and hits the > fallback case calling the stub in > libnetfs/set-get-trans.c:netfs_set_translator() returning EOPNOTSUPP. > > Implementing netfs_S_file_set_translator() callin

RFC: [PATCH] Re: Test case for fakeroot-hurd failure with a socket

2015-05-12 Thread Svante Signell
On Thu, 2015-05-07 at 16:51 +0200, Samuel Thibault wrote: > Svante Signell, le Thu 07 May 2015 10:14:23 +0200, a écrit : > > I think I understand most of your writing above :) > > > > Should the netfs_set_translator stub be implemented in trans/fakeroot.c > > or in libnetfs/set-get-trans.c? > >

Re: Test case for fakeroot-hurd failure with a socket

2015-05-07 Thread Samuel Thibault
Svante Signell, le Thu 07 May 2015 10:14:23 +0200, a écrit : > I think I understand most of your writing above :) > > Should the netfs_set_translator stub be implemented in trans/fakeroot.c > or in libnetfs/set-get-trans.c? The former. > Still confusing is which functions are called: The ones i

Re: Test case for fakeroot-hurd failure with a socket

2015-05-07 Thread Svante Signell
On Wed, 2015-05-06 at 23:30 +0200, Samuel Thibault wrote: > Hello, > > Svante Signell, le Mon 04 May 2015 14:14:16 +0200, a écrit : > > Attached is the test code where fakeroot-hurd fails. > > fakeroot-hurd ./test_sockets > > bind: Operation not supported > > Mmm, I don't think we want to impleme

Re: Test case for fakeroot-hurd failure with a socket

2015-05-06 Thread Samuel Thibault
Hello, Svante Signell, le Mon 04 May 2015 14:14:16 +0200, a écrit : > Attached is the test code where fakeroot-hurd fails. > fakeroot-hurd ./test_sockets > bind: Operation not supported Mmm, I don't think we want to implement it in netfs_attempt_chmod as you are trying to do. See the code netfs_S

Test case for fakeroot-hurd failure with a socket

2015-05-04 Thread Svante Signell
Hi, Attached is the test code where fakeroot-hurd fails. fakeroot-hurd ./test_sockets bind: Operation not supported Using fakeroot-tcp or no fakeroot succeeds: ./test_sockets Receiving via datagram socket plain (similar with fakeroot-tcp) = rpctrace ./test_sockets ... 67<--141(pid9219)->d