Re: vim testsuite: Test_keep_pty_open V2

2025-02-08 Thread Samuel Thibault
Zhaoming Luo, le sam. 08 févr. 2025 12:51:04 +0800, a ecrit: > On Sat, Feb 08, 2025 at 08:55:31AM +0800, Zhaoming Luo wrote: > > On Fri, Feb 07, 2025 at 01:57:01PM +0100, Samuel Thibault wrote: > > > Zhaoming Luo, le ven. 07 févr. 2025 18:44:50 +0800, a ecrit: > > > > This is V2 of figuring out the

Re: vim testsuite: Test_keep_pty_open V2

2025-02-07 Thread Zhaoming Luo
On Sat, Feb 08, 2025 at 08:55:31AM +0800, Zhaoming Luo wrote: > On Fri, Feb 07, 2025 at 01:57:01PM +0100, Samuel Thibault wrote: > > Zhaoming Luo, le ven. 07 févr. 2025 18:44:50 +0800, a ecrit: > > > This is V2 of figuring out the issue. V1 is abandoned due to my mistake, > > > but this time I can

Re: vim testsuite: Test_keep_pty_open V2

2025-02-07 Thread Zhaoming Luo
On Fri, Feb 07, 2025 at 01:57:01PM +0100, Samuel Thibault wrote: > Zhaoming Luo, le ven. 07 févr. 2025 18:44:50 +0800, a ecrit: > > This is V2 of figuring out the issue. V1 is abandoned due to my mistake, > > but this time I can confirm the source of issue. This time I ran > > rpctrace directly on

Re: vim testsuite: Test_keep_pty_open V2

2025-02-07 Thread Samuel Thibault
Zhaoming Luo, le ven. 07 févr. 2025 18:44:50 +0800, a ecrit: > This is V2 of figuring out the issue. V1 is abandoned due to my mistake, > but this time I can confirm the source of issue. This time I ran > rpctrace directly on vim, and used two printfs to locate the isatty(). > > ``` > printf ("Sta

Re: vim testsuite: Test_keep_pty_open

2025-02-06 Thread Samuel Thibault
Zhaoming Luo, le jeu. 06 févr. 2025 10:54:30 +0800, a ecrit: > Though I don't know why gdb tells me it uses the implementation in > $(glibc)/unix/bsd/getpt.c. Is it expected? Yes, if you git grep you will see that there are only login/getpt.c (dumb), sysdeps/unix/sysv/linux/getpt.c (linux-specific

Re: vim testsuite: Test_keep_pty_open

2025-02-06 Thread Samuel Thibault
Zhaoming Luo, le jeu. 06 févr. 2025 11:11:42 +0800, a ecrit: > On Thu, Feb 06, 2025 at 10:54:30AM +0800, Zhaoming Luo wrote: > > On Thu, Feb 06, 2025 at 02:03:26AM +0100, Samuel Thibault wrote: > > > Zhaoming Luo, le mer. 05 févr. 2025 10:33:04 +0800, a ecrit: > > > > Intead I wrote the following p

Re: vim testsuite: Test_keep_pty_open

2025-02-05 Thread Zhaoming Luo
On Thu, Feb 06, 2025 at 10:54:30AM +0800, Zhaoming Luo wrote: > On Thu, Feb 06, 2025 at 02:03:26AM +0100, Samuel Thibault wrote: > > Zhaoming Luo, le mer. 05 févr. 2025 10:33:04 +0800, a ecrit: > > > Intead I wrote the following program to reproduce the error: > > > > > > ``` > > > #include > > >

Re: vim testsuite: Test_keep_pty_open

2025-02-05 Thread Zhaoming Luo
On Thu, Feb 06, 2025 at 02:03:26AM +0100, Samuel Thibault wrote: > Zhaoming Luo, le mer. 05 févr. 2025 10:33:04 +0800, a ecrit: > > On Tue, Feb 04, 2025 at 09:12:18AM +0100, Samuel Thibault wrote: > > > Only out_io and err_io are supposed to be readable. Or did they mean > > > from the point of vie

Re: vim testsuite: Test_keep_pty_open

2025-02-05 Thread Samuel Thibault
Zhaoming Luo, le mer. 05 févr. 2025 10:33:04 +0800, a ecrit: > On Tue, Feb 04, 2025 at 09:12:18AM +0100, Samuel Thibault wrote: > > Only out_io and err_io are supposed to be readable. Or did they mean > > from the point of view of the executed process. Again, it means check > > what exactly happens

Re: vim testsuite: Test_keep_pty_open

2025-02-04 Thread Zhaoming Luo
On Tue, Feb 04, 2025 at 09:12:18AM +0100, Samuel Thibault wrote: > > Only out_io and err_io are supposed to be readable. Or did they mean > from the point of view of the executed process. Again, it means check > what exactly happens to end up with "all readable fds are closed" > Try to keep the

Re: vim testsuite: Test_keep_pty_open

2025-02-04 Thread Samuel Thibault
Zhaoming Luo, le mar. 04 févr. 2025 16:01:09 +0800, a ecrit: > On Mon, Feb 03, 2025 at 01:21:44PM +0100, Samuel Thibault wrote: > > Zhaoming Luo, le lun. 03 févr. 2025 20:05:38 +0800, a ecrit: > > > I did the experiments using my own C waiting program and `sleep` shell > > > command respectively. T

Re: vim testsuite: Test_keep_pty_open

2025-02-04 Thread Zhaoming Luo
On Mon, Feb 03, 2025 at 01:21:44PM +0100, Samuel Thibault wrote: > Zhaoming Luo, le lun. 03 févr. 2025 20:05:38 +0800, a ecrit: > > I did the experiments using my own C waiting program and `sleep` shell > > command respectively. They gave me the same result. It seems the sleep > > program was not e

Re: vim testsuite: Test_keep_pty_open

2025-02-03 Thread Samuel Thibault
Zhaoming Luo, le lun. 03 févr. 2025 20:05:38 +0800, a ecrit: > I did the experiments using my own C waiting program and `sleep` shell > command respectively. They gave me the same result. It seems the sleep > program was not executed at all. Or it just didn't get the time to do anything. > Anothe

Re: vim testsuite: Test_keep_pty_open

2025-02-03 Thread Zhaoming Luo
On Mon, Feb 03, 2025 at 08:39:09AM +0100, Samuel Thibault wrote: > Hello, > > Zhaoming Luo, le lun. 03 févr. 2025 12:22:11 +0800, a ecrit: > > It's still the case with different sleep times. I believe the issue is > > related to: > > > > ``` > > 5.80 on 0: Closing channel because all readab

Re: vim testsuite: Test_keep_pty_open

2025-02-02 Thread Samuel Thibault
Hello, Zhaoming Luo, le lun. 03 févr. 2025 12:22:11 +0800, a ecrit: > ``` > Run 1, 13:51:24 - 13:51:24 in 0.02 seconds: > command line..script > /<>/src/vim-gtk3/testdir/runtest.vim[617]..function > RunTheTest[57]..Test_keep_pty_open line 6: Expected range 200 - 1000, but got > 20 So it b