Re: time coherency issue between libdiskfs and ext2fs

2009-04-04 Thread Samuel Thibault
Hello, At last I get some time to get back to this Thomas Schwinge, le Tue 17 Feb 2009 15:29:32 +0100, a écrit : > diff -u -p -r1.11 io-stat.c > --- libdiskfs/io-stat.c 12 Apr 2001 19:43:43 - 1.11 > +++ libdiskfs/io-stat.c 17 Feb 2009 14:27:30 - > @@ -45,6 +46,9 @@ diskfs

Re: time coherency issue between libdiskfs and ext2fs

2009-02-17 Thread Thomas Schwinge
Hello! On Tue, Feb 17, 2009 at 10:26:46AM +0100, I wrote: > On Tue, Feb 10, 2009 at 02:34:16AM +0100, Samuel Thibault wrote: > > FS to round values up (I could see that on a machine that has both > > second- and ns-precision filesystems). Maybe we should do the same: in > > the diskfs_S_file_utim

Re: time coherency issue between libdiskfs and ext2fs

2009-02-17 Thread Thomas Schwinge
Hello! On Tue, Feb 10, 2009 at 02:34:16AM +0100, Samuel Thibault wrote: > FS to round values up (I could see that on a machine that has both > second- and ns-precision filesystems). Maybe we should do the same: in > the diskfs_S_file_utimes () and diskfs_set_node_times () Rather than doing it ev

Re: time coherency issue between libdiskfs and ext2fs

2009-02-10 Thread Roland McGrath
> But does it sound right to implement it through a callback that the fs > provides to libdiskfs when the latter needs to normalize a time stamp? I don't see how else it could be. The granularity of stored time stamps is format knowledge.

Re: time coherency issue between libdiskfs and ext2fs

2009-02-10 Thread Samuel Thibault
Roland McGrath, le Tue 10 Feb 2009 10:32:30 -0800, a écrit : > libdiskfs ought to normalize time stamps to match what will appear on disk, > before it ever reports them to the user. Right, we at least agree on what we want :) But does it sound right to implement it through a callback that the fs

Re: time coherency issue between libdiskfs and ext2fs

2009-02-10 Thread Roland McGrath
libdiskfs ought to normalize time stamps to match what will appear on disk, before it ever reports them to the user.