Re: [PATCH v2] libshouldbeinlibc: Use 64bit mapped time values in maptime_read when possible

2025-05-03 Thread Samuel Thibault
Zhaoming Luo, le sam. 03 mai 2025 21:28:08 +0800, a ecrit: > Use 64bit mapped time values in maptime_read when the kernel and the > mapped_time_value structure in header file time_value.h support it. > Otherwise step back to use the 32bit time. Applied, thanks! Samuel > --- > configure.ac

Re: [PATCH hurd] libshouldbeinlibc: Use 64bit mapped time values in maptime_read when possible

2025-05-03 Thread Samuel Thibault
Hello, Zhaoming Luo, le sam. 03 mai 2025 12:49:56 +0800, a ecrit: > Use 64bit mapped time values in maptime_read when possible. The 64bit > time values in mapped time will be zero when the kernel does not support > 64bit mapped time. > + if (mtime->time_value.seconds == 0) Please add AC_CHECK_

Re: [PATCH v2] libdiskfs: Get the time with higher resolution from kernel when possible

2025-05-02 Thread Samuel Thibault
Zhaoming Luo, le sam. 03 mai 2025 08:30:10 +0800, a ecrit: > On Sat, May 03, 2025 at 02:21:31AM +0200, Samuel Thibault wrote: > > Zhaoming Luo, le sam. 03 mai 2025 08:17:52 +0800, a ecrit: > > > On Sat, May 03, 2025 at 02:10:12AM +0200, Samuel Thibault wrote: > > > > Zhaoming Luo, le ven. 02 mai 20

Re: [PATCH v2] libdiskfs: Get the time with higher resolution from kernel when possible

2025-05-02 Thread Zhaoming Luo
On Sat, May 03, 2025 at 02:21:31AM +0200, Samuel Thibault wrote: > Zhaoming Luo, le sam. 03 mai 2025 08:17:52 +0800, a ecrit: > > On Sat, May 03, 2025 at 02:10:12AM +0200, Samuel Thibault wrote: > > > Zhaoming Luo, le ven. 02 mai 2025 22:45:44 +0800, a ecrit: > > > > Get the time with higher resolu

Re: [PATCH v2] libdiskfs: Get the time with higher resolution from kernel when possible

2025-05-02 Thread Samuel Thibault
Zhaoming Luo, le sam. 03 mai 2025 08:17:52 +0800, a ecrit: > On Sat, May 03, 2025 at 02:10:12AM +0200, Samuel Thibault wrote: > > Zhaoming Luo, le ven. 02 mai 2025 22:45:44 +0800, a ecrit: > > > Get the time with higher resolution from kernel using host_get_time64() > > > when possible. > > > > It

Re: [PATCH v2] libdiskfs: Get the time with higher resolution from kernel when possible

2025-05-02 Thread Zhaoming Luo
On Sat, May 03, 2025 at 02:10:12AM +0200, Samuel Thibault wrote: > Zhaoming Luo, le ven. 02 mai 2025 22:45:44 +0800, a ecrit: > > Get the time with higher resolution from kernel using host_get_time64() > > when possible. > > It seems there's a misunderstanding. I explained that the mapped time > d

Re: [PATCH v2] libdiskfs: Get the time with higher resolution from kernel when possible

2025-05-02 Thread Samuel Thibault
Zhaoming Luo, le ven. 02 mai 2025 22:45:44 +0800, a ecrit: > Get the time with higher resolution from kernel using host_get_time64() > when possible. It seems there's a misunderstanding. I explained that the mapped time does have 64bit precision fields, that's what I mean we want to use, rather th

Re: [PATCH 0/1] libdiskfs: Get the time with higher resolution from kernel

2025-05-02 Thread Samuel Thibault
Zhaoming Luo, le ven. 02 mai 2025 18:52:49 +0800, a ecrit: > I'm wondering if I should consider the case that host_get_time64() is not > supported Yes, please. I wonder how many times I will have to repeat it: backward compatibility is really important, otherwise people can't try to downgrade ker

Re: [PATCH mach] Fix comment

2025-05-01 Thread Samuel Thibault
Zhaoming Luo, le jeu. 01 mai 2025 18:13:46 +0800, a ecrit: > We can have better resolution now so this comment can be removed. Applied, thanks! Samuel > --- > include/mach/time_value.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/mach/time_value.h b/include/

Re: [PATCH] hurd: save xstate during signal handling

2025-04-19 Thread Samuel Thibault
Hello, So it works as your additional test shows, but it is fragile. Luca Dariz, le mer. 19 mars 2025 18:11:18 +0100, a ecrit: > diff --git a/sysdeps/mach/hurd/i386/sigreturn.c > b/sysdeps/mach/hurd/i386/sigreturn.c > index ce8df8d02b..618cb74196 100644 > --- a/sysdeps/mach/hurd/i386/sigreturn.c

Re: [PATCH] hurd: save xstate during signal handling

2025-04-17 Thread Samuel Thibault
Hello I fixed these and pushed it, thanks so much! Samuel Samuel Thibault, le ven. 11 avril 2025 02:27:04 +0200, a ecrit: > Hello, > > Sorry it took me long to manage to fine time to look at this... > > Luca Dariz, le mer. 19 mars 2025 18:11:18 +0100, a ecrit: > > diff --git a/sysdeps/mach/hur

Re: [PATCH] hurd: save xstate during signal handling

2025-04-10 Thread Samuel Thibault
Hello, Sorry it took me long to manage to fine time to look at this... Luca Dariz, le mer. 19 mars 2025 18:11:18 +0100, a ecrit: > diff --git a/sysdeps/mach/hurd/i386/sigreturn.c > b/sysdeps/mach/hurd/i386/sigreturn.c > index ce8df8d02b..618cb74196 100644 > --- a/sysdeps/mach/hurd/i386/sigreturn

Re: [PATCH web] The option -M q35 is needed when trying rumpdisk in qemu

2025-04-10 Thread Samuel Thibault
Zhaoming Luo, le jeu. 10 avril 2025 20:20:26 +0800, a ecrit: > The option -M q35 is needed when trying rumpdisk in qemu It would be useful to track down why, and fix the issue :) Samuel > --- > hurd/rump/rumpdisk.mdwn | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/hurd/rump/

Re: [PATCH web] Typo fixed

2025-04-10 Thread Samuel Thibault
Applied, thanks! Zhaoming Luo, le jeu. 10 avril 2025 08:55:49 +0800, a ecrit: > --- > hurd/running/debian/qemu_image.mdwn | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hurd/running/debian/qemu_image.mdwn > b/hurd/running/debian/qemu_image.mdwn > index 9984ac33..8409bc

Re: [PATCH] x86_64: update ifdef to exclude the x86_64 for i386 only specific conditions

2025-04-07 Thread Samuel Thibault
Applied, thanks! Etienne Brateau, le lun. 07 avril 2025 22:11:26 +0200, a ecrit: > --- > i386/i386/trap.c| 4 ++-- > i386/intel/pmap.c | 4 ++-- > i386/intel/read_fault.c | 2 +- > 3 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/i386/i386/trap.c b/i386/i386/trap.c

Re: [PATCH 1/1 web] contributing: Fix the 'curl' testsuite

2025-04-03 Thread Samuel Thibault
Zhaoming Luo, le jeu. 03 avril 2025 12:42:19 +0800, a ecrit: > This is done. Applied, thanks! > --- > contributing.mdwn | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/contributing.mdwn b/contributing.mdwn > index d79388ab..c9ce3c6a 100644 > --- a/contributing.mdwn > +++ b/contributing.

Re: [PATCH Hurd] Comment fixed

2025-04-02 Thread Samuel Thibault
Applied, thanks! Zhaoming Luo, le mer. 02 avril 2025 17:23:54 +0800, a ecrit: > --- > hurd/io.defs | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hurd/io.defs b/hurd/io.defs > index 5bc399ed..4c63de36 100644 > --- a/hurd/io.defs > +++ b/hurd/io.defs > @@ -46,7 +46,7 @@

Re: [PATCH web] contributing: Improve the get time functions accuracy using HPET

2025-03-25 Thread Samuel Thibault
Applied, thanks! Zhaoming Luo, le mer. 26 mars 2025 12:06:08 +0800, a ecrit: > This is done. > See: > https://git.savannah.gnu.org/cgit/hurd/gnumach.git/commit/?id=6d91c78f0c240e3c7d81e19e85507e0aec580d6f > > --- > contributing.mdwn | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/contri

Re: [PATCH mach v4 1/1] Integrate HPET so the functions used for getting time can have a higher accuracy

2025-03-24 Thread Samuel Thibault
Applied, thanks! Zhaoming Luo, le lun. 24 mars 2025 12:25:51 +0800, a ecrit: > Integrate HPET so host_get_time, host_get_time64, and host_get_uptime64 > are more precise. The highest precision can be 10ns when this patch is > applied. > > * i386/i386/apic.c: Implement the two high-precision clock

Re: [PATCH v3] mach: Use the host_get_time64 to replace the deprecated host_get_time for CLOCK_REALTIME when it's available

2025-03-24 Thread Samuel Thibault
Applied, thanks! Zhaoming Luo, le lun. 24 mars 2025 13:20:42 +0800, a ecrit: > Check the availability of host_get_time64 and use it to replace > host_get_time for CLOCK_REALTIME when it's available. Fall back to > host_get_time if gnumach does not support host_get_time64 but the > gnumach headers

Re: [PATCH v2 1/1] mach: Use the host_get_time64 to replace the deprecated host_get_time for CLOCK_REALTIME when it's available

2025-03-23 Thread Samuel Thibault
Zhaoming Luo, le dim. 23 mars 2025 10:47:14 +0800, a ecrit: > Check the availability of host_get_time64 and use it to replace > host_get_time for CLOCK_REALTIME when it's available. > case CLOCK_REALTIME: >{ > - /* __host_get_time can only fail if passed an invalid host_t. > +

Re: [PATCH] mach: Use the host_get_time64 to replace the deprecated host_get_time for CLOCK_REALTIME

2025-03-22 Thread Samuel Thibault
Hello, Zhaoming Luo, le dim. 23 mars 2025 09:50:33 +0800, a ecrit: > Use the host_get_time64 to replace the deprecated host_get_time for > CLOCK_REALTIME. host_get_time64 is not always available, not with older gnumach. Please use #if machinery like above in the monotonic case. In general, pleas

Re: [PATCH] hurd: Check return value of mach_port_mod_refs() in the dup routine of fcntl()

2025-03-05 Thread Samuel Thibault
Hello, While at it, we'd better also fix sysdeps/mach/hurd/dup3.c the exact same way (which will also fix dup2). Thanks, Samuel Zhaoming Luo, le jeu. 06 mars 2025 06:39:04 +0800, a ecrit: > Ignoring the return value of mach_port_mod_ref() causes the situation > + if (err) > +

Re: [PATCH hurd] Allow compilation with -O0

2025-02-10 Thread Samuel Thibault
Samuel Thibault, le lun. 10 févr. 2025 13:57:46 +0100, a ecrit: > Flavio Cruz, le dim. 09 févr. 2025 22:36:30 -0500, a ecrit: > > * pfinet/linux-src/net/ipv4/{tcp,udp}_ipv4.c: mark lookup functions as > > extern since they are used in another module (icmp.c) and shouldn't be > > removed. > > >

Re: [PATCH mig] Server routines: ensure that strings in the request are null terminated before calling the server routine

2025-02-10 Thread Samuel Thibault
Applied, thanks! Flavio Cruz, le dim. 09 févr. 2025 22:38:26 -0500, a ecrit: > --- > server.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/server.c b/server.c > index 8da231c..9d25573 100644 > --- a/server.c > +++ b/server.c > @@ -766,6 +766,14 @@ WriteExtractArg(FILE *file,

Re: [PATCH glibc] mig_strncpy: ensure destination string is null terminated

2025-02-10 Thread Samuel Thibault
Applied, thanks! Flavio Cruz, le dim. 09 févr. 2025 22:37:56 -0500, a ecrit: > --- > mach/mig_strncpy.c | 10 +- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/mach/mig_strncpy.c b/mach/mig_strncpy.c > index b0c001d775..dbd0a08e56 100644 > --- a/mach/mig_strncpy.c > ++

Re: [PATCH gnumach] mig_strncpy: ensure destination string is null terminated

2025-02-10 Thread Samuel Thibault
Applied, thanks! Flavio Cruz, le dim. 09 févr. 2025 22:37:13 -0500, a ecrit: > --- > kern/ipc_mig.c | 25 + > 1 file changed, 13 insertions(+), 12 deletions(-) > > diff --git a/kern/ipc_mig.c b/kern/ipc_mig.c > index 18ac88ef..b6543703 100644 > --- a/kern/ipc_mig.c > +++

Re: [PATCH hurd] Allow compilation with -O0

2025-02-10 Thread Samuel Thibault
Flavio Cruz, le dim. 09 févr. 2025 22:36:30 -0500, a ecrit: > * pfinet/linux-src/net/ipv4/{tcp,udp}_ipv4.c: mark lookup functions as > extern since they are used in another module (icmp.c) and shouldn't be > removed. > diff --git a/pfinet/linux-src/net/ipv4/tcp_ipv4.c > b/pfinet/linux-src/net

Re: [PATCH] term: The term_getctty() accepts pty_class

2025-02-08 Thread Samuel Thibault
Applied, thanks! Zhaoming Luo, le sam. 08 févr. 2025 18:32:20 +0800, a ecrit: > The term_getctty() should accept pty_class > > See > https://mail.gnu.org/archive/html/bug-hurd/2025-02/msg00061.html > > * term/users.c: The term_getctty() accepts pty_class > --- > term/users.c | 2 +- > 1 file ch

Re: [PATCH 5/6] GNU/Hurd: disable symbolize.

2025-02-07 Thread Yuqian Yang
On 2025-02-07 23:51, Samuel Thibault wrote: Yuqian Yang, le ven. 07 févr. 2025 23:27:01 +0800, a ecrit: I know this is due to the way of our kernel to handle file and memory. Do we have a good way to fix this, Not a trivial way. It'd need adding names to the kernel map entries, and setting t

Re: [PATCH 5/6] GNU/Hurd: disable symbolize.

2025-02-07 Thread Sergey Bugaev
On Fri, Feb 7, 2025 at 6:51 PM Samuel Thibault wrote: > Yuqian Yang, le ven. 07 févr. 2025 23:27:01 +0800, a ecrit: > > I know this is due to the way of our kernel to handle file and memory. > > Do we have a good way to fix this, > > Not a trivial way. It'd need adding names to the kernel map entr

Re: [PATCH 5/6] GNU/Hurd: disable symbolize.

2025-02-07 Thread Samuel Thibault
Yuqian Yang, le ven. 07 févr. 2025 23:27:01 +0800, a ecrit: > I know this is due to the way of our kernel to handle file and memory. > Do we have a good way to fix this, Not a trivial way. It'd need adding names to the kernel map entries, and setting them from mmap() and such functions that map fi

Re: [PATCH 5/6] GNU/Hurd: disable symbolize.

2025-02-07 Thread Yuqian Yang
When I fixed abseil[1] for Hurd, I disabled its debugging feature of finding the symbol of current functions or any other symbols.[2] It does not work on Hurd and its unit tests failed. It can be safely disabled and does not affect other functions of lib just like platforms that do not support it,

Re: [PATCH 0/1] Exclude GNU/Hurd from has('bsd') feature

2025-02-04 Thread Zhaoming Luo
On Mon, Feb 03, 2025 at 04:41:13PM +0800, Zhaoming Luo wrote: > > Zhaoming Luo (1): > Exclude GNU/Hurd from has('bsd') feature > > src/evalfunc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > As it seems not to be the correct way of submitting patch to Vim, so I opened a RP at git

Re: [PATCH gnumach v3] Implement per task virtual memory limit

2025-02-04 Thread Samuel Thibault
Samuel Thibault, le ven. 10 janv. 2025 19:40:05 +0100, a ecrit: > Diego Nieto Cid, le mar. 07 janv. 2025 18:48:49 +, a ecrit: > > I've been running gnumach with this patch for some time, doing other > > porting/debugging tasks and suffered from sporadic filesystem corruption. > > Probably ext2

Re: [PATCH Web 1/2] Organize and detail Running_the_Hurd in home page.

2025-02-01 Thread Samuel Thibault
Applied both, thanks! Samuel Yuqian Yang, le ven. 31 janv. 2025 18:31:38 +0800, a ecrit: > * The old "Access to a GNU/Hurd System" is very vague. Move it to > Running section. > > * Add details to Running section. Separate following things into > individual paragraphs. > > * Running platf

Re: [PATCH] Add source code link to sidebar.

2025-02-01 Thread Zhaoming Luo
On Wed, Jan 29, 2025 at 05:28:05PM +0800, Yuqian Yang wrote: > > That's a good idea! Thanks for the contribution! > > You are so welcome. > > After struggling about my own things for several months, I turn back to Hurd > now. I'm reading the doc now and recording some things for bootstrap of > c

Re: [PATCH Web] Add more info about running hurd in VirtualBox.

2025-01-29 Thread Samuel Thibault
Applied, thanks! Yuqian Yang, le mer. 29 janv. 2025 23:14:31 +0800, a ecrit: > Many people are familiar with VirtualBox, or using OS other than > GNU/Linux. VirtualBox gives them more opportunity to play with Hurd. > --- > hurd/running/virtualbox.mdwn | 19 +-- > index.mdwn

Re: [PATCH] Add source code link to sidebar.

2025-01-29 Thread jbranso
January 29, 2025 at 4:28 AM, "Yuqian Yang" mailto:crup...@crupest.life?to=%22Yuqian%20Yang%22%20%3Ccrupest%40crupest.life%3E > wrote: > > > > > That's a good idea! Thanks for the contribution! > > > You are so welcome. > > After struggling about my own things for several months, I turn back

Re: [PATCH] Add source code link to sidebar.

2025-01-29 Thread Yuqian Yang
That's a good idea! Thanks for the contribution! You are so welcome. After struggling about my own things for several months, I turn back to Hurd now. I'm reading the doc now and recording some things for bootstrap of contributing to Hurd. So I'll mainly contribute to doc recently. BTW, d

Re: [PATCH] Add doc of topgit installation to make it easier.

2025-01-29 Thread Yuqian Yang
If you have not seen this website, it is a simple way to get started with git send-email: https://git-send-email.io/ That's a really nice guide. Neat and essential. Actually I was about to learn git send-email and how to organize my mails to better use mailing list. There are a lot of duplica

Re: [PATCH mig v2] header: add definitions for RPC presence and IDs

2025-01-28 Thread Samuel Thibault
Applied, thanks! Luca Dariz, le lun. 06 janv. 2025 14:46:49 +0100, a ecrit: > This allows to check at compilation time for some rpc (as done for > example in glibc for thread_set/get_name() and host_page_size()). > Also the IDs can be useful for testing purposes, or when assembling > messages manu

Re: [PATCH] Add source code link to sidebar.

2025-01-28 Thread jbranso
January 27, 2025 at 2:16 AM, "Yuqian Yang" mailto:crup...@crupest.life?to=%22Yuqian%20Yang%22%20%3Ccrupest%40crupest.life%3E > wrote: > > Make it easier to get source code directly. That's a good idea! Thanks for the contribution! > --- > sidebar.mdwn | 1 + > 1 file changed, 1 insertion(+

Re: [PATCH hurd v2] Add partial /proc/cpuinfo implementation

2025-01-27 Thread Samuel Thibault
Applied, thanks! dnie...@gmail.com, le lun. 27 janv. 2025 01:17:33 +, a ecrit: > From: Diego Nieto Cid > > Hello, > > On Sun, Jan 26, 2025 at 10:18:03PM +0100, Samuel Thibault wrote: > > > > dnie...@gmail.com, le ven. 10 janv. 2025 23:52:28 +, a ecrit: > > > --- a/procfs/rootdir.c > > >

Re: [PATCH] Add source code link to sidebar.

2025-01-27 Thread Samuel Thibault
Yuqian Yang, le lun. 27 janv. 2025 15:16:54 +0800, a ecrit: > Make it easier to get source code directly. Applied, thanks! > --- > sidebar.mdwn | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sidebar.mdwn b/sidebar.mdwn > index b2c7c223..87b0633b 100644 > --- a/sidebar.mdwn > +++ b/sid

Re: [PATCH] Add doc of topgit installation to make it easier.

2025-01-27 Thread jbranso
January 26, 2025 at 11:23 AM, "Yuqian Yang" mailto:crup...@crupest.life?to=%22Yuqian%20Yang%22%20%3Ccrupest%40crupest.life%3E > wrote: > > On 2025-01-26 23:52, Samuel Thibault wrote: > > > > > I applied it but that came with trouble: the lines were split, and > > with spurious heading space

Re: [PATCH hurd v1] Add partial /proc/cpuinfo implementation

2025-01-26 Thread Samuel Thibault
Sergey Bugaev, le lun. 27 janv. 2025 00:25:15 +0300, a ecrit: > > > +out: > > > + flcose(m); > > > > You didn't try to compile it ;) > > I suppose that's not easy for Diego to do, given the state of aarch64-gnu :) Sure, but he can comment the very few really-arm64-specific lines and try to build

Re: [PATCH hurd v1] Add partial /proc/cpuinfo implementation

2025-01-26 Thread Sergey Bugaev
On Mon, Jan 27, 2025 at 12:18 AM Samuel Thibault wrote: > > + err = aarch64_get_hwcaps(mach_host_self(), &caps, &mdir, &revdir); > > + if (err) > > +goto out; > > + > > + implementer = (mdir & 0xff00) >> 24; > > + variant = (mdir & 0x00f0) >> 20; > > + architecture = (mdir &

Re: [PATCH hurd v1] Add partial /proc/cpuinfo implementation

2025-01-26 Thread Samuel Thibault
Hello, Thanks for working on it :) Sorry for the delay, dnie...@gmail.com, le ven. 10 janv. 2025 23:52:28 +, a ecrit: > --- a/procfs/rootdir.c > +++ b/procfs/rootdir.c > @@ -38,6 +38,12 @@ > #include "procfs_dir.h" > #include "main.h" > #include > +#if defined (__x86_64__) || defined (_

Re: [PATCH] Add doc of topgit installation to make it easier.

2025-01-26 Thread Samuel Thibault
Yuqian Yang, le lun. 27 janv. 2025 00:23:31 +0800, a ecrit: > On 2025-01-26 23:52, Samuel Thibault wrote: > > I applied it but that came with trouble: the lines were split, and > > with spurious heading spaces. Did you really use git format-patch / > > send-email to send it? > > Sorry for troublin

Re: [PATCH] Add doc of topgit installation to make it easier.

2025-01-26 Thread Yuqian Yang
On 2025-01-26 23:52, Samuel Thibault wrote: I applied it but that came with trouble: the lines were split, and with spurious heading spaces. Did you really use git format-patch / send-email to send it? Sorry for troubling you. To be honest, I copy/paste the patch and sent it via my email clien

Re: [PATCH] Add doc of topgit installation to make it easier.

2025-01-26 Thread Samuel Thibault
Hello, Yuqian Yang, le dim. 26 janv. 2025 23:12:59 +0800, a ecrit: > One notable problem is that topgit is default to install to prefix `~` > rather than `~/.local`, which might surprise some people. I applied it but that came with trouble: the lines were split, and with spurious heading spaces.

Re: [PATCH v2] procfs: set d_type on returned direntries

2025-01-20 Thread Diego Nieto Cid
On Tue, Jan 21, 2025 at 01:02:12AM +0100, Samuel Thibault wrote: > > Sorry for the back&forth, we couldn't know before trying. > No problem, I'll drop this patch then. Thanks

Re: [PATCH v2] procfs: set d_type on returned direntries

2025-01-20 Thread Samuel Thibault
Hello, dnie...@gmail.com, le lun. 20 janv. 2025 23:47:58 +, a ecrit: > From: Diego Nieto Cid > > Thanks for the pointer Samuel. I managed to call procfs_lookup > and extract from the node stat structure its type. > > It mostly works except for the ".." and "self" entries: > > ./test-pr

Re: [PATCH] procfs: set d_type on returned direntries

2025-01-20 Thread Samuel Thibault
Hello, dnie...@gmail.com, le dim. 19 janv. 2025 23:50:10 +, a ecrit: > diff --git a/procfs/netfs.c b/procfs/netfs.c > index 4ed5eab6..3cf7a8e2 100644 > --- a/procfs/netfs.c > +++ b/procfs/netfs.c > @@ -115,6 +115,29 @@ error_t netfs_attempt_readlink (struct iouser *user, > struct node *np, >

Re: [PATCH 0/1] fix cp /dev/null file

2025-01-18 Thread Samuel Thibault
gfleury, le sam. 18 janv. 2025 13:10:20 +0200, a ecrit: > This fixes a bug related to `cp /dev/null file`, where you would encounter an > error like: > `skipping file /dev/null as it was replaced while being copied`. > > I reduced the `st_blksize` to one page, as it is on GNU/Linux, and added a

Re: [PATCH 1/1 Web] Open issues: Update clock_gettime page

2025-01-14 Thread Samuel Thibault
Tuned and applied, thanks! Zhaoming Luo, le mar. 14 janv. 2025 09:50:01 +0800, a ecrit: > The clock_gettime(CLOCK_MONOTONIC) is implemented. See > > https://sourceware.org/git?p=glibc.git;a=commit;h=3782ffaf3e6c2a071df029b96712e596b5229838 > > so this page is out of date. > > Rename the page to

Re: [PATCH gnumach v1] [aarch64] make hwcaps_t a pointer to uint64_t

2025-01-13 Thread Samuel Thibault
Applied, thanks! dnie...@gmail.com, le jeu. 09 janv. 2025 22:40:55 +, a ecrit: > From: Diego Nieto Cid > > Hi, > > I went ahead and made a patch for the hwcaps_t type. I'm not sure > if it is that simple. I figured the implementation of the RPC should > be changed too, but couldn't find it

Re: [PATCH hurd] rumpusbdisk: Link completely to scsipi library

2025-01-11 Thread Samuel Thibault
Applied, thanks! Damien Zammit via Bug reports for the GNU Hurd, le sam. 11 janv. 2025 08:21:50 +, a ecrit: > The usb stack also uses SCSI emulation for usb mass storage. > > --- > rumpdisk/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/rumpdisk/Makefile

Re: [PATCH gnumach v3] Implement per task virtual memory limit

2025-01-10 Thread Diego Nieto Cid
Hi, On Fri, Jan 10, 2025 at 07:40:05PM +0100, Samuel Thibault wrote: > > Probably ext2fs doesn't really cope well with memory allocation > limitation? > That's a good candidate, indeed. I replaced the prinf with a panic call, but I couldn't reproduce the error, yet. Diego

Re: [PATCH gnumach v3] Implement per task virtual memory limit

2025-01-10 Thread Samuel Thibault
Hello, Diego Nieto Cid, le mar. 07 janv. 2025 18:48:49 +, a ecrit: > I've been running gnumach with this patch for some time, doing other > porting/debugging tasks and suffered from sporadic filesystem corruption. Probably ext2fs doesn't really cope well with memory allocation limitation? Sa

Re: [PATCH gnumach v3] Implement per task virtual memory limit

2025-01-07 Thread Diego Nieto Cid
Hello, I've been running gnumach with this patch for some time, doing other porting/debugging tasks and suffered from sporadic filesystem corruption. I'm afraid this changes could be the cause of the issue. Currently, I switched back to the kernel supplied by the Debian package to check whether c

Re: [PATCH gnumach v2] Implement per task virtual memory limit

2025-01-04 Thread Diego Nieto Cid
Hello, On Wed, Dec 25, 2024 at 04:16:06PM -0300, dnie...@gmail.com wrote: > > +/* > + * Enforces the VM limit of a target map. > + */ > +static kern_return_t > +vm_map_enforce_limit( > + vm_map_t map, > + vm_size_t size, > + const char *fn_name) > +{ > + /* Limit is ignored for

Re: [PATCH Web v2] Translator: Add the introduction to the rtc translator

2025-01-02 Thread Samuel Thibault
Applied, thanks! Zhaoming Luo, le jeu. 02 janv. 2025 09:55:23 +0800, a ecrit: > * hurd/translator.mdwn: Add an entry for the rtc translator > * hurd/translator/rtc.mdwn: Add the introduction to the rtc translator > > --- > hurd/translator.mdwn | 1 + > hurd/translator/rtc.mdwn | 31 ++

Re: [PATCH] Header files: Install rtc.h header file

2025-01-01 Thread Samuel Thibault
Applied, thanks! Zhaoming Luo, le jeu. 02 janv. 2025 08:45:51 +0800, a ecrit: > --- > hurd/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hurd/Makefile b/hurd/Makefile > index 5200baef..3463f783 100644 > --- a/hurd/Makefile > +++ b/hurd/Makefile > @@ -20,7 +20,

Re: [PATCH Web] Translator: Add the introduction to the rtc translator

2025-01-01 Thread Samuel Thibault
Hello, Zhaoming Luo, le mer. 01 janv. 2025 15:38:52 +0800, a ecrit: > * hurd/translator.mdwn: Add an entry for the rtc translator > * hurd/translator/rtc.mdwn: Add the introduction to the rtc translator > > Signed-off-by: Zhaoming Luo > --- > hurd/translator.mdwn | 1 + > hurd/translator

Re: [PATCH Mach] kern: Add a mach host operation which returns elapsed time since bootup

2024-12-31 Thread Zhaoming Luo
On 12/31/24 7:33 AM, Samuel Thibault wrote: Zhaoming Luo, le mar. 31 déc. 2024 07:24:08 +0800, a ecrit: On 12/29/24 5:21 PM, Samuel Thibault wrote: Zhaoming Luo, le dim. 29 déc. 2024 12:44:27 +0800, a ecrit: On 12/29/24 9:28 AM, Samuel Thibault wrote: Hello, Zhaoming Luo, le mar. 24 déc. 202

Re: [PATCH gnumach v2] Implement per task virtual memory limit

2024-12-31 Thread Samuel Thibault
Sergey Bugaev, le mar. 31 déc. 2024 07:41:14 +0300, a ecrit: > On Tue, Dec 31, 2024 at 1:30 AM Diego Nieto Cid wrote: > > On Mon, Dec 30, 2024 at 07:08:55PM +0100, Samuel Thibault wrote: > > > You also need to take into account the case where > > > current->max_protection was NONE and new_prot is

Re: [PATCH gnumach v2] Implement per task virtual memory limit

2024-12-30 Thread Sergey Bugaev
On Tue, Dec 31, 2024 at 1:30 AM Diego Nieto Cid wrote: > On Mon, Dec 30, 2024 at 07:08:55PM +0100, Samuel Thibault wrote: > > You also need to take into account the case where > > current->max_protection was NONE and new_prot is not NONE, you then have > > to decrease size_none. > Ah right, the &

Re: [PATCH Mach] kern: Add a mach host operation which returns elapsed time since bootup

2024-12-30 Thread Samuel Thibault
Zhaoming Luo, le mar. 31 déc. 2024 07:24:08 +0800, a ecrit: > On 12/29/24 5:21 PM, Samuel Thibault wrote: > > Zhaoming Luo, le dim. 29 déc. 2024 12:44:27 +0800, a ecrit: > > > On 12/29/24 9:28 AM, Samuel Thibault wrote: > > > > Hello, > > > > > > > > Zhaoming Luo, le mar. 24 déc. 2024 09:57:51 +08

Re: [PATCH Mach] kern: Add a mach host operation which returns elapsed time since bootup

2024-12-30 Thread Zhaoming Luo
On 12/29/24 5:21 PM, Samuel Thibault wrote: Zhaoming Luo, le dim. 29 déc. 2024 12:44:27 +0800, a ecrit: On 12/29/24 9:28 AM, Samuel Thibault wrote: Hello, Zhaoming Luo, le mar. 24 déc. 2024 09:57:51 +0800, a ecrit: Add host_get_uptime64() mach interface operation. It can be used to get the ti

Re: [PATCH gnumach v2] Implement per task virtual memory limit

2024-12-30 Thread Diego Nieto Cid
Hi, On Mon, Dec 30, 2024 at 07:08:55PM +0100, Samuel Thibault wrote: > > Please also add printing size_null in vm_map_print. > Ok > dnie...@gmail.com, le mer. 25 déc. 2024 16:16:06 -0300, a ecrit: > > > @@ -1679,11 +1747,13 @@ kern_return_t vm_map_protect( > > vm_map_clip_end(map,

Re: [PATCH gnumach v2] Implement per task virtual memory limit

2024-12-30 Thread Samuel Thibault
Hello, Please also add printing size_null in vm_map_print. dnie...@gmail.com, le mer. 25 déc. 2024 16:16:06 -0300, a ecrit: > @@ -1160,6 +1226,8 @@ kern_return_t vm_map_enter( > > vm_map_entry_link(map, entry, new_entry); > map->size += size; > + if (max_protection == VM_PROT_NO

Re: [PATCH Mach] kern: Add a mach host operation which returns elapsed time since bootup

2024-12-29 Thread Samuel Thibault
Zhaoming Luo, le dim. 29 déc. 2024 12:44:27 +0800, a ecrit: > On 12/29/24 9:28 AM, Samuel Thibault wrote: > > Hello, > > > > Zhaoming Luo, le mar. 24 déc. 2024 09:57:51 +0800, a ecrit: > > > Add host_get_uptime64() mach interface operation. It can be used to get > > > the time passed since the boo

Re: [PATCH Mach] kern: Add a mach host operation which returns elapsed time since bootup

2024-12-28 Thread Zhaoming Luo
On 12/29/24 9:28 AM, Samuel Thibault wrote: Hello, Zhaoming Luo, le mar. 24 déc. 2024 09:57:51 +0800, a ecrit: Add host_get_uptime64() mach interface operation. It can be used to get the time passed since the boot up. * doc/mach.texi: Add the documentation for the operation * include/mach/mach

Re: [PATCH Mach] kern: Add a mach host operation which returns elapsed time since bootup

2024-12-28 Thread Samuel Thibault
Hello, Zhaoming Luo, le mar. 24 déc. 2024 09:57:51 +0800, a ecrit: > Add host_get_uptime64() mach interface operation. It can be used to get > the time passed since the boot up. > > * doc/mach.texi: Add the documentation for the operation > * include/mach/mach_host.defs: Add the interface > * inc

Re: [PATCH v2 1/1 libacpica] acpi_init: Get pci root port handle \_SB.PCI0 directly

2024-12-28 Thread Samuel Thibault
Applied, thanks! Damien Zammit via Bug reports for the GNU Hurd, le sam. 28 déc. 2024 02:36:06 +, a ecrit: > This mostly fixes the numbering of IRQs when requested. > This now works on an old AMD board with broken _CRS. > It requests the possible irqs from _PRS and generates > a valid _SRS re

Re: [PATCH 1/2 libacpica] acpi_init: Match resources on function 0xffff

2024-12-28 Thread Samuel Thibault
Applied, thanks! Damien Zammit via Bug reports for the GNU Hurd, le sam. 28 déc. 2024 01:28:02 +, a ecrit: > This ensures the resources are correct when matching. > Resources are always all ones in the function field > as they apply to all functions of a device. > > --- > debian/patches/acp

Re: [PATCH gnumach] i386/irq: Add missing enumeration for high interrupts

2024-12-28 Thread Samuel Thibault
Applied, thanks! Damien Zammit via Bug reports for the GNU Hurd, le sam. 28 déc. 2024 04:20:23 +, a ecrit: > Because we support up to 64 irqs with 2 IOAPICs. > > --- > i386/i386/irq.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/i386/i386/irq.c b/i386/i386/ir

Re: [PATCH v2 hurd] pci-arbiter: Fix long standing bug with PCI access

2024-12-28 Thread Samuel Thibault
Applied, thanks! Damien Zammit via Bug reports for the GNU Hurd, le sam. 28 déc. 2024 07:35:52 +, a ecrit: > Proxied memory was not rounded up to page size, causing > error with vm_map'ing the underlying memory. > > WARNING: Assumes pci memory resources are at least page aligned. > If not,

Re: [PATCH hurd] rumpdisk: Try to reduce memory usage

2024-12-28 Thread Damien Zammit via Bug reports for the GNU Hurd
On 12/29/24 8:56 AM, Samuel Thibault wrote: > Damien Zammit via Bug reports for the GNU Hurd, le sam. 28 déc. 2024 06:39:04 > +, a ecrit: >> + setenv ("RUMP_MEMLIMIT", "16m", 1); > Did you test this a lot? > > We'd probably want to disable rump-side caching rather than putting > pressure on i

Re: [PATCH hurd] rumpdisk: Try to reduce memory usage

2024-12-28 Thread Samuel Thibault
Hello, Damien Zammit via Bug reports for the GNU Hurd, le sam. 28 déc. 2024 06:39:04 +, a ecrit: > + setenv ("RUMP_MEMLIMIT", "16m", 1); Did you test this a lot? We'd probably want to disable rump-side caching rather than putting pressure on it. Samuel

Re: [PATCH hurd] rumpdisk: Deallocate buffers in write during failure paths

2024-12-28 Thread Samuel Thibault
Applied, thanks! Damien Zammit via Bug reports for the GNU Hurd, le sam. 28 déc. 2024 06:38:41 +, a ecrit: > --- > rumpdisk/block-rump.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/rumpdisk/block-rump.c b/rumpdisk/block-rump.c > index cd7af494..8a3a404a 100644 > --- a/rumpdis

Re: [PATCH v2 hurd] acpi: Better error handling on S_acpi_get_pci_irq

2024-12-28 Thread Samuel Thibault
Applied, thanks! Damien Zammit via Bug reports for the GNU Hurd, le sam. 28 déc. 2024 07:35:32 +, a ecrit: > Return positive error code when return value indicates error. > > --- > acpi/acpi-ops.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/acpi/acpi-ops.c b/ac

Re: [PATCH hurd] pci-arbiter: Fix long standing bug with PCI access

2024-12-27 Thread Sergey Bugaev
On Sat, Dec 28, 2024 at 9:38 AM Damien Zammit via Bug reports for the GNU Hurd wrote: > > Proxied memory was not rounded up to page size, causing > error with vm_map'ing the underlying memory. > > WARNING: Could be security risk if assumption is incorrect: > Assumes start of all pci memory resour

Re: [PATCH gnumach v2] Implement per task virtual memory limit

2024-12-25 Thread Diego Nieto Cid
Hi, Well, the holidays salutation message ended up as commit message unexpectedly. I guess for review it's ok. But I need to fix it before it's ready for commit. :(

Re: [PATCH gnumach v1] Implement per task virtual memory limit

2024-12-25 Thread Sergey Bugaev
Merry Christmas :) On Tue, Dec 24, 2024 at 8:11 PM Diego Nieto Cid wrote: > * HOST_PORT must be the privileged host control port > * if the caller desires to increase the current max limit. > * > * On the other hand, if the max limit is being decreased, the >

Re: [PATCH gnumach v1] Implement per task virtual memory limit

2024-12-24 Thread Diego Nieto Cid
On Tue, Dec 24, 2024 at 02:11:07PM -0300, Diego Nieto Cid wrote: > > I've been expanding the comment in gnumach.defs: > > /* > * Set a task virtual memory limit parameters > * > * HOST_PORT must be the privileged host control port > * if the caller desires t

Re: [PATCH gnumach v1] Implement per task virtual memory limit

2024-12-24 Thread Diego Nieto Cid
On Tue, Dec 24, 2024 at 12:44:49PM +0300, Sergey Bugaev wrote: > > + ASSERT(err == KERN_SUCCESS, "cannot set VM limits"); > > There's ASSERT_RET, which also stringifies the error code. > Good, that's much better. > > + /* check limits are actually saved */ > > + err = vm_get_size_limit(mac

Re: [PATCH Mach] kern: Comment fixed

2024-12-24 Thread Samuel Thibault
Applied, thanks! Zhaoming Luo, le mar. 24 déc. 2024 10:44:17 +0800, a ecrit: > Read also: > https://mail.gnu.org/archive/html/bug-hurd/2024-12/msg00219.html > > Signed-off-by: Zhaoming Luo > --- > kern/mach_clock.c | 2 +- > kern/mach_clock.h | 2 +- > 2 files changed, 2 insertions(+), 2 deleti

Re: [PATCH gnumach v1] Implement per task virtual memory limit

2024-12-24 Thread Sergey Bugaev
Getting really close :) On Mon, Dec 23, 2024 at 10:07 PM wrote: > + > +/* > + * Set a task virtual memory limit parameters > + */ > +routine vm_set_size_limit( > + host_port : mach_port_t; > + map : vm_task_t; > + current_limit : vm_size_t; > + max_limit

Re: [PATCH v3 0/1] Add a mach host operation which returns elapsed time since bootup

2024-12-22 Thread Zhaoming Luo
On 12/23/24 12:41 PM, Zhaoming Luo wrote: Compared with v2, an atomic operation is used to avoid data race. About the idea suggested by Luca, exposing the uptime with a kernel device that can be memory mapped, I haven't came out with an implementation I'm happy with. Any suggestion is welcome :).

Re: [PATCH v4 3/3 gnumach] apic: Add extended feature registers for local apic unit

2024-12-21 Thread Samuel Thibault
Applied, thanks! Damien Zammit via Bug reports for the GNU Hurd, le dim. 22 déc. 2024 01:43:44 +, a ecrit: > Add workaround for broken systems that advertise 8 bit APIC ids > but only match IPIs on 4 bits of the APIC id. > --- > i386/i386/apic.c | 28 +++-

Re: [PATCH v4 2/3 gnumach] smp: Use deassert for startup IPI not assert

2024-12-21 Thread Samuel Thibault
Applied, thanks! Damien Zammit via Bug reports for the GNU Hurd, le dim. 22 déc. 2024 01:43:36 +, a ecrit: > Fixes ESR==0x8 error on AMD fam15h. Fixed timings. > > Cannot locate documentation on correct mode for STARTUP IPI, > but this patch works on AMD hw and qemu. > --- > i386/i386/smp.c

Re: [PATCH v4 1/3 gnumach] smp: Parallel SMP init

2024-12-21 Thread Samuel Thibault
Applied, thanks! Damien Zammit via Bug reports for the GNU Hurd, le dim. 22 déc. 2024 01:43:28 +, a ecrit: > Now that things are in place, we switch to parallel init. > The key to this change is that the INIT/STARTUP sequence > is done in one step, and all cpus wake up at the same time. > Syn

Re: [PATCH v3 1/4 gnumach] cpuboot: Fix percpu apboot_gdt for early gs

2024-12-21 Thread Samuel Thibault
Damien Zammit via Bug reports for the GNU Hurd, le dim. 22 déc. 2024 00:48:12 +, a ecrit: > On 12/22/24 11:35 AM, Samuel Thibault wrote: > > This is quite verbose. Could you check that the attached patch on top of > > it still works? > > > > Samuel > > Your patch works and is much more readab

Re: [PATCH v3 3/4 gnumach] smp: Use deassert for startup IPI not assert

2024-12-21 Thread Samuel Thibault
Does deassert work for other models / qemu / etc. Perhaps we have a reference for this? This code seems to be receiving back&forth changes, better make sure we are going the right way. Samuel Damien Zammit via Bug reports for the GNU Hurd, le sam. 21 déc. 2024 23:55:32 +, a ecrit: > Fixes ES

Re: [PATCH v3 1/4 gnumach] cpuboot: Fix percpu apboot_gdt for early gs

2024-12-21 Thread Damien Zammit via Bug reports for the GNU Hurd
On 12/22/24 11:35 AM, Samuel Thibault wrote: > This is quite verbose. Could you check that the attached patch on top of > it still works? > > Samuel Your patch works and is much more readable. Thanks, Damien

Re: [PATCH v3 2/4 gnumach] smp: Parallel SMP init

2024-12-21 Thread Samuel Thibault
Hello, Damien Zammit via Bug reports for the GNU Hurd, le sam. 21 déc. 2024 23:55:25 +, a ecrit: > @@ -341,12 +312,16 @@ start_other_cpus(void) > lapic_disable(); > > bspdone = 0; > + > + /* This is set once for all APs to use */ > + pmap_make_temporary_mapping(); > + >

Re: [PATCH v3 1/4 gnumach] cpuboot: Fix percpu apboot_gdt for early gs

2024-12-21 Thread Samuel Thibault
Hello, Damien Zammit via Bug reports for the GNU Hurd, le sam. 21 déc. 2024 23:55:17 +, a ecrit: > + movl%eax, %ebx > + > + /* Make eax hold offset to my cpus gdt */ > + movl$((GDT_DESCR_M32 + GDT_TABLE_M32) * 4), %eax > + mul %ebp > + > + /* Patch only our own

  1   2   3   4   5   6   7   8   9   10   >