Re: memory leak in dir-lookup found

2001-06-16 Thread Roland McGrath
> As there were a lot of entries, I thought it might be easier if they > were inline. If you had made fresh patches yesterday, then it would have. But your patches were relative to an old repository state. > Do you want a format like this: > > foo/ChangeLog > > Changes in foo. > > bar/Chang

Re: memory leak in dir-lookup found

2001-06-16 Thread Neal H Walfield
On Sat, Jun 16, 2001 at 04:14:41PM -0400, Roland McGrath wrote: > I've put those in. In future, please follow the convention of pasting > ChangeLog entries into your message alone, not as patches. Those patches > often fail to apply. As there were a lot of entries, I thought it might be easier

Re: memory leak in dir-lookup found

2001-06-16 Thread Roland McGrath
I've put those in. In future, please follow the convention of pasting ChangeLog entries into your message alone, not as patches. Those patches often fail to apply. ___ Bug-hurd mailing list [EMAIL PROTECTED] http://mail.gnu.org/mailman/listinfo/bug-hu

Re: memory leak in dir-lookup found

2001-05-08 Thread Neal H Walfield
On Sat, Apr 21, 2001 at 11:00:55AM +0200, Neal H Walfield wrote: > On Sun, Apr 15, 2001 at 06:45:12PM -0400, Roland McGrath wrote: > > > I disagree, if we set *USER to NULL on failure, we get the same effect. > > > > Ok. > > Here are the necessary changes, enjoy. As you have already approved th

Re: memory leak in dir-lookup found

2001-04-21 Thread Neal H Walfield
On Sun, Apr 15, 2001 at 06:45:12PM -0400, Roland McGrath wrote: > > I disagree, if we set *USER to NULL on failure, we get the same effect. > > Ok. Here are the necessary changes, enjoy. Index: exec/ChangeLog === RCS file: /home/ne

Re: memory leak in dir-lookup found

2001-04-15 Thread Roland McGrath
> I disagree, if we set *USER to NULL on failure, we get the same effect. Ok. ___ Bug-hurd mailing list [EMAIL PROTECTED] http://mail.gnu.org/mailman/listinfo/bug-hurd

Re: memory leak in dir-lookup found

2001-04-15 Thread Neal H Walfield
On Sun, Apr 01, 2001 at 05:47:39PM -0400, Roland McGrath wrote: > > I have added several convenience function and revised the source > > appropriately. It also uses a new calling convention making > > not checking for errors difficult, however, this is at the cost > > of ABI incompatibility, howe

Re: memory leak in dir-lookup found

2001-04-13 Thread Roland McGrath
> > I don't think this is a useful interface change. To my mind, your > > interface makes it easier to fail to check for errors and more dangerous to > > do so. That is, you can just ignore the error_t return value and an > > undetected error results in an uninitialized result parameter that the

Re: memory leak in dir-lookup found

2001-04-13 Thread Neal H Walfield
> I don't think this is a useful interface change. To my mind, your > interface makes it easier to fail to check for errors and more dangerous to > do so. That is, you can just ignore the error_t return value and an > undetected error results in an uninitialized result parameter that the > carel

Re: memory leak in dir-lookup found

2001-04-01 Thread Roland McGrath
> I have added several convenience function and revised the source > appropriately. It also uses a new calling convention making > not checking for errors difficult, however, this is at the cost > of ABI incompatibility, however, I feel that this is worth it. I don't think this is a useful inter

Re: memory leak in dir-lookup found

2001-04-01 Thread Neal H Walfield
> Perhaps iohelp should have a convenience function to create an iouser > for root, or any one-uid, one-gid iouser. Then those two places you > mention would just have iohelp_create_iouser_oneid (0, 0) in their call > to make_protid. I have added several convenience function and revised the sour

Re: memory leak in dir-lookup found

2001-03-28 Thread Roland McGrath
> > Note that make_protid should check for a null pointer and treat it as > > ENOMEM. > > Uhm. There is a problem with that: Some callers (boot-start.c. > init-startup.c) pass a 0 to make finish_protid to create a iouser for root. Well, if those are the only places, i.e. that is only ever used f

Re: memory leak in dir-lookup found

2001-03-28 Thread Marcus Brinkmann
On Wed, Mar 28, 2001 at 02:33:16PM -0500, Roland McGrath wrote: > Thanks for tracking this down, Marcus. I would be inclined to change the > interface so that make_protid consumes the iouser and callers must use dup. > It is simpler and more concise code just to call dup in the arglist. Makes se

Re: memory leak in dir-lookup found

2001-03-28 Thread Roland McGrath
Thanks for tracking this down, Marcus. I would be inclined to change the interface so that make_protid consumes the iouser and callers must use dup. It is simpler and more concise code just to call dup in the arglist. Note that make_protid should check for a null pointer and treat it as ENOMEM.

Re: memory leak in dir-lookup found

2001-03-28 Thread Marcus Brinkmann
On Wed, Mar 28, 2001 at 06:40:40PM +0200, Marcus Brinkmann wrote: > Note that we know that this is not a port leak, so the dirport doesn't get > lost. The actual problem happens in conjunction with diskfs_create_protid, which > calls diskfs_finish_protid, which does not consume the iouser, but > d