Re: Small bug in libnetfs

2000-12-19 Thread Marcus Brinkmann
On Tue, Dec 19, 2000 at 05:43:35PM -0700, Michael Oberg wrote: > Shouldnt the patch read as follows? > + if (np == NULL) > +return ENOMEM; > + No, as netfs_make_node returns a void *, and not an error_t or something like that. See for example a user in hostmux/hostmux.c: netfs_root_node

Re: Small bug in libnetfs

2000-12-19 Thread Marcus Brinkmann
On Tue, Dec 19, 2000 at 06:32:16PM -0500, Igor Khavkine wrote: > I came across a potential segfault in the libnetfs code. Ah, yup. And that's not the only one of this type. You also find this in make-peropen.c has the same, and libdiskfs/file-chg.c, too. A complete list would be helpful. To do t

Re: Small bug in libnetfs

2000-12-19 Thread Michael Oberg
Shouldnt the patch read as follows? This is my understanding: Index: libnetfs/make-node.c === RCS file: /cvs/hurd/libnetfs/make-node.c,v retrieving revision 1.4 diff -u -r1.4 make-node.c --- libnetfs/make-node.c 1996/07/03 15