Re: Code for testing hurdselect.c

2012-10-19 Thread Samuel Thibault
Svante Signell, le Thu 18 Oct 2012 14:55:33 +0200, a écrit : > > > POLLNVAL > > > The specified fd value is invalid. This flag is only valid in > > > the revents member; it shall ignored in the events member. > > > > > > Specifically, my interpretation of POLLNVAL is that it should

Re: Code for testing hurdselect.c

2012-10-18 Thread Svante Signell
On Thu, 2012-10-18 at 14:40 +0200, Samuel Thibault wrote: > Svante Signell, le Thu 18 Oct 2012 14:33:53 +0200, a écrit : > > with errors specified by: > > > > ERRORS > > POSIX does not document all errors that may happen, it's completely > valid to fail for other errors. Yes, of course. > > POL

Re: Code for testing hurdselect.c

2012-10-18 Thread Samuel Thibault
Svante Signell, le Thu 18 Oct 2012 14:33:53 +0200, a écrit : > with errors specified by: > > ERRORS POSIX does not document all errors that may happen, it's completely valid to fail for other errors. > POLLNVAL > The specified fd value is invalid. This flag is only valid in > the

Re: Code for testing hurdselect.c

2012-10-18 Thread Svante Signell
On Thu, 2012-10-18 at 13:27 +0200, Samuel Thibault wrote: > Svante Signell, le Thu 18 Oct 2012 11:43:04 +0200, a écrit : > > Remember: This was written a long time ago, why making a big issue of > > it? > > > > > POSIX does not specify to return EBAFD for the POLL case as for the > > SELECT case.

Re: Code for testing hurdselect.c

2012-10-18 Thread Samuel Thibault
Svante Signell, le Thu 18 Oct 2012 11:43:04 +0200, a écrit : > Remember: This was written a long time ago, why making a big issue of > it? Because apparently your changes were made to fix an issue in ntpdate. So we need to determine exactly what the fix should be. > > The behavior of poll() on el

Re: Code for testing hurdselect.c

2012-10-18 Thread Svante Signell
On Thu, 2012-10-18 at 11:12 +0200, Richard Braun wrote: > On Thu, Oct 18, 2012 at 09:13:28AM +0200, Svante Signell wrote: > > On Tue, 2012-10-16 at 23:40 +0200, Samuel Thibault wrote: > > > Hello, > > > > > > Svante Signell, le Fri 24 Aug 2012 04:52:15 +0200, a écrit : > > > > - file descriptors w

Re: Code for testing hurdselect.c

2012-10-18 Thread Richard Braun
On Thu, Oct 18, 2012 at 09:13:28AM +0200, Svante Signell wrote: > On Tue, 2012-10-16 at 23:40 +0200, Samuel Thibault wrote: > > Hello, > > > > Svante Signell, le Fri 24 Aug 2012 04:52:15 +0200, a écrit : > > > - file descriptors were read, sorted, and the good ones registered. Why sorted ? How do

Re: Code for testing hurdselect.c

2012-10-18 Thread Svante Signell
On Tue, 2012-10-16 at 23:40 +0200, Samuel Thibault wrote: > Hello, > > Svante Signell, le Fri 24 Aug 2012 04:52:15 +0200, a écrit : > > - file descriptors were read, sorted, and the good ones registered. > > I have to say I don't understand why doing it. If there is any file > descriptor which is

Re: Code for testing hurdselect.c

2012-10-16 Thread Samuel Thibault
Hello, Svante Signell, le Fri 24 Aug 2012 04:52:15 +0200, a écrit : > - file descriptors were read, sorted, and the good ones registered. I have to say I don't understand why doing it. If there is any file descriptor which is not valid, the whole call has to return EBADF, that's what POSIX asks.