Re: Another fatfs patch

2003-07-17 Thread Marcus Brinkmann
On Thu, Jul 17, 2003 at 10:21:57PM +0200, Marco Gerards wrote: > Marco Gerards <[EMAIL PROTECTED]> writes: > > > So it should be: > > "if (round_cluster (offset) + bytes_per_cluster > node->allocsize)" > > > > I will test the code to be 100% sure it works. :) > > Ok, just ignore what I said here

Re: Another fatfs patch

2003-07-17 Thread Marco Gerards
Marco Gerards <[EMAIL PROTECTED]> writes: > So it should be: > "if (round_cluster (offset) + bytes_per_cluster > node->allocsize)" > > I will test the code to be 100% sure it works. :) Ok, just ignore what I said here. I thought it rounds the offset down, but it rounds up :). I've checked your s

Re: Another fatfs patch

2003-07-17 Thread Marco Gerards
Marcus Brinkmann <[EMAIL PROTECTED]> writes: > On Wed, Jul 16, 2003 at 08:01:19PM +0200, Marco Gerards wrote: > > Ok. The old code didn't work for clusters > 4096 because the call to > > find_cluster will be split up because the pager reads the cluster in > > two operations. > > > > The cluster i

Re: Another fatfs patch

2003-07-17 Thread Marcus Brinkmann
On Wed, Jul 16, 2003 at 08:01:19PM +0200, Marco Gerards wrote: > Ok. The old code didn't work for clusters > 4096 because the call to > find_cluster will be split up because the pager reads the cluster in > two operations. > > The cluster in a 8096 byte file will be read like this : > (first pagef

Re: Another fatfs patch

2003-07-16 Thread Marco Gerards
Marcus Brinkmann <[EMAIL PROTECTED]> writes: > Hi, > > most of the patch should go in soon (hi Jeff ;), but please keep > paying attention to the coding standard. If you split a line, make > sure operators go at the beginning of the next line and not at the end > of the current line. Ok. > >

Re: Another fatfs patch

2003-07-16 Thread Marcus Brinkmann
Hi, most of the patch should go in soon (hi Jeff ;), but please keep paying attention to the coding standard. If you split a line, make sure operators go at the beginning of the next line and not at the end of the current line. > I also removed some dead code in pager.c that only produced some >