Sergey Bugaev, le mar. 11 juil. 2023 17:52:41 +0300, a ecrit:
> On Mon, Jul 10, 2023 at 10:53 PM Samuel Thibault
> wrote:
> > llvm calls it i686-unknown-hurd-gnu (that was an intended behavior, even
> > when knowing that gnu tools call it i686-unknown-gnu), so we should
> > probably stick to that.
On Mon, Jul 10, 2023 at 10:53 PM Samuel Thibault
wrote:
> llvm calls it i686-unknown-hurd-gnu (that was an intended behavior, even
> when knowing that gnu tools call it i686-unknown-gnu), so we should
> probably stick to that.
>
> I'd tend to keep it "hurd", because "gnu" is confusing for people.
Damien Zammit, le mar. 11 juil. 2023 01:53:27 +, a ecrit:
> On 11/7/23 05:53, Samuel Thibault wrote:
> > Sergey Bugaev, le lun. 10 juil. 2023 12:22:21 +0300, a ecrit:
> >> I don't think that's correct. For one thing, dev_t is __UWORD_TYPE
> >> (like Rust usize) since glibc commit
> >> 0ec48e333
Hi,
On 11/7/23 05:53, Samuel Thibault wrote:
> Sergey Bugaev, le lun. 10 juil. 2023 12:22:21 +0300, a ecrit:
>> I don't think that's correct. For one thing, dev_t is __UWORD_TYPE
>> (like Rust usize) since glibc commit
>> 0ec48e3337506fcd33abdd86b5ab9e331564b65c, and it was u32 before that.
>
> U
Sergey Bugaev, le lun. 10 juil. 2023 12:22:21 +0300, a ecrit:
> On Sun, Jul 9, 2023 at 1:05 PM Damien Zammit wrote:
> > supported_targets! {
> > +("i686-unknown-hurd-gnu", i686_unknown_hurd_gnu),
>
> Arguably the target should be i686-unknown-gnu,
llvm calls it i686-unknown-hurd-gnu (that w
Hi Damien, Vedant --
this is exciting! Some nitpicks (to add to what Amos says) inline.
On Sun, Jul 9, 2023 at 1:05 PM Damien Zammit wrote:
> supported_targets! {
> +("i686-unknown-hurd-gnu", i686_unknown_hurd_gnu),
Arguably the target should be i686-unknown-gnu, and target_os = "gnu".
LLV
Yay! :-)
Armchair review comments inline..
On 9/07/23 22:05, Damien Zammit wrote:
This is not quite right for library/std, but applies clean to a 2021 tree
of rust on hash 25ea6be13e3 and allows up to the following stage1 build
until libstd breaks on hurd, (with the other patch for rust-libc).
