Re: [PATCH] Devnode: Fix the pseudo-master device port opening flags.

Hello, On Sat, Dec 26, 2009 at 06:57:30PM +0100, olafbuddenha...@gmx.net wrote: > On Fri, Dec 25, 2009 at 04:26:55PM +0200, Sergiu Ivanov wrote: > > > However, taking into consideration the fact that antrik answers > > E-mails pretty fast these days, > > Only those that I can answer really quick

Re: [PATCH] Devnode: Fix the pseudo-master device port opening flags.

Hi, On Fri, Dec 25, 2009 at 04:26:55PM +0200, Sergiu Ivanov wrote: > However, taking into consideration the fact that antrik answers > E-mails pretty fast these days, Only those that I can answer really quickly :-( (Yes, I have an opinion on this question -- but no time presently to write it up

Re: [PATCH] Devnode: Fix the pseudo-master device port opening flags.

Hi, Sergiu Ivanov wrote: >> Maybe devnode can detect the access right of .MASTER first before it >> calls file_name_lookup(). So if the user doesn't have write access >> to .MASTER, it just makes its own node read-only. If the user want >> to change the access right of the devnode node and want to

Re: [PATCH] Devnode: Fix the pseudo-master device port opening flags.

Hello, On Fri, Dec 25, 2009 at 09:29:07PM +0800, Da Zheng wrote: > Sergiu Ivanov wrote: > > > On Fri, Dec 25, 2009 at 05:09:40PM +0800, Da Zheng wrote: > >> Sergiu Ivanov wrote: > >>> - master_device = file_name_lookup (arg, 0, 0); > >>> + master_device = file_name_lookup (arg, O_READ |

Re: [PATCH] Devnode: Fix the pseudo-master device port opening flags.

Sergiu Ivanov wrote: > Hello, > > On Fri, Dec 25, 2009 at 05:09:40PM +0800, Da Zheng wrote: >> Sergiu Ivanov wrote: >>> - master_device = file_name_lookup (arg, 0, 0); >>> + master_device = file_name_lookup (arg, O_READ | O_WRITE, 0); >> What happens if .MASTER file is read-only? Certai

Re: [PATCH] Devnode: Fix the pseudo-master device port opening flags.

Hello, On Fri, Dec 25, 2009 at 05:09:40PM +0800, Da Zheng wrote: > > Sergiu Ivanov wrote: > > - master_device = file_name_lookup (arg, 0, 0); > > + master_device = file_name_lookup (arg, O_READ | O_WRITE, 0); > > What happens if .MASTER file is read-only? Certainly, > file_name_lookup

Re: [PATCH] Devnode: Fix the pseudo-master device port opening flags.

Sergiu Ivanov wrote: > * devnode/devnode.c (parse_opt): Open the pseudo-master > devide port with O_READ | O_WRITE flags to allow subsequent > device creation. > --- > > Hello, > > Originally, devnode would open the pseudo-master device port with 0 > flags. These flags are stored by eth-multiple