Re: [PATCH] Add libraries to Makefiles.

2023-01-20 Thread Svante Signell
On Wed, 2023-01-18 at 12:41 +0100, Samuel Thibault wrote: > I'm not talking about libz.so, but about libstore.so. Is that > libstore.so really a shared library that has libz in NEEDED? If so > there is really no need to add -lz to linking storeio. Unless you > actually send us the actual error me

Re: [PATCH] Add libraries to Makefiles.

2023-01-18 Thread Samuel Thibault
Svante Signell, le mer. 18 janv. 2023 12:36:55 +0100, a ecrit: > On Wed, 2023-01-18 at 11:54 +0100, Samuel Thibault wrote: > > > > Then you need to check that the linking of e.g. storeio does use the > > shared library and not the static library. For instance you can re-run > > the corresponding l

Re: [PATCH] Add libraries to Makefiles.

2023-01-18 Thread Svante Signell
On Wed, 2023-01-18 at 11:54 +0100, Samuel Thibault wrote: > > Then you need to check that the linking of e.g. storeio does use the > shared library and not the static library. For instance you can re-run > the corresponding linking command and add -Wl,-verbose to check in the > verbose output whic

Re: [PATCH] Add libraries to Makefiles.

2023-01-18 Thread Samuel Thibault
Svante Signell, le mer. 18 janv. 2023 11:34:32 +0100, a ecrit: > On Wed, 2023-01-18 at 11:10 +0100, Samuel Thibault wrote: > > > > That's not enough information: I'm asking about your cross-toolchain. > > > > Do you actually get e.g. libstore/libstore.so for instance? > > If so, run objdump -x on

Re: [PATCH] Add libraries to Makefiles.

2023-01-18 Thread Svante Signell
On Wed, 2023-01-18 at 11:10 +0100, Samuel Thibault wrote: > > That's not enough information: I'm asking about your cross-toolchain. > > Do you actually get e.g. libstore/libstore.so for instance? > If so, run objdump -x on it and check that libz is indeed in NEEDED. > That's what is supposed to s

Re: [PATCH] Add libraries to Makefiles.

2023-01-18 Thread Samuel Thibault
Svante Signell, le mer. 18 janv. 2023 11:05:17 +0100, a ecrit: > On Wed, 2023-01-18 at 01:54 +0100, Samuel Thibault wrote: > > But none of these directories are actually using libz, so it doesn't > > make sense to make them use -lz. > > > > Are you sure that your cross-toolchain supports linking s

Re: [PATCH] Add libraries to Makefiles.

2023-01-18 Thread Svante Signell
On Wed, 2023-01-18 at 01:54 +0100, Samuel Thibault wrote: > Hello, > > But none of these directories are actually using libz, so it doesn't > make sense to make them use -lz. > > Are you sure that your cross-toolchain supports linking shared > libraries? Here are the configure flags: CPPFLAGS

Re: [PATCH] Add libraries to Makefiles.

2023-01-17 Thread Samuel Thibault
Hello, Svante Signell, le mar. 17 janv. 2023 13:20:46 +0100, a ecrit: > The attached patch adds libraries needed when cross-building Hurd. Most > of them arise when enabling zlib with --with-libz. But none of these directories are actually using libz, so it doesn't make sense to make them use -lz