Re: Questions about patches for hurdselect.c

2013-01-13 Thread Samuel Thibault
Svante Signell, le Sun 13 Jan 2013 21:59:23 +0100, a écrit : > On Sun, 2013-01-13 at 21:31 +0100, Samuel Thibault wrote: > > Svante Signell, le Sun 13 Jan 2013 21:18:07 +0100, a écrit : > > > > - In the poll case, on error on one descriptor, the loop shall mark > > > > POLLERR and continue, not fai

Re: Questions about patches for hurdselect.c

2013-01-13 Thread Samuel Thibault
Svante Signell, le Sun 13 Jan 2013 21:59:23 +0100, a écrit : > A comment: You removed my comments about readability and > maintainability of if-then-else constructs vs case oriented code. We > seem to have different views on code constructs. As you said yourself, the end decision is Roland's, so

Re: Questions about patches for hurdselect.c

2013-01-13 Thread Svante Signell
On Sun, 2013-01-13 at 21:31 +0100, Samuel Thibault wrote: > Svante Signell, le Sun 13 Jan 2013 21:18:07 +0100, a écrit : > > > - In the poll case, on error on one descriptor, the loop shall mark > > > POLLERR and continue, not fail altogether. > > > > > > Is that right? > > > > The current code e

Re: Questions about patches for hurdselect.c

2013-01-13 Thread Samuel Thibault
Svante Signell, le Sun 13 Jan 2013 21:18:07 +0100, a écrit : > > - In the poll case, on error on one descriptor, the loop shall mark > > POLLERR and continue, not fail altogether. > > > > Is that right? > > The current code errors out if it finds one FD not OK, which is a bug. > Irrespective of h

Re: Questions about patches for hurdselect.c

2013-01-13 Thread Svante Signell
Please don't use @telia.com, it should not be usable any longer, use @gmail.com: I've changed ISP. On Sun, 2013-01-13 at 20:53 +0100, Samuel Thibault wrote: > Hello, > > Svante Signell, le Wed 12 Dec 2012 20:11:55 +0100, a écrit : > > As promised, attached is the first patch to split hurdselect.

Re: Questions about patches for hurdselect.c

2013-01-13 Thread Samuel Thibault
Hello, Svante Signell, le Wed 12 Dec 2012 20:11:55 +0100, a écrit : > As promised, attached is the first patch to split hurdselect.c code into > three cases: DELAY, POLL and SELECT, doing the first two parts as > promised in an earlier mail: > 1) Introducing three cases: DELAY, POLL, and SELECT >

Re: [PATCH,eglibc] Re: Questions about patches for hurdselect.c

2013-01-07 Thread Samuel Thibault
Svante Signell, le Tue 18 Dec 2012 14:51:59 +0100, a écrit : > On Mon, 2012-12-17 at 23:02 +0100, Svante Signell wrote: > > On Mon, 2012-12-17 at 20:58 +0100, Richard Braun wrote: > > > On Mon, Dec 17, 2012 at 03:12:10AM +0100, Svante Signell wrote: > > > > Richards patch "if (!err && got == 0 && f

Re: [PATCH,eglibc] Re: Questions about patches for hurdselect.c

2012-12-31 Thread Samuel Thibault
Svante Signell, le Sun 30 Dec 2012 00:03:17 +0100, a écrit : > ping, any comments? Haven't had the time to have a look yet. Samuel

Re: [PATCH,eglibc] Re: Questions about patches for hurdselect.c

2012-12-29 Thread Svante Signell
ping, any comments? On Thu, 2012-12-20 at 01:12 +0100, Svante Signell wrote: > On Tue, 2012-12-18 at 14:51 +0100, Svante Signell wrote: > > On Mon, 2012-12-17 at 23:02 +0100, Svante Signell wrote: > > > On Mon, 2012-12-17 at 20:58 +0100, Richard Braun wrote: > > > > On Mon, Dec 17, 2012 at 03:12:1

Re: [PATCH,eglibc] Re: Questions about patches for hurdselect.c

2012-12-19 Thread Svante Signell
On Tue, 2012-12-18 at 14:51 +0100, Svante Signell wrote: > On Mon, 2012-12-17 at 23:02 +0100, Svante Signell wrote: > > On Mon, 2012-12-17 at 20:58 +0100, Richard Braun wrote: > > > On Mon, Dec 17, 2012 at 03:12:10AM +0100, Svante Signell wrote: ... > As a follow-up the attached patch combines Rich

[PATCH,eglibc] Re: Questions about patches for hurdselect.c

2012-12-18 Thread Svante Signell
On Mon, 2012-12-17 at 23:02 +0100, Svante Signell wrote: > On Mon, 2012-12-17 at 20:58 +0100, Richard Braun wrote: > > On Mon, Dec 17, 2012 at 03:12:10AM +0100, Svante Signell wrote: > > > Richards patch "if (!err && got == 0 && firstfd != -1 && (firstfd != > > > lastfd))" does not work, apt-get up

Re: Questions about patches for hurdselect.c

2012-12-17 Thread Samuel Thibault
Svante Signell, le Mon 17 Dec 2012 22:55:22 +0100, a écrit : > On Mon, 2012-12-17 at 20:37 +0100, Samuel Thibault wrote: > > Svante Signell, le Mon 17 Dec 2012 03:12:10 +0100, a écrit : > > > > > + /* FIXME: sigmask is only used for ppoll and pselect: not yet > > > > > implemented */ > > > > > >

Re: Questions about patches for hurdselect.c

2012-12-17 Thread Svante Signell
On Mon, 2012-12-17 at 20:58 +0100, Richard Braun wrote: > On Mon, Dec 17, 2012 at 03:12:10AM +0100, Svante Signell wrote: > > Richards patch "if (!err && got == 0 && firstfd != -1 && (firstfd != > > lastfd))" does not work, apt-get update (select-based) fails. So there > > will be other means to av

Re: Questions about patches for hurdselect.c

2012-12-17 Thread Svante Signell
On Mon, 2012-12-17 at 20:37 +0100, Samuel Thibault wrote: > Svante Signell, le Mon 17 Dec 2012 03:12:10 +0100, a écrit : > > > > + /* FIXME: sigmask is only used for ppoll and pselect: not yet > > > > implemented */ > > > > > > What do you mean by not yet implemented? > > > > ppoll and pselect

Re: Questions about patches for hurdselect.c

2012-12-17 Thread Richard Braun
On Mon, Dec 17, 2012 at 03:12:10AM +0100, Svante Signell wrote: > Richards patch "if (!err && got == 0 && firstfd != -1 && (firstfd != > lastfd))" does not work, apt-get update (select-based) fails. So there > will be other means to avoid the double delay bug. Please don't mention work I haven't r

Re: Questions about patches for hurdselect.c

2012-12-17 Thread Samuel Thibault
Svante Signell, le Mon 17 Dec 2012 03:12:10 +0100, a écrit : > > > + /* FIXME: sigmask is only used for ppoll and pselect: not yet > > > implemented */ > > > > What do you mean by not yet implemented? > > ppoll and pselect are not implemented (yet), hence sigmask is NULL. ?? See ./sysdeps/mach

Re: Questions about patches for hurdselect.c

2012-12-17 Thread Svante Signell
On Mon, 2012-12-17 at 00:33 +0100, Samuel Thibault wrote: > Svante Signell, le Wed 12 Dec 2012 20:11:55 +0100, a écrit : > > --- hurdselect_orig.c 2012-10-21 22:55:26.0 +0200 > > +++ hurdselect_step1.c 2012-12-12 19:29:26.0 +0100 > > @@ -37,6 +37,13 @@ > > each of REA

Re: Questions about patches for hurdselect.c

2012-12-16 Thread Samuel Thibault
Svante Signell, le Wed 12 Dec 2012 20:11:55 +0100, a écrit : > --- hurdselect_orig.c 2012-10-21 22:55:26.0 +0200 > +++ hurdselect_step1.c2012-12-12 19:29:26.0 +0100 > @@ -37,6 +37,13 @@ > each of READFDS, WRITEFDS, EXCEPTFDS that is nonnull. If TIMEOUT is not > NULL

Re: Questions about patches for hurdselect.c

2012-12-12 Thread Svante Signell
On Fri, 2012-12-07 at 18:45 +0100, Svante Signell wrote: > On Fri, 2012-12-07 at 17:35 +0100, Samuel Thibault wrote: > > Svante Signell, le Fri 07 Dec 2012 17:13:00 +0100, a écrit : > > > In the works of rewriting hurdselect.c I have some question on how to > > > write patches. The changed code con

Re: Questions about patches for hurdselect.c

2012-12-07 Thread Svante Signell
On Fri, 2012-12-07 at 17:35 +0100, Samuel Thibault wrote: > Svante Signell, le Fri 07 Dec 2012 17:13:00 +0100, a écrit : > > In the works of rewriting hurdselect.c I have some question on how to > > write patches. The changed code contains three parts: > > 1) Introducing three cases: DELAY, POLL, a

Re: Questions about patches for hurdselect.c

2012-12-07 Thread Samuel Thibault
Svante Signell, le Fri 07 Dec 2012 17:13:00 +0100, a écrit : > In the works of rewriting hurdselect.c I have some question on how to > write patches. The changed code contains three parts: > 1) Introducing three cases: DELAY, POLL, and SELECT Why three cases? Isn't there a lot of common code betwe

Questions about patches for hurdselect.c

2012-12-07 Thread Svante Signell
Hello, In the works of rewriting hurdselect.c I have some question on how to write patches. The changed code contains three parts: 1) Introducing three cases: DELAY, POLL, and SELECT 2) Removing the unneeded code for each case statement 3) Rewriting the poll case to be compliant with POSIX Doing