Re: PATCH: Small fix in gnumach

2020-03-14 Thread Samuel Thibault
gfle...@disroot.org, le sam. 14 mars 2020 17:50:36 +, a ecrit: > Between vm_object_copy_call is marked internal use. Yes, and that makes just returning an error even more a problem: the caller will possibly just transmit the error, and it'll be hard to know where the error actually comes from.

Re: PATCH: Small fix in gnumach

2020-03-14 Thread gfleury
14 mars 2020 17:54 "Samuel Thibault" a écrit: > Hello, > > BTW it seems your mailer attaches .patch files as > application/octet-stream, you should teach it to attach it as plain > text so it shows up as such in readers' mailers. > > gfle...@disroot.org, le sam. 14 mars 2020 08:11:33 +, a e

Re: PATCH: Small fix in gnumach

2020-03-14 Thread gfleury
14 mars 2020 17:54 "Samuel Thibault" a écrit: > Hello, > > BTW it seems your mailer attaches .patch files as > application/octet-stream, you should teach it to attach it as plain > text so it shows up as such in readers' mailers. > > gfle...@disroot.org, le sam. 14 mars 2020 08:11:33 +, a e

Re: PATCH: Small fix in gnumach

2020-03-14 Thread Samuel Thibault
Hello, BTW it seems your mailer attaches .patch files as application/octet-stream, you should teach it to attach it as plain text so it shows up as such in readers' mailers. gfle...@disroot.org, le sam. 14 mars 2020 08:11:33 +, a ecrit: > > In the case of failure, you also need to release the

Re: PATCH: Small fix in gnumach

2020-03-14 Thread gfleury
hello, 14 mars 2020 00:46 "Samuel Thibault" a écrit: > Hello, > > gfle...@disroot.org, le ven. 13 mars 2020 20:55:29 +, a ecrit: > >> if the previous call vm_object_enter return VM_OBJECT_NULL in new_object >> the new_object->shadow dereference of NULL will cause a bug. >> >> attached fil

Re: PATCH: Small fix in gnumach

2020-03-13 Thread Samuel Thibault
Hello, gfle...@disroot.org, le ven. 13 mars 2020 20:55:29 +, a ecrit: > if the previous call vm_object_enter return VM_OBJECT_NULL in new_object > the new_object->shadow dereference of NULL will cause a bug. > > attached file fix this. Fix the indentation if it is not correct. In the case of

PATCH: Small fix in gnumach

2020-03-13 Thread gfleury
Hello, http://git.savannah.gnu.org/cgit/hurd/gnumach.git/tree/vm/vm_object.c#n1371 (http://git.savannah.gnu.org/cgit/hurd/gnumach.git/tree/vm/vm_object.c#n1371) if the previous call vm_object_enter return VM_OBJECT_NULL in new_object the new_object->shadow dereference of NULL will cause a bug. a