Re: [patch] setting the fsid on a bootstrap file system

2002-05-11 Thread Marcus Brinkmann
I have checked these in, thanks. On Thu, Nov 22, 2001 at 01:08:44AM +0100, Neal H Walfield wrote: > libdiskfs: > > 2001-11-20 Neal H Walfield <[EMAIL PROTECTED]> > > * diskfs.h (diskfs_boot_filesystem): Documentation fix. > > > ext2fs: > > 2001-11-20 Neal H Walfield <[EMAIL PROT

Re: [patch] setting the fsid on a bootstrap file system

2001-11-21 Thread Marcus Brinkmann
On Thu, Nov 22, 2001 at 01:08:44AM +0100, Neal H Walfield wrote: > + Note: these is only valid after the arguements have been parsed by, s/arguements/arguments/ Marcus -- `Rhubarb is no Egyptian god.' Debian http://www.debian.org [EMAIL PROTECTED] Marcus Brinkmann GNUhttp://

Re: [patch] setting the fsid on a bootstrap file system

2001-11-21 Thread Neal H Walfield
> In your remarks and in your code you've used "getuid" a few times where you > should have used "getpid". I'll assume that was just a persistent typo and > nothing more. It was, excuse me. > In yet another example of why you should separate semantically distinct > changes into separate patches

Re: [patch] setting the fsid on a bootstrap file system

2001-11-21 Thread Roland McGrath
In your remarks and in your code you've used "getuid" a few times where you should have used "getpid". I'll assume that was just a persistent typo and nothing more. None of this new complexity is worth the trouble, nor was the old complexity. The `getpid' function simply returns the value of a g

[patch] setting the fsid on a bootstrap file system

2001-11-21 Thread Neal H Walfield
We cannot set the fsid of a boot file system to its uid as, at least initially, there is no proc server. The current work around is to wait until we need the fsid and then set it. The implication is that every time we need the fsid, we must also check to see if it has been set. Although this is