Re: [patch] for mig check in GDB's configure

> No, we have not yet started that process -- but indeed perhaps already > should. Yue, the GDB project, as part of the GNU project, requires > copyright assignment for any substantial changes, > . For simplicity, I suggest > you use the »assignment fo

Re: [patch] for mig check in GDB's configure

Hi! On Fri, 17 May 2013 09:30:42 +0400, Joel Brobecker wrote: > > After reviewing and testing it, I now checked in your patch (very minor > > coding style and wording changes). Congratulations to your first > > contribution! :-) > > > > 2013-05-16 Yue Lu > > > > * configure.ac: Ensure

Re: [patch] for mig check in GDB's configure

Hi Thomas, On Fri, May 17, 2013 at 5:55 AM, Thomas Schwinge wrote: > > After reviewing and testing it, I now checked in your patch (very minor > coding style and wording changes). Congratulations to your first > contribution! :-) So thanks for your patience to guide me. I am entering the door

Re: [patch] for mig check in GDB's configure

Hi, On Fri, May 17, 2013 at 1:30 PM, Joel Brobecker wrote: > Hi Thomas and Yue, > I cannot remember if we said Yue had a copyright assignment on file, > or not. I checked the file, and couldn't locate him. Can you clarify? > As this is the first time for me to submit patches, I don't know how to

Re: [patch] for mig check in GDB's configure

Hi Thomas and Yue, > After reviewing and testing it, I now checked in your patch (very minor > coding style and wording changes). Congratulations to your first > contribution! :-) > > 2013-05-16 Yue Lu > > * configure.ac: Ensure MIG is available when building for GNU Hurd > host

Re: [patch] for mig check in GDB's configure

Hi! On Sun, 5 May 2013 10:35:25 -0700, Doug Evans wrote: > On Sat, May 4, 2013 at 10:30 PM, Yue Lu wrote: > > But I have one more question, why the one run on GNU Hurd which > > targeting arm doesn't need to use MIG? As it run under GNU Hurd, it > > must use the message transport facility and ne

Re: [patch] for mig check in GDB's configure

Hi! Sorry for the delay. On Sat, 4 May 2013 16:29:01 +0800, Yue Lu wrote: > * configure.ac: Ensure MIG is available when building for GNU > * Hurd. After reviewing and testing it, I now checked in your patch (very minor coding style and wording changes). Congratulations to your first c

Re: [patch] for mig check in GDB's configure

On Sat, May 4, 2013 at 10:30 PM, Yue Lu wrote: > But I have one more question, why the one run on GNU Hurd which > targeting arm doesn't need to use MIG? As it run under GNU Hurd, it > must use the message transport facility and need to use MIG to > generate the interface file automatically or som

Re: [patch] for mig check in GDB's configure

On Fri, May 3, 2013 at 3:43 AM, 陆岳 wrote: >> Hmm, I think that instead of only examining the host system, $host, this >> also needs to examine the target system, $target. (Please tell if the >> difference between build, host, and target system is not clear to you.) >> The MIG tool is used to gene

Re: [patch] for mig check in GDB's configure

Hi, On Sun, May 5, 2013 at 1:22 AM, Doug Evans wrote: > On Fri, May 3, 2013 at 3:43 AM, 陆岳 wrote: >>> Hmm, I think that instead of only examining the host system, $host, this >>> also needs to examine the target system, $target. (Please tell if the >>> difference between build, host, and target

Re: [patch] for mig check in GDB's configure

Hi! thanks for your review. On Fri, May 3, 2013 at 8:57 PM, Ivan Shmakov wrote: > A few minor points. > I have update this patch after your feedback. >From b50f9b2f9ab1792ad584d07c9d2da3c5857d82fe Mon Sep 17 00:00:00 2001 From: hacklu Date: Sat, 4 May 2013 16:17:25 +0800 Subject: [PAT

Re: [patch] for mig check in GDB's configure

Hi, On Fri, May 3, 2013 at 11:22 PM, Pino Toscano wrote: > Hi, > > instead of the above, what about something like this: > case "${host_os}" in > gnu*) > # Needed for GNU/Hurd. > AC_CHECK_TOOL(MIG, mig) > if test "$MIG" = "" ; then > AC_MSG_ERROR([no mig for use])

Re: [patch] for mig check in GDB's configure

Hi, Alle venerdì 3 maggio 2013, 陆岳 ha scritto: > --- a/gdb/configure.ac > +++ b/gdb/configure.ac > @@ -488,6 +488,15 @@ AC_CHECK_TOOL(WINDRES, windres) > > # Needed for GNU/Hurd. > AC_CHECK_TOOL(MIG, mig) > +case "${host}" in > + *-linux*|*-k*bsd-gnu*) > + ;; > + i[[34

Re: [patch] for mig check in GDB's configure

On 05/03/2013 09:28 AM, Thomas Schwinge wrote: > Hmm, I think that instead of only examining the host system, $host, this > also needs to examine the target system, $target. (Please tell if the > difference between build, host, and target system is not clear to you.) > The MIG tool is used to gene

Re: [patch] for mig check in GDB's configure

> 陆岳 writes: […] A few minor points. > From 13d3edd1f6dbbc20b2801cea1fc367bf9042f977 Mon Sep 17 00:00:00 2001 > From: hacklu > Date: Fri, 3 May 2013 18:27:08 +0800 > Subject: [PATCH] Patch check mig on GNU Hurd > 2013-05-3 hacklu There should be two spaces between

Re: [patch] for mig check in GDB's configure

Hi! thanks for your review. On Fri, May 3, 2013 at 4:28 PM, Thomas Schwinge wrote: > > As GDB is a GNU project, instead of just a commit message it uses > ChangeLog files. See the several ChangeLog files in the GDB sources. As > your change only touches files in gdb/, only gdb/ChangeLog is rel

Re: [patch] for mig check in GDB's configure

Hi! Adding the gdb-patches mailing list. While of course this is only relevant for the GNU Hurd port of GDB, it will get committed to the GDB source repository, so should be reviewed on the gdb-patches mailing list. It is fine (and encouraged) to CC the bug-hurd mailing list for Hurd-specific iss

[patch] for mig check in GDB's configure

hi, I found that when you missing the mid under GNU Hurd, the GDB's configure doesn't complain about that. But you will get a compile error until you do the make. So I add the check. By the way, I just check the existence of mig, have not check whether mig work correct yet. This is my first time