Re: [PATCH v6 1/2 hurd] libirqhelp: Add library

2023-07-11 Thread Samuel Thibault
Samuel Thibault, le mar. 11 juil. 2023 10:20:45 +0200, a ecrit: > Damien Zammit, le mar. 11 juil. 2023 07:58:39 +, a ecrit: > > On 11/7/23 05:47, Samuel Thibault wrote: > > > Damien Zammit, le lun. 10 juil. 2023 09:02:10 +, a ecrit: > > >> +void > > >> +irqhelp_wait_init(struct irq *irq) >

Re: [PATCH v6 1/2 hurd] libirqhelp: Add library

2023-07-11 Thread Samuel Thibault
Damien Zammit, le mar. 11 juil. 2023 07:58:39 +, a ecrit: > On 11/7/23 05:47, Samuel Thibault wrote: > > Damien Zammit, le lun. 10 juil. 2023 09:02:10 +, a ecrit: > >> +void > >> +irqhelp_wait_init(struct irq *irq) > >> +{ > >> + if (!irq) > >> +{ > >> + log_error("cannot wait on

Re: [PATCH v6 1/2 hurd] libirqhelp: Add library

2023-07-11 Thread Damien Zammit
Hi, On 11/7/23 05:47, Samuel Thibault wrote: > Damien Zammit, le lun. 10 juil. 2023 09:02:10 +, a ecrit: >> +void >> +irqhelp_wait_init(struct irq *irq) >> +{ >> + if (!irq) >> +{ >> + log_error("cannot wait on this irq to be ready\n"); >> + return; >> +} >> + >> + sem_wait

Re: [PATCH v6 1/2 hurd] libirqhelp: Add library

2023-07-10 Thread Damien Zammit
Hi, On 11/7/23 05:47, Samuel Thibault wrote: > Damien Zammit, le lun. 10 juil. 2023 09:02:10 +, a ecrit: >> +void >> +irqhelp_wait_init(struct irq *irq) >> +{ >> + if (!irq) >> +{ >> + log_error("cannot wait on this irq to be ready\n"); >> + return; >> +} >> + >> + sem_wait

Re: [PATCH v6 1/2 hurd] libirqhelp: Add library

2023-07-10 Thread Samuel Thibault
Damien Zammit, le lun. 10 juil. 2023 09:02:10 +, a ecrit: > +void > +irqhelp_wait_init(struct irq *irq) > +{ > + if (!irq) > +{ > + log_error("cannot wait on this irq to be ready\n"); > + return; > +} > + > + sem_wait(&irq->sema); > +} So, is this wait really necessary? Why

[PATCH v6 1/2 hurd] libirqhelp: Add library

2023-07-10 Thread Damien Zammit
--- Makefile | 1 + libirqhelp/Makefile | 28 libirqhelp/irqhelp.c | 378 +++ libirqhelp/irqhelp.h | 52 ++ 4 files changed, 459 insertions(+) create mode 100644 libirqhelp/Makefile create mode 100644 libirqhelp/irqhelp.c create