Re: [PATCH gnumach v2] Implement per task virtual memory limit

2025-01-04 Thread Diego Nieto Cid
Hello, On Wed, Dec 25, 2024 at 04:16:06PM -0300, dnie...@gmail.com wrote: > > +/* > + * Enforces the VM limit of a target map. > + */ > +static kern_return_t > +vm_map_enforce_limit( > + vm_map_t map, > + vm_size_t size, > + const char *fn_name) > +{ > + /* Limit is ignored for

Re: [PATCH gnumach v2] Implement per task virtual memory limit

2024-12-31 Thread Samuel Thibault
Sergey Bugaev, le mar. 31 déc. 2024 07:41:14 +0300, a ecrit: > On Tue, Dec 31, 2024 at 1:30 AM Diego Nieto Cid wrote: > > On Mon, Dec 30, 2024 at 07:08:55PM +0100, Samuel Thibault wrote: > > > You also need to take into account the case where > > > current->max_protection was NONE and new_prot is

Re: [PATCH gnumach v2] Implement per task virtual memory limit

2024-12-30 Thread Sergey Bugaev
On Tue, Dec 31, 2024 at 1:30 AM Diego Nieto Cid wrote: > On Mon, Dec 30, 2024 at 07:08:55PM +0100, Samuel Thibault wrote: > > You also need to take into account the case where > > current->max_protection was NONE and new_prot is not NONE, you then have > > to decrease size_none. > Ah right, the &

Re: [PATCH gnumach v2] Implement per task virtual memory limit

2024-12-30 Thread Diego Nieto Cid
Hi, On Mon, Dec 30, 2024 at 07:08:55PM +0100, Samuel Thibault wrote: > > Please also add printing size_null in vm_map_print. > Ok > dnie...@gmail.com, le mer. 25 déc. 2024 16:16:06 -0300, a ecrit: > > > @@ -1679,11 +1747,13 @@ kern_return_t vm_map_protect( > > vm_map_clip_end(map,

Re: [PATCH gnumach v2] Implement per task virtual memory limit

2024-12-30 Thread Samuel Thibault
Hello, Please also add printing size_null in vm_map_print. dnie...@gmail.com, le mer. 25 déc. 2024 16:16:06 -0300, a ecrit: > @@ -1160,6 +1226,8 @@ kern_return_t vm_map_enter( > > vm_map_entry_link(map, entry, new_entry); > map->size += size; > + if (max_protection == VM_PROT_NO

Re: [PATCH gnumach v2] Implement per task virtual memory limit

2024-12-25 Thread Diego Nieto Cid
Hi, Well, the holidays salutation message ended up as commit message unexpectedly. I guess for review it's ok. But I need to fix it before it's ready for commit. :(

[PATCH gnumach v2] Implement per task virtual memory limit

2024-12-25 Thread dnietoc
From: Diego Nieto Cid Merry Christmas Hurd community! I hope everyone is doing well and enjoying the holidays. This is version 2 of the VM limit patch, which without the continued support of Sergey, could not be possible. So, thanks Sergey! --- * include/mach/gnumach.defs: (vm_set_size_limit)