Re: [PATCH gnumach] Align the user stack correctly for 64 bit programs.

2023-04-03 Thread Samuel Thibault
Applied, thanks! Flavio Cruz, le dim. 02 avril 2023 23:56:31 -0400, a ecrit: > * i386/i386/thread.h: Define USER_STACK_ALIGN which is 16-byte for 64 bit > programs as recommended by the System V AMD64 guidelines. Also define > KERNEL_STACK_ALIGN which can differ from user land. > * i386/i386/p

[PATCH gnumach] Align the user stack correctly for 64 bit programs.

2023-04-02 Thread Flavio Cruz
* i386/i386/thread.h: Define USER_STACK_ALIGN which is 16-byte for 64 bit programs as recommended by the System V AMD64 guidelines. Also define KERNEL_STACK_ALIGN which can differ from user land. * i386/i386/pcb.c: Use USER_STACK_ALIGN to align the bootstrap arguments and ultimately the stack

Re: [PATCH gnumach] Align the user stack correctly for 64 bit programs.

2023-04-02 Thread Samuel Thibault
Hello, Flávio Cruz, le lun. 20 mars 2023 23:58:32 -0400, a ecrit: > On Mon, Mar 20, 2023 at 3:50 AM Luca <[1]l...@orpolo.org> wrote: > > Hi! This indeed seems to make rpc work, at least in my tests. > > Il 20/03/23 05:59, Flavio Cruz ha scritto: > > diff --git a/i386/i386/thread.h b/

Re: [PATCH gnumach] Align the user stack correctly for 64 bit programs.

2023-03-21 Thread Luca
Il 21/03/23 04:58, Flávio Cruz ha scritto: Il 20/03/23 05:59, Flavio Cruz ha scritto: > diff --git a/i386/i386/thread.h b/i386/i386/thread.h > index cb317bee..c5da7522 100644 > --- a/i386/i386/thread.h > +++ b/i386/i386/thread.h > @@ -225,6 +225,17 @@ typedef struct p

Re: [PATCH gnumach] Align the user stack correctly for 64 bit programs.

2023-03-20 Thread Flávio Cruz
Hi Luca On Mon, Mar 20, 2023 at 3:50 AM Luca wrote: > Hi! This indeed seems to make rpc work, at least in my tests. > > Il 20/03/23 05:59, Flavio Cruz ha scritto: > > diff --git a/i386/i386/thread.h b/i386/i386/thread.h > > index cb317bee..c5da7522 100644 > > --- a/i386/i386/thread.h > > +++ b/i

Re: [PATCH gnumach] Align the user stack correctly for 64 bit programs.

2023-03-20 Thread Luca
Hi! This indeed seems to make rpc work, at least in my tests. Il 20/03/23 05:59, Flavio Cruz ha scritto: diff --git a/i386/i386/thread.h b/i386/i386/thread.h index cb317bee..c5da7522 100644 --- a/i386/i386/thread.h +++ b/i386/i386/thread.h @@ -225,6 +225,17 @@ typedef struct pcb { #define STAC

[PATCH gnumach] Align the user stack correctly for 64 bit programs.

2023-03-19 Thread Flavio Cruz
* i386/i386/thread.h: Define STACK_ALIGN which is 16-byte for 64 bit programs as recommended by the System V AMD64 guidelines. * i386/i386/pcb.c: Use STACK_ALIGN to align the bootstrap arguments and ultimately the stack where the program starts on. * kern/bootstrap.c: Do not align arg_len here