On Wed, Jan 31, 2024 at 2:44 PM Samuel Thibault wrote:
> > I see you used kmem_alloc_pageable() over kmem_alloc() that I
> > suggested. Why is that?
>
> Because I have seen it used so in other places,
> notably host_ipc_marequest_info, host_slab_info,
> host_virtual_physical_table_info
Yes, exact
Sergey Bugaev, le mer. 31 janv. 2024 14:05:18 +0300, a ecrit:
> On Tue, Jan 30, 2024 at 9:45 PM Samuel Thibault
> wrote:
> > > > +kern_return_t vm_pages_phys(
> > > > + host_t host,
> > > > + vm_map_tmap,
> > > > + vm_address_t
On Tue, Jan 30, 2024 at 9:45 PM Samuel Thibault wrote:
> > > +kern_return_t vm_pages_phys(
> > > + host_t host,
> > > + vm_map_tmap,
> > > + vm_address_taddress,
> > > + vm_size_t siz
Sergey Bugaev, le mar. 30 janv. 2024 09:38:39 +0300, a ecrit:
> On Mon, Jan 29, 2024 at 11:59 PM Samuel Thibault
> wrote:
> > Please notably review the RPC part, I really don't know that much about
> > mig.
>
> Some nitpicks inline. Flávio, does what I'm saying below make sense to you?
>
> > +/*
On Tue, Jan 30, 2024 at 1:38 AM Sergey Bugaev wrote:
> Hello,
>
> On Mon, Jan 29, 2024 at 11:59 PM Samuel Thibault
> wrote:
> > Please notably review the RPC part, I really don't know that much about
> > mig.
>
> Some nitpicks inline. Flávio, does what I'm saying below make sense to you?
>
> > +
Hello,
On Mon, Jan 29, 2024 at 11:59 PM Samuel Thibault
wrote:
> Please notably review the RPC part, I really don't know that much about
> mig.
Some nitpicks inline. Flávio, does what I'm saying below make sense to you?
> +/*
> + * vm_pages_phys returns information about a region of memory
Hello
On Mon, Jan 29, 2024 at 3:59 PM Samuel Thibault
wrote:
> For rumpdisk to efficiently determine the physical address, both for
> checking whether it is below 4GiB, and for giving it to the disk
> driver, we need a gnumach primitive (and that is not conditioned by
> MACH_VM_DEBUG like mach_v
For rumpdisk to efficiently determine the physical address, both for
checking whether it is below 4GiB, and for giving it to the disk
driver, we need a gnumach primitive (and that is not conditioned by
MACH_VM_DEBUG like mach_vm_region_info and mach_vm_object_pages_phys
are).
---
Please notably re