Re: [PATCH Hurd] lwip: Properly handle errors during initialization

Sergey Bugaev, le dim. 08 déc. 2024 11:28:48 +0300, a ecrit: > On Sun, Dec 8, 2024 at 7:53 AM Zhaoming Luo wrote: > > lwip/main.c | 10 -- > > 1 file changed, 4 insertions(+), 6 deletions(-) > > Makes sense to me, thanks! > > Reviewed-by: Sergey Bugaev Thanks for the review, applied,

Re: [PATCH Hurd] lwip: Properly handle errors during initialization

On 12/8/24 5:15 PM, Sergey Bugaev wrote: On Sun, Dec 8, 2024 at 11:54 AM Zhaoming Luo wrote: Reviewed-by: Sergey Bugaev Thanks for the review. (...but I don't know exactly what you're supposed to do with that R-b line. I asked on libc-alpha last year [0], and didn't get a reply.) [0]: https

Re: [PATCH Hurd] lwip: Properly handle errors during initialization

On Sun, Dec 8, 2024 at 11:54 AM Zhaoming Luo wrote: > > Reviewed-by: Sergey Bugaev > > > Thanks for the review. > > (...but I don't know exactly what you're supposed to do with that R-b > > line. I asked on libc-alpha last year [0], and didn't get a reply.) > > [0]: https://sourceware.org/piperma

Re: [PATCH Hurd] lwip: Properly handle errors during initialization

On 12/8/24 4:28 PM, Sergey Bugaev wrote: On Sun, Dec 8, 2024 at 7:53 AM Zhaoming Luo wrote: lwip/main.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) Makes sense to me, thanks! Reviewed-by: Sergey Bugaev Thanks for the review. (...but I don't know exactly what you'r

Re: [PATCH Hurd] lwip: Properly handle errors during initialization

On Sun, Dec 8, 2024 at 7:53 AM Zhaoming Luo wrote: > lwip/main.c | 10 -- > 1 file changed, 4 insertions(+), 6 deletions(-) Makes sense to me, thanks! Reviewed-by: Sergey Bugaev (...but I don't know exactly what you're supposed to do with that R-b line. I asked on libc-alpha last year

[PATCH Hurd] lwip: Properly handle errors during initialization

--- lwip/main.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/lwip/main.c b/lwip/main.c index ff9051db..0d92589f 100644 --- a/lwip/main.c +++ b/lwip/main.c @@ -218,7 +218,7 @@ main (int argc, char **argv) task_get_bootstrap_port (mach_task_self (), &bootstrap)