Re: [PATCH Hurd]: adding a missing comment

2024-10-25 Thread Sergey Bugaev
On Fri, Oct 25, 2024 at 9:50 AM Samuel Thibault wrote: > Zhaoming Luo, le ven. 25 oct. 2024 10:43:29 +0800, a ecrit: > > it seems a bit unreliable (last commit is 7 months ago). > > Last commit not being that recent does not mean it's unreliable: it > possibly just works and doesn't need updates.

Re: [PATCH Hurd]: adding a missing comment

2024-10-24 Thread Samuel Thibault
Zhaoming Luo, le ven. 25 oct. 2024 10:43:29 +0800, a ecrit: > it seems a bit unreliable (last commit is 7 months ago). Last commit not being that recent does not mean it's unreliable: it possibly just works and doesn't need updates. Samuel

Re: [PATCH Hurd]: adding a missing comment

2024-10-24 Thread Zhaoming Luo
On 11/10/24 12:30 AM, Joshua Branson wrote: Zhaoming, if you have never used git send-email, then I recommend it! This is a short guide that will walk you through how to use it. https://git-send-email.io/ Thank you Joshua, I have tried it and it is very useful, I didn't realized this tool. I

Re: [PATCH Hurd]: adding a missing comment

2024-10-24 Thread Joshua Branson
Samuel Thibault writes: > Hello, > > Thanks for the patch, I have applied it. > > Please send your mails as text only, otherwise `git am` is disturbed and > puts the html version in the commit log... > > Samuel Zhaoming, if you have never used git send-email, then I recommend it! This is a shor

Re: [PATCH Hurd]: adding a missing comment

2024-10-24 Thread Samuel Thibault
Hello, Thanks for the patch, I have applied it. Please send your mails as text only, otherwise `git am` is disturbed and puts the html version in the commit log... Samuel Zhaoming Luo, le jeu. 24 oct. 2024 17:21:41 +0800, a ecrit: > Adding a line of missing comment > --- > diff --git a/hurd/iio

[PATCH Hurd]: adding a missing comment

2024-10-24 Thread Zhaoming Luo
Adding a line of missing comment ---diff --git a/hurd/iioctl.defs b/hurd/iioctl.defs index bd2c789f..58b7dbab 100644 --- a/hurd/iioctl.defs +++ b/hurd/iioctl.defs @@ -130,6 +130,7 @@ routine iioctl_siocgifnetmask ( skip; /* 38 SIOCGARP -- Not implemented yet */ +/* 39 SIOCGIFHWADDR */ routine i