Re: [PATCH 5/9] ext2fs: fix type of inum

2014-04-28 Thread Justus Winter
Quoting Samuel Thibault (2014-04-28 12:34:43) > Justus Winter, le Mon 28 Apr 2014 12:20:00 +0200, a écrit : > > Previously, inum was of type int, whereas dino_ref expects ino_t. On > > Hurd/x86 the former is 32 bit wide, the latter 64. If dino_ref is > > inlined, this does not seem to pose a prob

Re: [PATCH 5/9] ext2fs: fix type of inum

2014-04-28 Thread Samuel Thibault
Justus Winter, le Mon 28 Apr 2014 12:20:00 +0200, a écrit : > Previously, inum was of type int, whereas dino_ref expects ino_t. On > Hurd/x86 the former is 32 bit wide, the latter 64. If dino_ref is > inlined, this does not seem to pose a problem, but if ext2fs is > compiled with -O0, this most l

[PATCH 5/9] ext2fs: fix type of inum

2014-04-28 Thread Justus Winter
Previously, inum was of type int, whereas dino_ref expects ino_t. On Hurd/x86 the former is 32 bit wide, the latter 64. If dino_ref is inlined, this does not seem to pose a problem, but if ext2fs is compiled with -O0, this most likely results in an invalid memory access. * ext2fs/ialloc.c (ext2_